openldap-bugs

openldap-bugs@openldap.org

1 participants
20967 discussions

(ITS#5197) result.c uses ldap_pvt_thread_pool_query indiscriminately
by richton＠nbcs.rutgers.edu 23 Oct '07

23 Oct '07

Full_Name: Aaron Richton Version: RE24 OS: irrelevant URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (128.6.31.135) ldap_pvt_thread_pool_query is referenced even if --without-threads. I believe this is as simple as... --- result.c~ 2007-10-23 09:53:36.646614000 -0400 +++ result.c 2007-10-23 09:53:23.640874000 -0400 @@ -743,12 +743,14 @@ return LDAP_SIZELIMIT_EXCEEDED; } +#ifndef NO_THREADS /* Every 64 entries, check for thread pool pause */ if (( rs->sr_nentries & 0x3f == 0x3f ) && ldap_pvt_thread_pool_query( &connection_pool, LDAP_PVT_THREAD_POOL_PARAM_PAUSING, &i ) == 0 && i ) { return LDAP_BUSY; } +#endif rs->sr_type = REP_SEARCH;

1 0

Re: (ITS#5163) slapd segfaults when running as proxy-caching server
by toby＠inf.ed.ac.uk 23 Oct '07

23 Oct '07

I said: > I'll patch and report back. Apologies for the delaying in confirming... Yep, this fixed the problem I was seeing. Many thanks Toby

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by rhafer＠suse.de 23 Oct '07

23 Oct '07

On Dienstag, 23. Oktober 2007, Howard Chu wrote: > rhafer(a)suse.de wrote: > > On Dienstag, 23. Oktober 2007, ando(a)sys-net.it wrote: > >> For the records: I seem to be ble to consistently reproduce the issue > >> when running slapd under valgrind; > > > > Thanks, that seems to do the trick for me as well. > > Funny, even running either slapd.1 or slapd.2 under valgrind, it still > succeeds for me. > > >> I haven't seen it yet when running the test > >> regularly (single CPU i386, recently). > > Looking at Gavin's testrun files, diffing slapd.2.log against a successful > run, the main difference I see is that on the failed run some queries get > added into the cache later than in the successful run. As such, the > difference comes down to whether the pcache thread gets to run before the > next query arrives or not. So, still non-deterministic and not really a big > deal. Ok, so it's most probably really the same issue as in ITS#5114 Followup 20. The non-deterministic behaviour got introduced by moving the actual caching of the entries to the cleanup handler. As a result of this, the ldapsearch commands in the test suite finishes (and the next operations start) before the data has been completely cached. Which I think is not a bug. Any ideas how we could fix the test without introducing any sleep calls to it? -- Ralf

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by hyc＠symas.com 23 Oct '07

23 Oct '07

rhafer(a)suse.de wrote: > On Dienstag, 23. Oktober 2007, ando(a)sys-net.it wrote: >> For the records: I seem to be ble to consistently reproduce the issue when >> running slapd under valgrind; > Thanks, that seems to do the trick for me as well. Funny, even running either slapd.1 or slapd.2 under valgrind, it still succeeds for me. >> I haven't seen it yet when running the test >> regularly (single CPU i386, recently). Looking at Gavin's testrun files, diffing slapd.2.log against a successful run, the main difference I see is that on the failed run some queries get added into the cache later than in the successful run. As such, the difference comes down to whether the pcache thread gets to run before the next query arrives or not. So, still non-deterministic and not really a big deal. -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by rhafer＠suse.de 23 Oct '07

23 Oct '07

As discussed on committers, I have disabled the failing part of the test for now in RE24. (Should be re-enabled when the root-cause of this problem is fixed) -- Ralf

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by rhafer＠suse.de 23 Oct '07

23 Oct '07

On Dienstag, 23. Oktober 2007, ando(a)sys-net.it wrote: > For the records: I seem to be ble to consistently reproduce the issue when > running slapd under valgrind; Thanks, that seems to do the trick for me as well. > I haven't seen it yet when running the test > regularly (single CPU i386, recently). -- Ralf

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by ghenry＠suretecsystems.com 23 Oct '07

23 Oct '07

Ralf Haferkamp wrote: > Btw, could you attach your pcache configuration to this bug? It's on the ticket already Ralf: ftp://ftp.openldap.org/incoming/testrun-test020-proxycache-failing.tar.gz -- Kind Regards, Gavin Henry. Managing Director. T +44 (0) 1224 279484 M +44 (0) 7930 323266 F +44 (0) 1224 824887 E ghenry(a)suretecsystems.com Open Source. Open Solutions(tm). http://www.suretecsystems.com/

1 0

Re: (ITS#5191) Corrupted control value when using pagedresults with subordinate database
by ando＠sys-net.it 23 Oct '07

23 Oct '07

> When using pagedresults with a subordinate database, the control value of > the > returned searchResDone is corrupted. AFAIK, paged results is not supposed to work with glued databases, as its current implementation in both back-bdb/back-hdb and back-sql relies on internal properties of the storage to keep track of the state of a search. The most appropriate behavior would be to ignore the control, if not critical, or reject the operation, if critical. I take this ITS as an action to prevent paged results from working when impacting more than one glued database. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati(a)sys-net.it ---------------------------------------

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by ando＠sys-net.it 23 Oct '07

23 Oct '07

For the records: I seem to be ble to consistently reproduce the issue when running slapd under valgrind; I haven't seen it yet when running the test regularly (single CPU i386, recently). p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati(a)sys-net.it ---------------------------------------

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by rhafer＠suse.de 22 Oct '07

22 Oct '07

Btw, could you attach your pcache configuration to this bug? On Mittwoch, 17. Oktober 2007, ghenry(a)suretecsystems.com wrote: [..] > > > > I just did the same on my x86_64 dual core. Result: 1 failure and 99 > > passes. > > Might be that this bug is better reproducable on a single core machine. > > But at > > least I was able to reproduce it now. > > I can run the same command above on a x86_64 dual core on Monday, as I'm > away on business the rest of the week. > > >> Very strange.... > > > > I have fixed a very similar issue recently (at least I thought I fixed > > it :| ). I'll take a closer look tomorrow. -- Ralf

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs