openldap-bugs

openldap-bugs@openldap.org

1 participants
20965 discussions

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by quanah＠zimbra.com 30 Sep '08

30 Sep '08

--On September 30, 2008 6:20:58 PM +0000 h.b.furuseth(a)usit.uio.no wrote: > quanah(a)zimbra.com writes: >> Yes. The calling order was incorrect. It is supposed to be >> ldap_utf8_strchr(s, brkstr). > > No. Try this with the new code: > env LDAPHOST='host1 host2' valgrind clients/tools/ldapwhoami -x > It returns writes past malloced areas in ldap_str2charray(). > > options.c calls ldap_charray("host1 host2", ", ") to parse that. > It counted the number of commas and spaces in the host string. > With the new code, it instead sums up: > > number of commas in "host1 host2" > + number of commas in "ost1 host2" > + number of commas in "st1 host2" > > etc and you never count spaces. So, the solution is to revert the order of the call, but leave the loop the way it is now? --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Re: ITS#5707 [Fwd: Re: 4.7.25 deadlock]
by quanah＠zimbra.com 30 Sep '08

30 Sep '08

--On September 30, 2008 6:13:05 PM +0000 quanah(a)zimbra.com wrote: > I think their patch is broken. I rebuilt BDB 4.7 with it, and now > test008 fails on me: Never mind, test008 fails without the patch to BDB 4.7 as well, so it's not related. test008 simply no longer works for me with current RE24. --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by h.b.furuseth＠usit.uio.no 30 Sep '08

30 Sep '08

quanah(a)zimbra.com writes: > Yes. The calling order was incorrect. It is supposed to be > ldap_utf8_strchr(s, brkstr). No. Try this with the new code: env LDAPHOST='host1 host2' valgrind clients/tools/ldapwhoami -x It returns writes past malloced areas in ldap_str2charray(). options.c calls ldap_charray("host1 host2", ", ") to parse that. It counted the number of commas and spaces in the host string. With the new code, it instead sums up: number of commas in "host1 host2" + number of commas in "ost1 host2" + number of commas in "st1 host2" etc and you never count spaces. > Also the outside loop was incorrect. True. -- Hallvard

1 0

Re: ITS#5707 [Fwd: Re: 4.7.25 deadlock]
by quanah＠zimbra.com 30 Sep '08

30 Sep '08

I think their patch is broken. I rebuilt BDB 4.7 with it, and now test008 fails on me: bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") --Quanah > --On September 26, 2008 6:27:45 AM +0000 hyc(a)symas.com wrote: > >> So I guess we have to warn people about this one ourselves for a while. >> >> -------- Original Message -------- >> Subject: Re: 4.7.25 deadlock >> Date: Thu, 25 Sep 2008 23:15:31 -0700 >> From: Michael Ubell <@oracle.com> >> To: Howard Chu <hyc(a)symas.com> >> >> Howard, >> >> Generally we only post critical patches (data corruption, etc) to the >> web site. Since this one only effects those using user defined locks >> and does no damage, I don't think it will be posted. >> >> Mike >> >> >> -- >> -- Howard Chu >> CTO, Symas Corp. http://www.symas.com >> Director, Highland Sun http://highlandsun.com/hyc/ >> Chief Architect, OpenLDAP http://www.openldap.org/project/ >> >> > > > > -- > > Quanah Gibson-Mount > Principal Software Engineer > Zimbra, Inc > -------------------- > Zimbra :: the leader in open source messaging and collaboration > > -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by quanah＠zimbra.com 30 Sep '08

30 Sep '08

--On September 30, 2008 11:18:04 AM +0000 h.b.furuseth(a)usit.uio.no wrote: > quanah(a)OpenLDAP.org writes: >> utf-8.c:char * (ldap_utf8_strchr)( const char *str, const char *chr ) >> >> I.e., string, character, as normal libc functions. >> >> However, at line 125 in charray.c, it is called as: >> if ( ldap_utf8_strchr( brkstr, s ) != NULL ) { >> This order appears to be incorrect. > > No. That code counts the number of delimiters characters in the > string being split. Since brkstr can contain several characters, > the loop checks each "utf-8 character" in str against brkstr. Yes. The calling order was incorrect. It is supposed to be ldap_utf8_strchr(s, brkstr). Also the outside loop was incorrect. --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by h.b.furuseth＠usit.uio.no 30 Sep '08

30 Sep '08

quanah(a)OpenLDAP.org writes: > utf-8.c:char * (ldap_utf8_strchr)( const char *str, const char *chr ) > > I.e., string, character, as normal libc functions. > > However, at line 125 in charray.c, it is called as: > if ( ldap_utf8_strchr( brkstr, s ) != NULL ) { > This order appears to be incorrect. No. That code counts the number of delimiters characters in the string being split. Since brkstr can contain several characters, the loop checks each "utf-8 character" in str against brkstr. -- Hallvard

1 0

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by quanah＠OpenLDAP.org 29 Sep '08

29 Sep '08

Err, line 195. --Quanah --On September 30, 2008 2:52:30 AM +0000 quanah(a)OpenLDAP.org wrote: > Full_Name: Quanah Gibson-Mount > Version: 2.3, 2.4, HEAD > OS: NA > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (98.207.132.222) > > > The definition for ldap_utf8_strchr is: > > utf-8.c:char * (ldap_utf8_strchr)( const char *str, const char *chr ) > > I.e., string, character, as normal libc functions. > > However, at line 125 in charray.c, it is called as: > > if ( ldap_utf8_strchr( brkstr, s ) != NULL ) { > > This order appears to be incorrect. > > --Quanah > >

1 0

(ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by quanah＠OpenLDAP.org 29 Sep '08

29 Sep '08

Full_Name: Quanah Gibson-Mount Version: 2.3, 2.4, HEAD OS: NA URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (98.207.132.222) The definition for ldap_utf8_strchr is: utf-8.c:char * (ldap_utf8_strchr)( const char *str, const char *chr ) I.e., string, character, as normal libc functions. However, at line 125 in charray.c, it is called as: if ( ldap_utf8_strchr( brkstr, s ) != NULL ) { This order appears to be incorrect. --Quanah

1 0

Re: ITS#5717
by ando＠sys-net.it 29 Sep '08

29 Sep '08

Fixed in HEAD; test044 updated as well. Please test. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Bug- Enforcing validation when validator is NULL
by Prashant kulkarni 29 Sep '08

29 Sep '08

Hi When I am trying to add/edit the value to the attribute "protocol information" which is required in our schema I am getting the error Invalid syntax :protocol information: no validator for syntax 1.3.6.1.4.1.1466.115.121.1.42 from the earlier mailing list I have found The problem seems to be lack of validations in the schema_init.c source code for attribure 'Protocol Information' this attribute protocolInformation is defined in core.schema {"( 1.3.6.1.4.1.1466.115.121.1.42 DESC 'Protocol Information' )", 0, NULL, NULL, NULL}, including values like dnPretty ,UTF8StringValidate..etc in the code instead of NULL values will resolve my problem, but then that require the custom build and I have to do for all the attributes where validation is defined as NULL. I personally feel that for those attributes where validation are NULL in schema_init.c and other schema files, the openLDAP should not force the validation and give this error message, as all these attributes in which validation are not defined becomes unusable . In Tivoli/Sun and Microsoft Active directory LDAP validation is not enforced where validation is defined as NULL hence I am not getting these kind of error in Tivoli/Sun and Microsoft Active directory for editing of this attribute . So any idea how to resolve this ? there is any way to modify any of the config file in openldap to disable this validation for protocol information ? do I have to raise bug request for the same and is this going to be fixed in next openLDAP release. ? Any help and suggestions in this direction is highly appreciated. thanks and regards Prashant

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs