openldap-bugs

openldap-bugs@openldap.org

1 participants
20967 discussions

Re: (ITS#6747) LDAP_CONNECTIONLESS nitpicks
by Kurt＠OpenLDAP.org 14 Dec '10

14 Dec '10

My nitpick regarding this feature is that it still exists. :-) -- Kurt On Dec 14, 2010, at 6:04 AM, h.b.furuseth(a)usit.uio.no wrote: > Full_Name: Hallvard B Furuseth > Version: HEAD > OS: > URL: > Submission from: (NULL) (129.240.6.233) > Submitted by: hallvard > > > Bug: > slapd/daemon.c outputs a berval instead of berval.bv_val. > > Compiler warnings: > slapd/connection.c needs lber-int.h for ber_int_sb_read(). > libldap/<abandon.c, search.c> pass a struct sockaddr* to a char*. > > Fixing.

1 0

Re: (ITS#6474) test004 (hdb) crashes when slapd is compiled with -D_FORTIFY_SOURCE=2
by ralf＠OpenLDAP.org 14 Dec '10

14 Dec '10

Hi, Am Dienstag 14 Dezember 2010, 12:15:04 schrieb De Bonis Hamelin, Marie Antoinette (Marian - CMS): > Hi, > > Could you please confirm/share us, modifications like moving from > strcpy() to memcpy() were done also for the bdb back-end? If yes, > could you also give us in which release fixes were committed? As mentioned in a previous comment in this ITS the fix is in r1.169 of back-bdb/dn2id.c. Back-bdb didn't need a separate fix as this issue was back-hdb specific. Otherwise it would most probably not need an extra fix as well as back-bdb and back-hdb share most of their code. -- regards, Ralf

1 0

(ITS#6748) slapo-memberof can log scrambled error text
by h.b.furuseth＠usit.uio.no 14 Dec '10

14 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard memberof_value_modify() calls op->o_bd->be_modify( &op2, &rs2 ); and then uses rs2.sr_text, which can be a value on be_modify's stack. Fixing by deleting 'text=...' from the error message.

1 0

(ITS#6747) LDAP_CONNECTIONLESS nitpicks
by h.b.furuseth＠usit.uio.no 14 Dec '10

14 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard Bug: slapd/daemon.c outputs a berval instead of berval.bv_val. Compiler warnings: slapd/connection.c needs lber-int.h for ber_int_sb_read(). libldap/<abandon.c, search.c> pass a struct sockaddr* to a char*. Fixing.

1 0

Re: (ITS#6746) broken slapo-translucent failure handling
by h.b.furuseth＠usit.uio.no 14 Dec '10

14 Dec '10

I've fixed it in HEAD, unless early errors in translucent_search() should be ignored or filter errors should NOT be ignored. -- Hallvard

1 0

Re: (ITS#6238) contrib: lastbind overlay to record timestamp of last successful bind
by michael＠stroeder.com 13 Dec '10

13 Dec '10

Could we have this overlay in contrib/ shipped with 2.4.24? That would be really nice. I've tested it with 2.4.23 and it still seems to work.

1 0

Re: (ITS#6714) Patch - Mozilla NSS - implement full non-blocking semantics
by rmeggins＠redhat.com 13 Dec '10

13 Dec '10

On 12/10/2010 09:03 PM, Howard Chu wrote: > rmeggins(a)redhat.com wrote: >> I "rebased" the patch on top of a recent change: >> revision 1.24 >> date: 2010/12/06 10:31:59; author: hallvard; state: Exp; lines: +5 >> -17 >> ITS#6625 Remove some LDAP_R_COMPILEs > > I didn't quite understand the point of the discussion of SSLv2 clients > in the comments on this patch, but committed it anyway. Thanks. I usually defer to Bob Relyea - he insists this is secure, and will not use SSLv2 if it is explicitly disabled (which it is in the OpenLDAP implementation). > > I would hope that nobody is still using SSLv2 these days. Also if a > StartTLS request fails, then the rest of the code in tlsm.c should > never even be reached; the TLS sockbuf layer wouldn't be installed. In my testing, openldap server was calling the tls session_accept function after the client failed to start tls. Because the failure was on the client side (e.g. a bogus CA cert), the server left the connection flagged with c_needs_tls_accept, and called ldap_pvt_tls_accept() on the next read. I've confirmed this using both openldap 2.4 with openssl and with moznss. openssl also checks for sslv2 incoming connections, but handles error cases better (e.g. it looks for http connections), including the case where the header bytes don't match a known sslv2, v3, or tls handshake. See ssl23_get_client_hello() for more information. > >> The new patch is here: >> ftp://ftp.openldap.org/incoming/openldap-2.4.23-use-non-blocking-semantics-… >> >> >> This patch file is derived from OpenLDAP Software. All of the >> modifications to OpenLDAP Software represented in the following >> patch(es) were developed by Red Hat. Red Hat has not assigned rights >> and/or interest in this work to any party. I, Rich Megginson am >> authorized by Red Hat, my employer, to release this work under the >> following terms. >> >> Red Hat hereby place the following modifications to OpenLDAP Software >> (and only these modifications) into the public domain. Hence, these >> modifications may be freely used and/or redistributed for any purpose >> with or without attribution and/or other notice. >> >> >> >> > >

1 0

Re: (ITS#6746) broken slapo-translucent failure handling
by h.b.furuseth＠usit.uio.no 13 Dec '10

13 Dec '10

I wrote: > translucent_search() can return LDAP_COMPARE_FALSE from test_filter(). ...and other error codes too. Should it ignore all other result codes from test_filter() than LDAP_COMPARE_TRUE? -- Hallvard

1 0

(ITS#6746) broken slapo-translucent failure handling
by h.b.furuseth＠usit.uio.no 13 Dec '10

13 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard translucent_search() can return LDAP_COMPARE_FALSE from test_filter(). Should presumably be LDAP_SUCCESS. It should probably either ignore rc from overlay_op_walk() or not. Currently it ignores rc only if there are entries in tc.list. It doesn't seem to free the remaining entries in tc.list after send_search_entry() failure.

1 0

(ITS#6745) HEAD emfile race condition -> slapd stopping listening?
by h.b.furuseth＠usit.uio.no 13 Dec '10

13 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard In HEAD slapd/daemon.c, thanks to HEAD's multiple listener support: slap_listener() protects emfile with slap_daemon[0 ].sd_mutex, but slapd_remove() protects it with slap_daemon[id].sd_mutex. Maybe to compensate, slapd_remove() has code which checks if emfile is too big, but nothing checks if it is too small - which looks like slapd might never start listening again. Simplest fix: add this to slapd_remove(): if (id) ldap_pvt_thread_mutex_<lock,unlock>( &slap_daemon[0].sd_mutex ); slap_daemon[0].sd_mutex looks quite contended that way, though. Maybe a separate emfile_mutex is better.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs