openldap-bugs

openldap-bugs@openldap.org

1 participants
20967 discussions

(ITS#7452) back-mdb envflags bug
by hyc＠OpenLDAP.org 26 Nov '12

26 Nov '12

Full_Name: Howard Chu Version: 2.4.33 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (37.19.96.255) Submitted by: hyc In mdb_cf_gen, setting flags using the envflags keyword sets the wrong flags. Will be fixed shortly.

1 0

Re: (ITS#7448) "assertion failed" in MDB
by artemciy＠gmail.com 26 Nov '12

26 Nov '12

--047d7b10cce9fad8bc04cf6e2a0a Content-Type: text/plain; charset=ISO-8859-1 On Tue, Nov 27, 2012 at 3:16 AM, Howard Chu <hyc(a)symas.com> wrote: > Quanah, from past experience I know that making a test case is a research >> endeavor that can be quite costly. IMO, refusing to investigate a bug >> without a test case is not a sane support politics. >> > > Chasing "bugs" in 3rd party code that you haven't shared with us is not a > sane policy. If we can't see the code, we certainly can't identify the root > cause of the issue. Given that our library is working in our primary > application (slapd) as well as multiple other projects, the burden of proof > is on you to demonstrate that the bug is not caused by your C++ application. If you think it is acceptable for your library to die with "assert" because of a 3rd party code then I have no further questions about the "reliability" of your software. --047d7b10cce9fad8bc04cf6e2a0a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Tue, Nov 27, 2012 at 3:16 AM, Howard Chu <span dir=3D"ltr"><<a href= =3D"mailto:hyc@symas.com" target=3D"_blank">hyc(a)symas.com</a>></span> wr= ote:<br><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style= =3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"><div class=3D"im">Quanah, from past experien= ce I know that making a test case is a research<br> endeavor that can be quite costly. IMO, refusing to investigate a bug<br> without a test case is not a sane support politics.<br> </div></blockquote> <br> Chasing "bugs" in 3rd party code that you haven't shared with= us is not a sane policy. If we can't see the code, we certainly can&#3= 9;t identify the root cause of the issue. Given that our library is working= in our primary application (slapd) as well as multiple other projects, the= burden of proof is on you to demonstrate that the bug is not caused by you= r C++ application.</blockquote> <div><br></div><div>If you think it is acceptable for your library to die w= ith "assert" because of a 3rd party code then I have no further q= uestions about the "reliability" of your software.</div></div> --047d7b10cce9fad8bc04cf6e2a0a--

1 0

Re: (ITS#7448) "assertion failed" in MDB
by hyc＠symas.com 26 Nov '12

26 Nov '12

artemciy(a)gmail.com wrote: > --e89a8f3b55c652009c04cf6d24b9 > Content-Type: text/plain; charset=ISO-8859-1 > > On Tue, Nov 27, 2012 at 1:54 AM, Quanah Gibson-Mount <quanah(a)zimbra.com>wrote: > >> You can close the issue then, because I won't be producing one. >>> >> >> I don't understand why you would take the time to report a bug, but then >> refuse to provide the information necessary to fix it. That is not >> particularly helpful. :/ >> >> --Quanah >> > > Quanah, from past experience I know that making a test case is a research > endeavor that can be quite costly. IMO, refusing to investigate a bug > without a test case is not a sane support politics. Chasing "bugs" in 3rd party code that you haven't shared with us is not a sane policy. If we can't see the code, we certainly can't identify the root cause of the issue. Given that our library is working in our primary application (slapd) as well as multiple other projects, the burden of proof is on you to demonstrate that the bug is not caused by your C++ application. > For now I have found switching to Leveldb easier than taking another > library for maintance (e.g. http://lambda-the-ultimate.org/node/4636 -> > http://akkartik.name/blog/libraries). > BTW, here is an example of good support: > http://tracker.newdream.net/issues/3495 -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7448) "assertion failed" in MDB
by artemciy＠gmail.com 26 Nov '12

26 Nov '12

--e89a8f3b55c652009c04cf6d24b9 Content-Type: text/plain; charset=ISO-8859-1 On Tue, Nov 27, 2012 at 1:54 AM, Quanah Gibson-Mount <quanah(a)zimbra.com>wrote: > You can close the issue then, because I won't be producing one. >> > > I don't understand why you would take the time to report a bug, but then > refuse to provide the information necessary to fix it. That is not > particularly helpful. :/ > > --Quanah > Quanah, from past experience I know that making a test case is a research endeavor that can be quite costly. IMO, refusing to investigate a bug without a test case is not a sane support politics. For now I have found switching to Leveldb easier than taking another library for maintance (e.g. http://lambda-the-ultimate.org/node/4636 -> http://akkartik.name/blog/libraries). BTW, here is an example of good support: http://tracker.newdream.net/issues/3495 --e89a8f3b55c652009c04cf6d24b9 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Tue, Nov 27, 2012 at 1:54 AM, Quanah Gibson-Mount <span dir=3D"ltr"><= <a href=3D"mailto:quanah@zimbra.com" target=3D"_blank">quanah(a)zimbra.com</a= >></span> wrote:<br><div class=3D"gmail_quote"><blockquote class=3D"gmai= l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left= :1ex"> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"><div class=3D"im">You can close the issue th= en, because I won't be producing one.<br> </div></blockquote> <br> I don't understand why you would take the time to report a bug, but the= n refuse to provide the information necessary to fix it. =A0That is not par= ticularly helpful. :/<br> <br> --Quanah<br></blockquote><div><br></div><div>Quanah, from past experience I= know that making a test case is a research endeavor that can be quite cost= ly. IMO, refusing to investigate a bug without a test case is not a sane su= pport politics.</div> <div>For now I have found switching to Leveldb easier than taking another l= ibrary for maintance (e.g. <a href=3D"http://lambda-the-ultimate.org/node/4= 636">http://lambda-the-ultimate.org/node/4636</a> -> <a href=3D"http://a= kkartik.name/blog/libraries">http://akkartik.name/blog/libraries</a>).</div= > <div>BTW, here is an example of good support:=A0<a href=3D"http://tracker.n= ewdream.net/issues/3495">http://tracker.newdream.net/issues/3495</a></div><= /div> --e89a8f3b55c652009c04cf6d24b9--

1 0

Re: (ITS#7448) "assertion failed" in MDB
by quanah＠zimbra.com 26 Nov '12

26 Nov '12

--On Monday, November 26, 2012 12:01 PM +0000 artemciy(a)gmail.com wrote: > --047d7b339025cf973e04cf64ae11 > Content-Type: text/plain; charset=ISO-8859-1 > > On Mon, Nov 26, 2012 at 4:55 AM, Howard Chu <hyc(a)symas.com> wrote: > >> We will investigate this when a reproducible test case is available. >> > > You can close the issue then, because I won't be producing one. I don't understand why you would take the time to report a bug, but then refuse to provide the information necessary to fix it. That is not particularly helpful. :/ --Quanah -- Quanah Gibson-Mount Sr. Member of Technical Staff Zimbra, Inc A Division of VMware, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

(ITS#7451) [PATCH] slapcat: fix segfault when unable to get database first entry
by jvcelak＠redhat.com 26 Nov '12

26 Nov '12

Full_Name: Jan Vcelak Version: git master OS: Linux URL: ftp://ftp.openldap.org/incoming/jvcelak-121126-slapcat-fix-segfault-unable-… Submission from: (NULL) (209.132.186.34) Tool slapcat segfaults when there is an empty slapd.d config directory and 'slapcat -c -H ldap:///cn=config' is invoked. # gdb --args ./servers/slapd/slapcat -c -H 'ldap:///cn=config' ... (gdb) r ... [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". # no data for entry id=00000000 Program received signal SIGSEGV, Segmentation fault. 0x000000000052d761 in ldif_tool_entry_next (be=0x8ac250) at ../../../../servers/slapd/back-ldif/ldif.c:1743 1743 Entry *e = tl->entries[ tl->ecurrent ]; (gdb) bt full #0 0x000000000052d761 in ldif_tool_entry_next (be=0x8ac250) at ../../../../servers/slapd/back-ldif/ldif.c:1743 e = 0x8ac250 tl = 0x989560 #1 0x000000000043c83d in config_tool_entry_next (be=0x9892d0) at ../../../servers/slapd/bconfig.c:7254 cfb = 0x8ac240 bi = 0x8a3dc0 #2 0x00000000004f0dac in slapcat (argc=4, argv=0x7fffffffdfe8) at ../../../servers/slapd/slapcat.c:99 id = 0 rc = 1 op = {o_hdr = 0x0, o_tag = 0, o_time = 0, o_tincr = 0, o_bd = 0x9892d0, o_req_dn = {bv_len = 0, bv_val = 0x0}, o_req_ndn = {bv_len = 0, bv_val = 0x0}, o_request = {oq_add = {rs_modlist = 0x0, rs_e = 0x0}, oq_bind = {rb_method = 0, rb_cred = {bv_len = 0, bv_val = 0x0}, rb_edn = {bv_len = 0, bv_val = 0x0}, rb_ssf = 0, rb_mech = {bv_len = 0, bv_val = 0x0}}, oq_compare = {rs_ava = 0x0}, oq_modify = {rs_mods = {rs_modlist = 0x0, rs_no_opattrs = 0 '\000'}, rs_increment = 0}, oq_modrdn = {rs_mods = { rs_modlist = 0x0, rs_no_opattrs = 0 '\000'}, rs_deleteoldrdn = 0, rs_newrdn = {bv_len = 0, bv_val = 0x0}, rs_nnewrdn = {bv_len = 0, bv_val = 0x0}, rs_newSup = 0x0, rs_nnewSup = 0x0}, oq_search = {rs_scope = 0, rs_deref = 0, rs_slimit = 0, rs_tlimit = 0, rs_limit = 0x0, rs_attrsonly = 0, rs_attrs = 0x0, rs_filter = 0x0, rs_filterstr = {bv_len = 0, bv_val = 0x0}}, oq_abandon = {rs_msgid = 0}, oq_cancel = {rs_msgid = 0}, oq_extended = {rs_reqoid = {bv_len = 0, bv_val = 0x0}, rs_flags = 0, rs_reqdata = 0x0}, oq_pwdexop = {rs_extended = {rs_reqoid = {bv_len = 0, bv_val = 0x0}, rs_flags = 0, rs_reqdata = 0x0}, rs_old = {bv_len = 0, bv_val = 0x0}, rs_new = {bv_len = 0, bv_val = 0x0}, rs_mods = 0x0, rs_modtail = 0x0}}, o_abandon = 0, o_cancel = 0, o_groups = 0x0, o_do_not_cache = 0 '\000', o_is_auth_check = 0 '\000', o_dont_replicate = 0 '\000', o_acl_priv = ACL_NONE, o_nocaching = 0 '\000', o_delete_glue_parent = 0 '\000', o_no_schema_check = 0 '\000', o_no_subordinate_glue = 0 '\000', o_ctrlflag = '\000' <repeats 31 times>, o_controls = 0x0, o_authz = {sai_method = 0, sai_mech = {bv_len = 0, bv_val = 0x0}, sai_dn = {bv_len = 0, bv_val = 0x0}, sai_ndn = {bv_len = 0, bv_val = 0x0}, sai_ssf = 0, sai_transport_ssf = 0, sai_tls_ssf = 0, sai_sasl_ssf = 0}, o_ber = 0x0, o_res_ber = 0x0, o_callback = 0x0, o_ctrls = 0x0, o_csn = {bv_len = 0, bv_val = 0x0}, o_private = 0x0, o_extra = {slh_first = 0x0}, o_next = {stqe_next = 0x0}} progname = 0x62e5d8 "slapcat" requestBSF = 1 doBSF = 0 __PRETTY_FUNCTION__ = "slapcat" #3 0x0000000000424581 in main (argc=4, argv=0x7fffffffdfe8) at ../../../servers/slapd/main.c:411 i = 1 no_detach = 0 rc = 1 urls = 0x0 username = 0x0 groupname = 0x0 sandbox = 0x0 syslogUser = 160 pid = 0 waitfds = {-8560, 32767} g_argc = 4 g_argv = 0x7fffffffdfe8 configfile = 0x0 configdir = 0x0 serverName = 0x7fffffffe265 "slapcat" serverMode = 1 scp = 0x0 scp_entry = 0x0 debug_unknowns = 0x0 syslog_unknowns = 0x0 serverNamePrefix = 0x60c858 "" l = 1 slapd_pid_file_unlink = 0 slapd_args_file_unlink = 0 firstopt = 1 __PRETTY_FUNCTION__ = "main" The attached file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Red Hat. Red Hat has not assigned rights and/or interest in this work to any party. I, Jan Vcelak am authorized by Red Hat, my employer, to release this work under the following terms. Red Hat hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.

1 0

Re: (ITS#7448) "assertion failed" in MDB
by artemciy＠gmail.com 26 Nov '12

26 Nov '12

--047d7b339025cf973e04cf64ae11 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Nov 26, 2012 at 4:55 AM, Howard Chu <hyc(a)symas.com> wrote: > We will investigate this when a reproducible test case is available. > You can close the issue then, because I won't be producing one. --047d7b339025cf973e04cf64ae11 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <div class=3D"gmail_quote">On Mon, Nov 26, 2012 at 4:55 AM, Howard Chu <spa= n dir=3D"ltr"><<a href=3D"mailto:hyc@symas.com" target=3D"_blank">hyc@sy= mas.com</a>></span> wrote:<br><blockquote class=3D"gmail_quote" style=3D= "margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> We will investigate this when a reproducible test case is available.<span c= lass=3D"HOEnZb"><font color=3D"#888888"><br></font></span></blockquote><br>= </div>You can close the issue then, because I won't be producing one.<b= r> --047d7b339025cf973e04cf64ae11--

1 0

Re: (ITS#7444) Check the return value of ldap_pvt_thread_set_concurrency
by tixu＠cs.ucsd.edu 26 Nov '12

26 Nov '12

--f46d04428c6e0fb88b04cf62891a Content-Type: text/plain; charset=ISO-8859-1 On Sun, Nov 25, 2012 at 7:54 PM, Howard Chu <hyc(a)symas.com> wrote: > tixu(a)cs.ucsd.edu wrote: > >> Full_Name: Tianyin Xu >> Version: 2.4.33 >> OS: Ubuntu 12.04 (actually doesn't matter) >> URL: >> Submission from: (NULL) (2607:f720:1300:1241:590b:49c:**889f:7b21) >> >> >> Hi, all, >> >> Still the verbosity idea. In the current version of slapd, when handling >> users' >> "concurrency" setting, slapd does not check the return value of >> "ldap_pvt_thread_set_**concurrency" (essentially the return value of >> "pthread_setconcurrency") to see whether the setting is successful or not. >> >> So when the user setting is inappropriate (i.e., too big), slapd says >> nothing. >> But users have no way to be aware of such configuration failure. I >> suggest to >> check and notify users in this case. >> > > pthread_setconcurrency is a no-op on Linux systems. Even on systems where > this setting might have an effect, it is generally unused. We have more > important things to worry about than this. > > Yes, I understand that user configuration is never a high-priority issue. That's why I attached my patch which simply checks the return value, and prints out a log messge to notify users. The patch itself does not have any side effect to other part of code. I personally think the verbosity idea can improve the system reactions to users' configurations including this one and its #7443. It is safe (no side effect) and easy to do (simply adding some log messages), but can greatly improve the usability and friendlyness to configurations. If you agree, I'm happy to write patches and corresponding code. Thanks, Tianyin > Here's the patch: >> >> --- ../openldap-2.4.33/servers/**slapd/bconfig.c 2012-10-10 >> 05:18:49.000000000 -0700 >> +++ servers/slapd/bconfig.c 2012-11-16 14:52:37.211421828 -0800 >> @@ -1530,7 +1530,14 @@ >> break; >> >> case CFG_CONCUR: >> - ldap_pvt_thread_set_**concurrency(c->value_int); >> + >> + if(ldap_pvt_thread_set_**concurrency(c->value_int) >> != 0) >> { >> + snprintf( c->cr_msg, sizeof( c->cr_msg ), >> + "concurrency=%d is not valid; >> using >> the default setting", >> + c->value_int ); >> + Debug(LDAP_DEBUG_ANY, "%s: %s.\n", >> c->log, >> c->cr_msg, 0 ); >> + >> + } >> break; >> >> case CFG_THREADS: >> >> >> >> > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/**project/<http://www.openldap.org/project/> > -- Tianyin XU, http://cseweb.ucsd.edu/~tixu/ --f46d04428c6e0fb88b04cf62891a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Sun, Nov 25, 2= 012 at 7:54 PM, Howard Chu <span dir=3D"ltr"><<a href=3D"mailto:hyc@syma= s.com" target=3D"_blank">hyc(a)symas.com</a>></span> wrote:<br><blockquote= class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc soli= d;padding-left:1ex"> <div class=3D"im"><a href=3D"mailto:tixu@cs.ucsd.edu" target=3D"_blank">tix= u(a)cs.ucsd.edu</a> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> Full_Name: Tianyin Xu<br> Version: 2.4.33<br> OS: Ubuntu 12.04 (actually doesn't matter)<br> URL:<br> Submission from: (NULL) (2607:f720:1300:1241:590b:49c:<u></u>889f:7b21)<br> <br> <br> Hi, all,<br> <br> Still the verbosity idea. In the current version of slapd, when handling us= ers'<br> "concurrency" setting, slapd does not check the return value of<b= r> "ldap_pvt_thread_set_<u></u>concurrency" (essentially the return = value of<br> "pthread_setconcurrency") to see whether the setting is successfu= l or not.<br> <br> So when the user setting is inappropriate (i.e., too big), slapd says nothi= ng.<br> But users have no way to be aware of such configuration failure. I suggest = to<br> check and notify users in this case.<br> </blockquote> <br></div> pthread_setconcurrency is a no-op on Linux systems. Even on systems where t= his setting might have an effect, it is generally unused. We have more impo= rtant things to worry about than this.<div class=3D"HOEnZb"><div><br></div> </div></blockquote><div><br>Yes, I understand that user configuration is ne= ver a high-priority issue. That's why I attached my patch which simply = checks the return value, and prints out a log messge to notify users. The p= atch itself does not have any side effect to other part of code. <br> <br>I personally think the verbosity idea can improve the system reactions = to users' configurations including this one and its #7443. It is safe (= no side effect) and easy to do (simply adding some log messages), but can g= reatly improve the usability and friendlyness to configurations. If you agr= ee, I'm happy to write patches and corresponding code. <br> <br>Thanks,<br>Tianyin<br><br>=A0</div><blockquote class=3D"gmail_quote" st= yle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div = class=3D"HOEnZb"><div class=3D"h5"> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> Here's the patch:<br> <br> --- ../openldap-2.4.33/servers/<u></u>slapd/bconfig.c =A0 =A0 =A02012-10-10= <br> 05:18:49.000000000 -0700<br> +++ servers/slapd/bconfig.c =A0 =A0 2012-11-16 14:52:37.211421828 -0800<br> @@ -1530,7 +1530,14 @@<br> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;<br> <br> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case CFG_CONCUR:<br> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ldap_pvt_thread_set_<u></u>co= ncurrency(c->value_int);<br> +<br> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if(ldap_pvt_thread_set_<u>= </u>concurrency(c->value_int) !=3D 0)<br> {<br> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 snprintf( c-&= gt;cr_msg, sizeof( c->cr_msg ),<br> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 "concurrency=3D%d is not valid; using<br> the default setting",<br> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 c->value_int );<br> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Debug(LDAP= _DEBUG_ANY, "%s: %s.\n", c->log,<br> c->cr_msg, 0 );<br> +<br> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }<br> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;<br> <br> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case CFG_THREADS:<br> <br> <br> <br> </blockquote> <br> <br></div></div><span class=3D"HOEnZb"><font color=3D"#888888"> -- <br> =A0 -- Howard Chu<br> =A0 CTO, Symas Corp. =A0 =A0 =A0 =A0 =A0 <a href=3D"http://www.symas.com" t= arget=3D"_blank">http://www.symas.com</a><br> =A0 Director, Highland Sun =A0 =A0 <a href=3D"http://highlandsun.com/hyc/" = target=3D"_blank">http://highlandsun.com/hyc/</a><br> =A0 Chief Architect, OpenLDAP =A0<a href=3D"http://www.openldap.org/project= /" target=3D"_blank">http://www.openldap.org/<u></u>project/</a><br> </font></span></blockquote></div><br><br clear=3D"all"><br>-- <br><span sty= le=3D"border-collapse:separate;color:rgb(0,0,0);font-family:'Times New = Roman';font-style:normal;font-variant:normal;font-weight:normal;letter-= spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;t= ext-transform:none;white-space:normal;word-spacing:0px;font-size:medium"><s= pan style=3D"color:rgb(102,102,102);font-family:arial;font-size:small">Tian= yin XU,<br> <a href=3D"http://cseweb.ucsd.edu/%7Etixu/" target=3D"_blank">http://cseweb= .ucsd.edu/~tixu/</a></span></span><br> </div> --f46d04428c6e0fb88b04cf62891a--

1 0

Re: (ITS#7450) segfault with listener-threads=8
by jackie.qq.zhang＠gmail.com 25 Nov '12

25 Nov '12

Hi, Howard, Thanks for the explanation. Yes, it seems that I was confused by the numbers. I cannot reproduce the case when setting listener-thread as 8. It's possible that I confused myself by setting the number many times. I thought the number is to specify the listening threads but it seems my understanding was wrong. Best regards, Jackie On Sun, Nov 25, 2012 at 7:40 PM, Howard Chu <hyc(a)symas.com> wrote: > jackie.qq.zhang(a)gmail.com wrote: >> >> Hi, Howard, >> >> GDB did stop at the statement: >> **assert( SLAP_SOCK_NOT_ACTIVE(id, s) );** >> >> But the system output is >> **Segmentation fault (core dumped)** >> >> It seems not related to whether it's a power of 2 or not, because even >> I specify it as 64, i.e., 2^6, the result and error message are still >> the same. > > > That's to be expected since currently this setting has a hard-coded maximum > of 16. Unless you have a machine with more than 1024 cores, I don't think > your setting is valid. > > So again, this bug report is invalid. > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7444) Check the return value of ldap_pvt_thread_set_concurrency
by hyc＠symas.com 25 Nov '12

25 Nov '12

tixu(a)cs.ucsd.edu wrote: > Full_Name: Tianyin Xu > Version: 2.4.33 > OS: Ubuntu 12.04 (actually doesn't matter) > URL: > Submission from: (NULL) (2607:f720:1300:1241:590b:49c:889f:7b21) > > > Hi, all, > > Still the verbosity idea. In the current version of slapd, when handling users' > "concurrency" setting, slapd does not check the return value of > "ldap_pvt_thread_set_concurrency" (essentially the return value of > "pthread_setconcurrency") to see whether the setting is successful or not. > > So when the user setting is inappropriate (i.e., too big), slapd says nothing. > But users have no way to be aware of such configuration failure. I suggest to > check and notify users in this case. pthread_setconcurrency is a no-op on Linux systems. Even on systems where this setting might have an effect, it is generally unused. We have more important things to worry about than this. > Here's the patch: > > --- ../openldap-2.4.33/servers/slapd/bconfig.c 2012-10-10 > 05:18:49.000000000 -0700 > +++ servers/slapd/bconfig.c 2012-11-16 14:52:37.211421828 -0800 > @@ -1530,7 +1530,14 @@ > break; > > case CFG_CONCUR: > - ldap_pvt_thread_set_concurrency(c->value_int); > + > + if(ldap_pvt_thread_set_concurrency(c->value_int) != 0) > { > + snprintf( c->cr_msg, sizeof( c->cr_msg ), > + "concurrency=%d is not valid; using > the default setting", > + c->value_int ); > + Debug(LDAP_DEBUG_ANY, "%s: %s.\n", c->log, > c->cr_msg, 0 ); > + > + } > break; > > case CFG_THREADS: > > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs