openldap-bugs

openldap-bugs@openldap.org

1 participants
21065 discussions

(ITS#7662) dangling reader in back-mdb
by hyc＠OpenLDAP.org 10 Aug '13

10 Aug '13

Full_Name: Howard Chu Version: 2.4.35 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (78.155.233.73) Submitted by: hyc mdb_entry_get() acquires a reader txn to retrieve the specified entry, and mdb_entry_release() releases the reader txn. If mdb_entry_get() fails (e.g., the specified entry doesn't exist) then mdb_entry_release() doesn't get called. A fix will be committed shortly.

1 0

Re: (ITS#7660) LMDB: Proposing a small addition to the API: mdb_txn_env
by h.b.furuseth＠usit.uio.no 10 Aug '13

10 Aug '13

Salvador Ortiz <sog(a)msg.com.mx> writes: > I want to avoid as much as possible the need to duplicate LMDB's state in perl, > in particular dbi's flags, so I need a method to obtain the MDB_env from a > MDB_txn, but the required API is missing. > > In the same spirit of mdb_cursor_txn or mdb_cursor_dbi I propose adding > mdb_txn_env. Maybe there should be an mdb_txn_info() function instead: typedef struct MDB_txninfo { int mt_lib_version; /* library version, set by liblmdb */ MDB_env *mt_env; } MDB_txninfo; #define mdb_txn_info(txn, ti) mdb_txn_xinfo(txn, ti, MDB_VERSION_FULL) int mdb_txn_xinfo(MDB_txn *txn, MDB_txninfo *ti, int api_version); The version parameter is so we can extend MDB_txninfo later, and liblmdb will know how much of MDB_txninfo it can fill in. The caller can zero out the txninfo before the call, so he'll be prepared if an older liblmdb does not support and set all fields. -- Hallvard

1 0

Re: (ITS#7656) Build: Installing LMDB on OS X
by hyc＠symas.com 10 Aug '13

10 Aug '13

john(a)jahewson.com wrote: > Full_Name: John Hewson > Version: 2.4.35 > OS: OS X 10.8.4 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (76.175.89.135) > > > I can't install liblmdb on OS X because its Makefile assumes that cp can > handle multiple source files, rather than the basic POSIX cp, which can't. > This leads to the situation on OS X where: > > cp source1 source2 dest > > throws an error. Thanks for the report, fixed in mdb.master > > The breaks the LMDB Makefile, because its install attempts to do: > > ILIBS = liblmdb.a liblmdb.so > ... > cp $(IPROGS) $(DESTDIR)$(prefix)/bin > > Most makefiles I've encountered use a for loop for copying multiple files, > so the fix for the Makefile is to change `install` to: > > install: $(ILIBS) $(IPROGS) $(IHDRS) > for f in $(IPROGS); do cp $$f $(DESTDIR)$(prefix)/bin; done > for f in $(ILIBS); do cp $$f $(DESTDIR)$(prefix)/lib; done > for f in $(IHDRS); do cp $$f $(DESTDIR)$(prefix)/include; done > for f in $(IDOCS); do cp $$f $(DESTDIR)$(prefix)/man/man1; done > > Then LMDB builds and installs successfully on OS X. > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7660) LMDB: Proposing a small addition to the API: mdb_txn_env
by hyc＠symas.com 10 Aug '13

10 Aug '13

sog(a)msg.com.mx wrote: > Full_Name: Salvador Ortiz > Version: 24 > OS: Linux > URL: ftp://ftp.msg.com.mx/pub/varios/Add-mdb_txn_env-to-API.patch > Submission from: (NULL) (187.162.45.111) > > > I'm writing from scratch a wrapper of LMDB for the Perl language, the project is > progressing fast and looks very promising. Thank you for a wonderful library! > > I want to avoid as much as possible the need to duplicate LMDB's state in perl, > in particular dbi's flags, so I need a method to obtain the MDB_env from a > MDB_txn, but the required API is missing. > > In the same spirit of mdb_cursor_txn or mdb_cursor_dbi I propose adding > mdb_txn_env. Looks fine, thanks. In mdb.master. > > Provided a patch against gitorious mdb.master. > > Any comments or questions more than welcome. > > Regards. > > Salvador > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7661) LMDB: Can't get the current flags of MAIN_DBI
by hyc＠symas.com 10 Aug '13

10 Aug '13

sog(a)msg.com.mx wrote: > Full_Name: Salvador Ortiz > Version: 24 > OS: Linux > URL: > Submission from: (NULL) (187.162.45.111) > > > The API allows to set the flags of the unnamed db (MAIN_DBI), but try to get > them back fails with EINVAL. > > The fix is trivial: Thanks, fixed in mdb.master > --- a/libraries/liblmdb/mdb.c > +++ b/libraries/liblmdb/mdb.c > @@ -7871,7 +7871,7 @@ void mdb_dbi_close(MDB_env *env, MDB_dbi dbi) > int mdb_dbi_flags(MDB_env *env, MDB_dbi dbi, unsigned int *flags) > { > /* We could return the flags for the FREE_DBI too but what's the point? > */ > - if (dbi <= MAIN_DBI || dbi >= env->me_numdbs) > + if (dbi < MAIN_DBI || dbi >= env->me_numdbs) > return EINVAL; > *flags = env->me_dbflags[dbi]; > return MDB_SUCCESS; > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#7661) LMDB: Can't get the current flags of MAIN_DBI
by sog＠msg.com.mx 09 Aug '13

09 Aug '13

Full_Name: Salvador Ortiz Version: 24 OS: Linux URL: Submission from: (NULL) (187.162.45.111) The API allows to set the flags of the unnamed db (MAIN_DBI), but try to get them back fails with EINVAL. The fix is trivial: --- a/libraries/liblmdb/mdb.c +++ b/libraries/liblmdb/mdb.c @@ -7871,7 +7871,7 @@ void mdb_dbi_close(MDB_env *env, MDB_dbi dbi) int mdb_dbi_flags(MDB_env *env, MDB_dbi dbi, unsigned int *flags) { /* We could return the flags for the FREE_DBI too but what's the point? */ - if (dbi <= MAIN_DBI || dbi >= env->me_numdbs) + if (dbi < MAIN_DBI || dbi >= env->me_numdbs) return EINVAL; *flags = env->me_dbflags[dbi]; return MDB_SUCCESS;

1 0

Re: (ITS#7660) LMDB: Proposing a small addition to the API: mdb_txn_env
by sog＠msg.com.mx 09 Aug '13

09 Aug '13

Sure! In fact I want the module to become the "oficial" Perl's LMDB module. Right now I'm writing an extensive test battery that is uncovering some bad assumptions, undocumented features, and/or bugs in the library. Please expect the announce of an alpha release early in the next week in openldap-devel. I'm Just waiting for a version of LMDB in git with the issues solved. Salvador. On 08/09/2013 05:55 PM, Quanah Gibson-Mount wrote: > > Will you be publishing the module on CPAN? > > --Quanah > >

1 0

Re: (ITS#7660) LMDB: Proposing a small addition to the API: mdb_txn_env
by quanah＠zimbra.com 09 Aug '13

09 Aug '13

--On August 9, 2013 5:18:57 PM +0000 sog(a)msg.com.mx wrote: > Any comments or questions more than welcome. Will you be publishing the module on CPAN? --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

(ITS#7660) LMDB: Proposing a small addition to the API: mdb_txn_env
by sog＠msg.com.mx 09 Aug '13

09 Aug '13

Full_Name: Salvador Ortiz Version: 24 OS: Linux URL: ftp://ftp.msg.com.mx/pub/varios/Add-mdb_txn_env-to-API.patch Submission from: (NULL) (187.162.45.111) I'm writing from scratch a wrapper of LMDB for the Perl language, the project is progressing fast and looks very promising. Thank you for a wonderful library! I want to avoid as much as possible the need to duplicate LMDB's state in perl, in particular dbi's flags, so I need a method to obtain the MDB_env from a MDB_txn, but the required API is missing. In the same spirit of mdb_cursor_txn or mdb_cursor_dbi I propose adding mdb_txn_env. Provided a patch against gitorious mdb.master. Any comments or questions more than welcome. Regards. Salvador

1 0

Re: (ITS#7659) slapd refuses caseIgnoreMatch for Country String
by hyc＠symas.com 09 Aug '13

09 Aug '13

cyrille.maucci(a)hp.com wrote: > Full_Name: Cyrille MAUCCI > Version: 2.4.32 > OS: RHEL5 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (15.203.169.125) > > > Hello openldap'ers, > > > as a follow-up of our discussion on > http://www.openldap.org/lists/openldap-technical/201307/msg00042.html, I'm > creating an ITS to track the fact that slapd seems to refuse caseIgnoreMatch > matching rule for Country String. Fixed now in master. > > Initial description of the bug can be found hereafter, to which Howard are > ack'ed > > "Looks like a bug, schema_init.c doesn't list Country String as a compatible > syntax here. You should submit an ITS for this." > > > Many thanks in advance > ++Cyrille > > > BUG DESCRIPTION: > > When I have this piece of schema included in my slapd.conf file… > > > > attributetype ( 1.3.6.1.4.1.11.11.1.1.1.1.402 > > NAME ( 'TestCountryString' 'TestCountryStringSyn' ) > > DESC 'Test Country String' > > EQUALITY caseIgnoreMatch > > ORDERING caseIgnoreOrderingMatch > > SUBSTR caseIgnoreSubstringsMatch > > SYNTAX 1.3.6.1.4.1.1466.115.121.1.11 > > SINGLE-VALUE ) > > > > … my 2.4.32 slapd –Tt complains with this error: > > > > line 8 attributetype: AttributeType inappropriate matching rule: > "caseIgnoreMatch". > > > > > > My understanding of http://tools.ietf.org/html/rfc4517 is that caseIgnoreMatch > is valid for country string: > > > > "The caseIgnoreMatch rule compares an assertion value of the Directory > > String syntax to an attribute value of a syntax (e.g., the Directory > > String, Printable String, Country String, or Telephone Number syntax) > > whose corresponding ASN.1 type is DirectoryString or one of its > > alternative string types. > > " > > > > > > Could you confirm whether this is a bug in openldap or simply a misunderstanding > from me ? > > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs