https://bugs.openldap.org/show_bug.cgi?id=8958
--- Comment #39 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
2.5 compat with 2.4 dbs:
Commits:
• d877251b
by Howard Chu at 2021-08-06T22:50:23+01:00
(From ITS#8958) allow 2.5 slapcat to read 2.4 DB
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=5344
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|IN_PROGRESS |RESOLVED
Resolution|--- |TEST
--- Comment #14 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Commits:
• 1cf39a85
by Ondřej Kuzník at 2021-08-06T15:30:47+01:00
ITS#5344 Record and maintain new DN on ModRDN ops
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9122
--- Comment #3 from Howard Chu <hyc(a)openldap.org> ---
(In reply to Ondřej Kuzník from comment #2)
> I thought we might let the backend know if it's in dryrun mode, but a large
> part of slapadd is gated on !dryrun and that would need sweeping changes.
>
> One of those options would be to change bi_tool_entry_open() signature and
> pass dryrun in, letting the backend decide whether this should be preserved.
Probably easier to just add a new DRYRUN flag to slapMode.
> bconfig could then set cfb->cb_use_ldif = 0 and thus any changes would be
> transient while still loading all modules etc.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8958
--- Comment #38 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
(In reply to Hallvard Furuseth from comment #36)
> On 06.08.2021 13:38, openldap-its(a)openldap.org wrote:
> > --- Comment #34 from Howard Chu <hyc(a)openldap.org> ---
> > Indexer fix in https://git.openldap.org/openldap/openldap/-/merge_requests/372
>
> I don't think you should change an existing function (pausecheck) to do
> something completely different. That silently breaks existing code.
> Renaming it makes sense since the name is confusiong, but use another
> name for the new functionality. pause_status(), maybe.
Generally I'd expect this type of commentary to be in the MR for historical
purposes.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8958
--- Comment #37 from Howard Chu <hyc(a)openldap.org> ---
(In reply to Hallvard Furuseth from comment #36)
> On 06.08.2021 13:38, openldap-its(a)openldap.org wrote:
> > --- Comment #34 from Howard Chu <hyc(a)openldap.org> ---
> > Indexer fix in https://git.openldap.org/openldap/openldap/-/merge_requests/372
>
> I don't think you should change an existing function (pausecheck) to do
> something completely different. That silently breaks existing code.
> Renaming it makes sense since the name is confusiong, but use another
> name for the new functionality. pause_status(), maybe.
Fair enough. Changed to pausequery().
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8958
--- Comment #36 from Hallvard Furuseth <h.b.furuseth(a)usit.uio.no> ---
On 06.08.2021 13:38, openldap-its(a)openldap.org wrote:
> --- Comment #34 from Howard Chu <hyc(a)openldap.org> ---
> Indexer fix in https://git.openldap.org/openldap/openldap/-/merge_requests/372
I don't think you should change an existing function (pausecheck) to do
something completely different. That silently breaks existing code.
Renaming it makes sense since the name is confusiong, but use another
name for the new functionality. pause_status(), maybe.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=5344
--- Comment #13 from Howard Chu <hyc(a)openldap.org> ---
(In reply to Ondřej Kuzník from comment #12)
> Do we document API changes for people maintaining external modules?
slap.h is the documentation.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=5344
--- Comment #12 from Ondřej Kuzník <ondra(a)mistotebe.net> ---
Do we document API changes for people maintaining external modules?
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=5344
Ondřej Kuzník <ondra(a)mistotebe.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |IN_PROGRESS
Ever confirmed|0 |1
--- Comment #11 from Ondřej Kuzník <ondra(a)mistotebe.net> ---
https://git.openldap.org/openldap/openldap/-/merge_requests/373
--
You are receiving this mail because:
You are on the CC list for the issue.