https://bugs.openldap.org/show_bug.cgi?id=9231
Bug ID: 9231
Summary: LDAP_USE_NON_BLOCKING_TLS not defined in tls_o.c
Product: OpenLDAP
Version: 2.5
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: libraries
Assignee: bugs(a)openldap.org
Reporter: ryan(a)openldap.org
Target Milestone: ---
81588880852e83e094fea5c0b3dc7c75cf39112c (ITS#8980) added code in tls_o.c
that's conditional on LDAP_USE_NON_BLOCKING_TLS. However, it's only defined in
tls2.c, not in any common header.
I suspect that patch might have been developed with -DLDAP_USE_NON_BLOCKING_TLS
added on the command line.
I further suspect that this addition might not even be needed at all, after
fixing ITS#8650.
To do:
- test async connect behaviour before/after ITS#8980 (confirm the bug and fix)
- determine whether the added code is still needed, either delete it or move
the #define to a header so it's actually effective
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8614
--- Comment #6 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
(In reply to Ryan Tandy from comment #5)
> We should keep the ability to specify the threads library by
> --with-threads=<impl>, and only remove the --without-threads option.
>
> We're still going to ship some libldap.so -> libldap_r.so symlinks in order
> to avoid breaking everyone's Makefiles, correct?
Yep to both.
We'll delete back-shell/back-perl from the 2.5 release tree specifically, no
point in shipping them, but leave them in master for reference.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8614
--- Comment #5 from Ryan Tandy <ryan(a)openldap.org> ---
We should keep the ability to specify the threads library by
--with-threads=<impl>, and only remove the --without-threads option.
We're still going to ship some libldap.so -> libldap_r.so symlinks in order to
avoid breaking everyone's Makefiles, correct?
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8614
--- Comment #4 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
(In reply to Ryan Tandy from comment #3)
> Since quite a while slapd doesn't compile at all without threads
Discussed with Howard.
For 2.5: No more libldap, remove the --with-threads=XX switch to configure,
remove back-perl, remove back-shell
For libldap: Just stop building it (keep it in source tree). Same with
back-perl, back-shell.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8614
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also|https://bugs.openldap.org/s |https://bugs.openldap.org/s
|how_bug.cgi?id=5333 |how_bug.cgi?id=5533
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=5533
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.openldap.org/s
| |how_bug.cgi?id=8614
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=5333
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also|https://bugs.openldap.org/s |
|how_bug.cgi?id=8614 |
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8614
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.openldap.org/s
| |how_bug.cgi?id=5333
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
--- Comment #3 from Ryan Tandy <ryan(a)openldap.org> ---
Since quite a while slapd doesn't compile at all without threads; nor do
liblmdb, syncprov, etc. At this point we should probably just reject
configuring slapd without threading, and maybe talk about dropping the
non-thread-safe backends (shell and perl IIRC). BDB is gone for 2.5 and LMDB
doesn't support a non-threaded build AFAIK.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=5333
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.openldap.org/s
| |how_bug.cgi?id=8614
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=7821
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.