openldap-bugs August 2018

openldap-bugs@openldap.org

27 participants
50 discussions

(ITS#8896) scale() uninitialized j
by ethanms＠gmail.com 09 Aug '18

09 Aug '18

Full_Name: Ethan Schorer Version: since 2.4 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (194.29.45.108) In libraries/liblutil/utils.c in the function scale() the code defines "int i, j;". Then, i gets set in a for loop, but j only gets set if prev->len > 1. And then, j is used even if it wasn't initialized. Isn't this a bug? Shouldn't j be set to 0 when defined? Or don't use it?

1 0

Re: (ITS#8895) LMDB bug on Windows 64 when built by MSVC
by hyc＠symas.com 08 Aug '18

08 Aug '18

hrissan(a)mail.ru wrote: > Full_Name: Hrissan > Version: lmdb commit 26c7df88e44e31623d0802a564f24781acdefde3 > OS: Windows 7 64-bit > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (108.61.166.173) > > > Dear Howard, lots of thanks for quick fix of ITS#8891, now another issue... > > I know your position that Microsoft Visual Studio is crap (it may be, but not > everyone has a choice), but here is the problem: > > When building LMDB targeting Win64 using 64-bit compiler in Microsoft Visual > Studio, the database will still be limited to just 2 gigabytes, with mdb_put > returning error as soon as database attempts to grow beyond that. > > The problem is "off_t" is incorrectly defined as "long" in MSVC posix > compatibility layer, and long is 32-bit on windows 64-bit build. As a result > mdb_page_flush (and other functions using off_t) become broken. > > I understand this is Microsoft's, not LMDB issue, but still LMDB source contains > lots of workarounds, so probably adding one will save the day for many ppl. > Microsoft has this issue since at least 2008 (And it is still there in latest > Visual Studio Community 2017 version 15.7.6), so no hope for fix from them. > I propose the following fix (as narrow as possible - for example no fix for > MinGW on Windows or MSVC on Linux) There's no logic in this proposal. The bug is clearly in the MS header files; the correct fix is to edit the MS header files and use the proper definition. Fix the actual bugs. Report the actual bugs to the people that are actually responsible for them. > > #if defined(_WIN32) && defined(_MSC_VER) > typedef long long int lmdb_off_t; // 64-bit on both 32- and 64- bit Windows > #else > typedef off_t lmdb_off_t; > #endif > > And using lmdb_off_t instead of off_t on 4 occasions where it is used. > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8895) LMDB bug on Windows 64 when built by MSVC
by hrissan＠mail.ru 08 Aug '18

08 Aug '18

Full_Name: Hrissan Version: lmdb commit 26c7df88e44e31623d0802a564f24781acdefde3 OS: Windows 7 64-bit URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (108.61.166.173) Dear Howard, lots of thanks for quick fix of ITS#8891, now another issue... I know your position that Microsoft Visual Studio is crap (it may be, but not everyone has a choice), but here is the problem: When building LMDB targeting Win64 using 64-bit compiler in Microsoft Visual Studio, the database will still be limited to just 2 gigabytes, with mdb_put returning error as soon as database attempts to grow beyond that. The problem is "off_t" is incorrectly defined as "long" in MSVC posix compatibility layer, and long is 32-bit on windows 64-bit build. As a result mdb_page_flush (and other functions using off_t) become broken. I understand this is Microsoft's, not LMDB issue, but still LMDB source contains lots of workarounds, so probably adding one will save the day for many ppl. Microsoft has this issue since at least 2008 (And it is still there in latest Visual Studio Community 2017 version 15.7.6), so no hope for fix from them. I propose the following fix (as narrow as possible - for example no fix for MinGW on Windows or MSVC on Linux) #if defined(_WIN32) && defined(_MSC_VER) typedef long long int lmdb_off_t; // 64-bit on both 32- and 64- bit Windows #else typedef off_t lmdb_off_t; #endif And using lmdb_off_t instead of off_t on 4 occasions where it is used.

1 0

(ITS#8894) git clone fails
by openldap＠openldap.org 07 Aug '18

07 Aug '18

Full_Name: Version: OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (2a02:587:390c:800:299:99ff:fe99:9999) Cloning into 'openldap'... fatal: dumb http transport does not support shallow capabilities

1 0

(ITS#8893) New LDAP option to support binding to specific IPv4/IPv6 address at client side
by sudhir.singam＠gmail.com 06 Aug '18

06 Aug '18

Full_Name: sudhir reddy singam Version: master branch OS: fedora URL: Submission from: (NULL) (131.228.66.13) The attached file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by NOKIA. NOKIA has not assigned rights and/or interest in this work to any party. I, SINGAM SUDHIR REDDY authorized by NOKIA, my employer, to release this work under the following terms. NOKIA hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. **** Description: This is continuation to ITS#8847. NOKIA has decided to contribute on this small feature, that is, providing new LDAP option to be able to set the source bind IP address at openldap client side. Following are the design details of what we are planning to do. Please provide your comments for the design, so that we can proceed with the implementation. Details: Requirement: User shall be able to set multiple IPv4/IPv6 socket bind addresses, to be able to route the LDAP traffic via desired network interface. Based on the target IP address type, first matching and valid source IP address will be picked for explicit binding at client side. Work items: 1) LDAP option to set the IPv4/IPv6 socket bind addresses. Format: space separated list of IP addresses New configuration option LDAP_OPT_SOCKET_BIND_ADDRESSES (0x5013) will be introduced (in ldap.h) to be used via ldap_set_option. For example, char* p = 10.24.56.34 2001:0db8:85a3:0000:0000:8a2e:0370:7334; ldap_set_option(NULL, LDAP_OPT_SOCKET_BIND_ADDRESSES, p); Bind addresses can also be provided in ldap.conf file via the option SOCKET_BIND_ADDRESSES, for example, SOCKET_BIND_ADDRESSES 10.24.56.45 10.24.56.46 2001:0db8:85a3:0000:0000:8a2e:0370:7334 Note : Option set to ldap handle will override the global option. Setting the option multiple times will override the previous values but does not append. 2) Parsing & validations Space separated IP addresses will be parsed & validated. IPv4 and IPv6 addresses are stored separately for easy of access during connection. Basic syntax validation will be done for IPv4 or IPv6 addresses, if any error, setting of the option will fail and LDAP client will use the default IP address. ldapoptions structure in ldap-int.h will be modified to add new members "char *ldo_local_IPV4_addresses" -> to hold client local IPv4 bind addresses "char *ldo_local_IPV6_addresses" -> to hold client local IPv6 bind addresses Any new function ldap_options_parseBindAddress () will be introduced in options.c to parse, validate and store the IP addresses to respective variables. This function will be similar to ldap_url_parseHosts. Memory for ldo_local_IPV4_addresses & ldo_local_IPV6_addresses is dynamically allocated in the form of array for easy access. If any validation failure, no new memory will be allocated and existing values will be retained. 3) Using Bind IP addresses during connection File:os-ip.c Function: ldap_connect_to_host - After the connection socket is created (ldap_int_socket) and before it is connected (ldap_pvt_connect). Check if the target address family type, If it is AF_INET, IPv4 bind address list will be used. - If the list is empty and LDAP option was set successfully earlier (IPv6 was set), binding will fail and error is returned. - If the list is not empty and not able to bind to any of the provided IPv4 addresses, connection will fail. - If the list is empty and LDAP option setting failed earlier (during syntax validation), LDAP client will continue to use the kernel provided IPv4 address. If it is AF_INET6, IPv6 bind address list will be used. - If the list is empty and LDAP option was set successfully earlier (IPv4 was set), binding will fail and error is returned. - If the list is not empty and not able to bind to any of the provided IPv6 addresses, connection will fail. - If the list is empty and LDAP option setting failed earlier (during syntax validation), LDAP client will continue to use the kernel provided IPv6 address.

1 0

Re: (ITS#8892) ISC dhcpd cannot start TLS session to 389-DS after updating openldap rpm
by quanah＠symas.com 06 Aug '18

06 Aug '18

--On Monday, August 06, 2018 3:42 PM +0000 krejci(a)i3.cz wrote: > Full_Name: Mira Krejci > Version: 2.4.44-15 > OS: CentOS Linux release 7.5.1804 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (93.99.54.254) Hello, This is likely due to RedHat's customizations to the OpenLDAP libldap library. In their most recent builds, they switched from MozNSS to OpenSSL as the underlying TLS library and wrote their own custom bridging function for this change. It has apparently caused various problems for end users. I would suggest contacting RedHat or using an unmodified version of OpenLDAP. --Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>

1 0

Re: (ITS#8892) ISC dhcpd cannot start TLS session to 389-DS after updating openldap rpm
by michael＠stroeder.com 06 Aug '18

06 Aug '18

On 8/6/18 4:42 PM, krejci(a)i3.cz wrote: > ISC dhcp server cannot start TLS session to 389 Directory server after updating > openldap from 2.4.44-5 to newist version. > Error: Cannot start TLS session to 10.0.252.31:389: Connect error > > dhcpd version: 4.2.5-68 > 389-ds-base verson: 1.3.7.5-21 > > When I try manually copy old libraries (liblber, libldap, libslapi) back to > updated system, dhcpd works fine with TLS to 389-DS. > > We can disable TLS by "ldap-ssl off" option at /etc/dhcp/dhcpd.conf as a > workaround. The ITS is only for reporting bugs. Please post your questions on the openldap-technical mailing list: https://www.openldap.org/lists/mm/listinfo/openldap-technical Ciao, Michael.

1 0

(ITS#8892) ISC dhcpd cannot start TLS session to 389-DS after updating openldap rpm
by krejci＠i3.cz 06 Aug '18

06 Aug '18

Full_Name: Mira Krejci Version: 2.4.44-15 OS: CentOS Linux release 7.5.1804 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (93.99.54.254) ISC dhcp server cannot start TLS session to 389 Directory server after updating openldap from 2.4.44-5 to newist version. Error: Cannot start TLS session to 10.0.252.31:389: Connect error dhcpd version: 4.2.5-68 389-ds-base verson: 1.3.7.5-21 When I try manually copy old libraries (liblber, libldap, libslapi) back to updated system, dhcpd works fine with TLS to 389-DS. We can disable TLS by "ldap-ssl off" option at /etc/dhcp/dhcpd.conf as a workaround.

1 0

Re: (ITS#8891) LMDB fails to compile on latest Microsoft Visual Studio
by hyc＠symas.com 06 Aug '18

06 Aug '18

hrissan(a)mail.ru wrote: > Full_Name: Hrissan > Version: commit 86a90cad721cbdc0bb0a9c3bf15396f5c946ae95 > OS: Windows 7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (5.44.169.206) > > > Sorry this seems to be the only way to report bug in LMDB. No need to apologize for using the documented mechanism. Thanks for the report, fixed now in mdb.master. > > In mdb.c line 55, 68, 77 > > typedef NTSTATUS WINAPI (NtCreateSectionFunc) > > Should be > > typedef NTSTATUS (WINAPI NtCreateSectionFunc) > > Visual Studio Community 2017 version 15.7.6 does not accept the incorrect > typedef any more. > > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8891) LMDB fails to compile on latest Microsoft Visual Studio
by hrissan＠mail.ru 05 Aug '18

05 Aug '18

Full_Name: Hrissan Version: commit 86a90cad721cbdc0bb0a9c3bf15396f5c946ae95 OS: Windows 7 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (5.44.169.206) Sorry this seems to be the only way to report bug in LMDB. In mdb.c line 55, 68, 77 typedef NTSTATUS WINAPI (NtCreateSectionFunc) Should be typedef NTSTATUS (WINAPI NtCreateSectionFunc) Visual Studio Community 2017 version 15.7.6 does not accept the incorrect typedef any more.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs August 2018