openldap-bugs April 2017

openldap-bugs@openldap.org

25 participants
116 discussions

Re: (ITS#8634) OpenLDAP fails to build against OpenSSL 1.1
by hyc＠symas.com 10 Apr '17

10 Apr '17

hristo(a)venev.name wrote: > Full_Name: Hristo Venev > Version: Unreleased Release Candidate 2.4.45 > OS: > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (95.111.59.55) > > > Another user of the old DES API. Here's a patch (compiles, not tested): Thanks. Looks like you're compiling the old NT/LANMAN password hash support. Nobody should still be using that code, LANMAN hashes are trivially crackable on modern GPUs. > > diff --git a/libraries/liblutil/passwd.c b/libraries/liblutil/passwd.c > index 7aab344..c481326 100644 > --- a/libraries/liblutil/passwd.c > +++ b/libraries/liblutil/passwd.c > @@ -38,9 +38,9 @@ > # include <openssl/des.h> > > > -typedef des_cblock des_key; > -typedef des_cblock des_data_block; > -typedef des_key_schedule des_context; > +typedef DES_cblock des_key; > +typedef DES_cblock des_data_block; > +typedef DES_key_schedule des_context[1]; > #define des_failed(encrypted) 0 > #define des_finish(key, schedule) > > @@ -667,7 +667,7 @@ static void > des_set_key_and_parity( des_key *key, unsigned char *keyData) > { > memcpy(key, keyData, 8); > - des_set_odd_parity( key ); > + DES_set_odd_parity( key ); > } > > > @@ -699,7 +699,7 @@ des_set_key_and_parity( des_key *key, unsigned char > *keyData) > } > > static void > -des_set_key_unchecked( des_key *key, des_context ctxt ) > +DES_set_key_unchecked( des_key *key, des_context ctxt ) > { > ctxt[0] = NULL; > > @@ -712,7 +712,7 @@ des_set_key_unchecked( des_key *key, des_context ctxt ) > } > > static void > -des_ecb_encrypt( des_data_block *plain, des_data_block *encrypted, > +DES_ecb_encrypt( des_data_block *plain, des_data_block *encrypted, > des_context ctxt, int op) > { > SECStatus rv; > @@ -864,16 +864,16 @@ static int chk_lanman( > ldap_pvt_str2upper( UcasePassword ); > > lmPasswd_to_key( UcasePassword, &key ); > - des_set_key_unchecked( &key, schedule ); > - des_ecb_encrypt( &StdText, &PasswordHash1, schedule , DES_ENCRYPT ); > + DES_set_key_unchecked( &key, schedule ); > + DES_ecb_encrypt( &StdText, &PasswordHash1, schedule , DES_ENCRYPT ); > > if (des_failed(&PasswordHash1)) { > return LUTIL_PASSWD_ERR; > } > > lmPasswd_to_key( &UcasePassword[7], &key ); > - des_set_key_unchecked( &key, schedule ); > - des_ecb_encrypt( &StdText, &PasswordHash2, schedule , DES_ENCRYPT ); > + DES_set_key_unchecked( &key, schedule ); > + DES_ecb_encrypt( &StdText, &PasswordHash2, schedule , DES_ENCRYPT ); > if (des_failed(&PasswordHash2)) { > return LUTIL_PASSWD_ERR; > } > @@ -1160,12 +1160,12 @@ static int hash_lanman( > ldap_pvt_str2upper( UcasePassword ); > > lmPasswd_to_key( UcasePassword, &key ); > - des_set_key_unchecked( &key, schedule ); > - des_ecb_encrypt( &StdText, &PasswordHash1, schedule , DES_ENCRYPT ); > + DES_set_key_unchecked( &key, schedule ); > + DES_ecb_encrypt( &StdText, &PasswordHash1, schedule , DES_ENCRYPT ); > > lmPasswd_to_key( &UcasePassword[7], &key ); > - des_set_key_unchecked( &key, schedule ); > - des_ecb_encrypt( &StdText, &PasswordHash2, schedule , DES_ENCRYPT ); > + DES_set_key_unchecked( &key, schedule ); > + DES_ecb_encrypt( &StdText, &PasswordHash2, schedule , DES_ENCRYPT ); > > sprintf( PasswordHash, > "%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x", > PasswordHash1[0],PasswordHash1[1],PasswordHash1[2],PasswordHash1[3], > > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8634) OpenLDAP fails to build against OpenSSL 1.1
by hristo＠venev.name 10 Apr '17

10 Apr '17

Full_Name: Hristo Venev Version: Unreleased Release Candidate 2.4.45 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (95.111.59.55) Another user of the old DES API. Here's a patch (compiles, not tested): diff --git a/libraries/liblutil/passwd.c b/libraries/liblutil/passwd.c index 7aab344..c481326 100644 --- a/libraries/liblutil/passwd.c +++ b/libraries/liblutil/passwd.c @@ -38,9 +38,9 @@ # include <openssl/des.h> -typedef des_cblock des_key; -typedef des_cblock des_data_block; -typedef des_key_schedule des_context; +typedef DES_cblock des_key; +typedef DES_cblock des_data_block; +typedef DES_key_schedule des_context[1]; #define des_failed(encrypted) 0 #define des_finish(key, schedule) @@ -667,7 +667,7 @@ static void des_set_key_and_parity( des_key *key, unsigned char *keyData) { memcpy(key, keyData, 8); - des_set_odd_parity( key ); + DES_set_odd_parity( key ); } @@ -699,7 +699,7 @@ des_set_key_and_parity( des_key *key, unsigned char *keyData) } static void -des_set_key_unchecked( des_key *key, des_context ctxt ) +DES_set_key_unchecked( des_key *key, des_context ctxt ) { ctxt[0] = NULL; @@ -712,7 +712,7 @@ des_set_key_unchecked( des_key *key, des_context ctxt ) } static void -des_ecb_encrypt( des_data_block *plain, des_data_block *encrypted, +DES_ecb_encrypt( des_data_block *plain, des_data_block *encrypted, des_context ctxt, int op) { SECStatus rv; @@ -864,16 +864,16 @@ static int chk_lanman( ldap_pvt_str2upper( UcasePassword ); lmPasswd_to_key( UcasePassword, &key ); - des_set_key_unchecked( &key, schedule ); - des_ecb_encrypt( &StdText, &PasswordHash1, schedule , DES_ENCRYPT ); + DES_set_key_unchecked( &key, schedule ); + DES_ecb_encrypt( &StdText, &PasswordHash1, schedule , DES_ENCRYPT ); if (des_failed(&PasswordHash1)) { return LUTIL_PASSWD_ERR; } lmPasswd_to_key( &UcasePassword[7], &key ); - des_set_key_unchecked( &key, schedule ); - des_ecb_encrypt( &StdText, &PasswordHash2, schedule , DES_ENCRYPT ); + DES_set_key_unchecked( &key, schedule ); + DES_ecb_encrypt( &StdText, &PasswordHash2, schedule , DES_ENCRYPT ); if (des_failed(&PasswordHash2)) { return LUTIL_PASSWD_ERR; } @@ -1160,12 +1160,12 @@ static int hash_lanman( ldap_pvt_str2upper( UcasePassword ); lmPasswd_to_key( UcasePassword, &key ); - des_set_key_unchecked( &key, schedule ); - des_ecb_encrypt( &StdText, &PasswordHash1, schedule , DES_ENCRYPT ); + DES_set_key_unchecked( &key, schedule ); + DES_ecb_encrypt( &StdText, &PasswordHash1, schedule , DES_ENCRYPT ); lmPasswd_to_key( &UcasePassword[7], &key ); - des_set_key_unchecked( &key, schedule ); - des_ecb_encrypt( &StdText, &PasswordHash2, schedule , DES_ENCRYPT ); + DES_set_key_unchecked( &key, schedule ); + DES_ecb_encrypt( &StdText, &PasswordHash2, schedule , DES_ENCRYPT ); sprintf( PasswordHash, "%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x", PasswordHash1[0],PasswordHash1[1],PasswordHash1[2],PasswordHash1[3],

1 0

Re: (ITS#8633) No released version of OpenLDAP supports OpenSSL 1.1.0
by hyc＠symas.com 10 Apr '17

10 Apr '17

hristo(a)venev.name wrote: > Full_Name: Hristo Venev > Version: 2.4.44 > OS: > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (95.111.59.55) > > > No version of OpenLDAP that builds and works against OpenSSL 1.1.0 has been > released yet. Support for OpenSSL 1.1.0 is in the 2.4.45 release candidate. Closing this ITS. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8633) No released version of OpenLDAP supports OpenSSL 1.1.0
by hristo＠venev.name 10 Apr '17

10 Apr '17

Full_Name: Hristo Venev Version: 2.4.44 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (95.111.59.55) No version of OpenLDAP that builds and works against OpenSSL 1.1.0 has been released yet.

1 0

Re: (ITS#8553) LMDB Windows UWP Patch
by Howard Chu 10 Apr '17

10 Apr '17

I see no patch filename or URL in this ticket.

1 0

Re: (ITS#8509) LMDB make targets for automake
by hyc＠symas.com 10 Apr '17

10 Apr '17

phantom+lmdb(a)live.ie wrote: > Full_Name: Aido > Version: 2.4.44 > OS: Ubuntu Trusty > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (216.239.90.19) > > > The current liblmdb Makefile does not make it easy to use liblmdb as a > submodule > to other projects that utilize automake e.g. automake uses a 'check' directive > instead of 'test'. > > Adding the following to the Makefile would make liblmdb more automake > friendly: > > EMPTY_AUTOMAKE_TARGETS = dvi pdf ps info html tags ctags distcheck > .PHONY: $(EMPTY_AUTOMAKE_TARGETS) > $(EMPTY_AUTOMAKE_TARGETS): > check: test > > See: > https://www.gnu.org/software/automake/manual/html_node/Third_002dParty-Make… > > The OpenLDAP Project doesn't use automake, and as a policy we don't include support for tools we don't use. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8632) VC parsing error
by hyc＠symas.com 10 Apr '17

10 Apr '17

okuznik(a)symas.com wrote: > Full_Name: Ondrej Kuznik > Version: master > OS: > URL: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170410-ITS-8632-request-the… > Submission from: (NULL) (2a02:c7f:2247:ec00:a3e:8eff:fe52:dac5) > > > When extracting a SASL mechanism, VC overlay requests a string from ber_scanf, > where it should be an in-place BerValue *. > > Patch attached. > > Thanks, applied to git master -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8631) OpenLDAP segfault on startup
by hyc＠symas.com 10 Apr '17

10 Apr '17

okuznik(a)symas.com wrote: > Full_Name: Ondrej Kuznik > Version: master/re24 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170410-ITS-8631-Initialize-… > Submission from: (NULL) (2a02:c7f:2247:ec00:a3e:8eff:fe52:dac5) > > > When playing around with ldapi, a typo uncovered a bug in the startup routines: > if the hostname cannot be resolved, an unitialised pointer would be referenced. > > Try running: > slapd -h ldap://does.not.exist -d -1 -f /dev/null > > Attached patch fixes this. > > Thanks, applied to git master -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8632) VC parsing error
by okuznik＠symas.com 10 Apr '17

10 Apr '17

Full_Name: Ondrej Kuznik Version: master OS: URL: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170410-ITS-8632-request-the… Submission from: (NULL) (2a02:c7f:2247:ec00:a3e:8eff:fe52:dac5) When extracting a SASL mechanism, VC overlay requests a string from ber_scanf, where it should be an in-place BerValue *. Patch attached.

1 0

(ITS#8631) OpenLDAP segfault on startup
by okuznik＠symas.com 10 Apr '17

10 Apr '17

Full_Name: Ondrej Kuznik Version: master/re24 OS: Linux URL: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170410-ITS-8631-Initialize-… Submission from: (NULL) (2a02:c7f:2247:ec00:a3e:8eff:fe52:dac5) When playing around with ldapi, a typo uncovered a bug in the startup routines: if the hostname cannot be resolved, an unitialised pointer would be referenced. Try running: slapd -h ldap://does.not.exist -d -1 -f /dev/null Attached patch fixes this.

1 0

← Newer
1
...
4
5
6
7
8
9
10
11
12
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs April 2017