September 2015 - openldap-bugs

(ITS#8238) mdb_cursor_put() returns inconsistent xcursor

by h.b.furuseth＠usit.uio.no

Full_Name: Hallvard B Furuseth Version: LMDB 0.9.16 OS: Linux x86_64 URL: ftp://ftp.openldap.org/incoming/Hallvard-Furuseth-150906.diff Submission from: (NULL) (81.191.45.5) Submitted by: hallvard Replace printf("oops!\n") with mdb_cassert(mc, 0) in cursor_chk(). Add if (!rc && mc->mc_xcursor) mdb_cursor_chk(&mc->mc_xcursor->mx_cursor); just before mdb_cursor_put() returns rc above "bad_sub:". Diff for this enclosed. $ make -s clean test CPPFLAGS="-DMDB_DEBUG" $ ./mtest4 mdb.c:1500: Assertion '0' failed in mdb_cursor_chk()

8 years

1
0
0 / 0

Re: (ITS#8237) Crash with MDB_MAXKEYSIZE=1500

by h.b.furuseth＠usit.uio.no

I wrote: > Assertion 'NUMKEYS(mp) > 1' failed in mdb_page_search_root(): The paste got munged. Test program at <ftp://ftp.openldap.org/incoming/Hallvard-Furuseth-150906.c>.

8 years

1
0
0 / 0

(ITS#8237) Crash with MDB_MAXKEYSIZE=1500

by h.b.furuseth＠usit.uio.no

Full_Name: Hallvard B Furuseth Version: LMDB 0.9.10-0.9.15 OS: Linux x86_64 URL: Submission from: (NULL) (81.191.45.5) Submitted by: hallvard Assertion 'NUMKEYS(mp) > 1' failed in mdb_page_search_root(): #define MDB_MAXKEYSIZE 1500 #include "mdb.c" #include "midl.c" int main(void) { MDB_dbi dbi; MDB_env *env; MDB_txn *txn; int i, rc =DMDB_SUCCESS; mdb_env_create(&env); mdb_env_open(env, "./testdb", MDB_WRITEMAP, 0664); mdb_txn_begin(env, NULL, 0, &txn); mdb_dbi_open(txn, NULL, 0, &dbi); for (i = 0; i < 6 && !rc; i++) { static char buf[1600] = "340215"; DB_v_val key = {1500, buf+i}, data = {500, buf}; mdb_put(txn, dbi, &key, &data, 0); } mdb_txn_abort(txn); mdb_env_close(env); return rc; } Broken by 34459e05856619e8 "ITS#7589 another mdb_page_split fix".

8 years

1
0
0 / 0

Re: (ITS#8230) [new PATCHes] totp: bug fixes and improvements

by peter＠adpm.de

Hi, Please have a look at the improved patch series in https://github.com/marschap/openldap/commits/contrib-totp3 and https://github.com/marschap/openldap/commits/contrib-totp4 They try to address the issues in the previous versions Changes: * contrib/passwd/totp: fix the big-endian case, support 32-bit archs Use memcpy for the WORDS_BIGENDIAN case [much simpler] Use uint64_t for same results in 32- and 64-bit cases * contrib/passwd/totp: support compiling using nettle Fix the botched previous patch. The two branches differ only in that patch, giving the following alternatives: - contrib-totp3 continues to use the HMAC_... macros It still requires the #if...#else...#endif to harmonize the setup in do_hmac() - contrib-totp4 gets rid of the HMAC_... macros It uses the different implementations directly in do_hmac() Of course separated by #if...#else..#endif Functionally both patches are equivalent: in my tests they yield the same results for OpenSSL and GnuTLS. Best PEter -- Peter Marschall peter(a)adpm.de

8 years

1
0
0 / 0

Re: (ITS#7889) rwm overlay causes incorrect acl parsing

by ryan＠nardis.ca

michael(a)stroeder.com wrote: >But could you please check whether this setting helps: > >rwm-drop-unrequested-attrs no It does. This is another case of ITS#6057; the ACL filter can only be evaluated if the filter attribute is included in those passed through by rwm, otherwise it is just skipped. The larger issue (should ACL evaluation assume the whole entry is available?) seems to still be unaddressed. I don't understand yet why rwm filters the attributes on its own by default, but I'm sure there's a reason. alexoz66(a)gmail.com wrote: >modifying entry "olcOverlay={0}rwm,olcDatabase={1}mdb,cn=config" >ldap_modify: Object class violation (65) > additional info: attribute 'olcRwmDropUnrequested' not allowed > >Looking at the schema it seems that the attribute olcRwmDropUnrequested >is not part of the olcRwmConfig object class (or any other object class >for that matter). This is fixed in git master now.

8 years

1
0
0 / 0

Re: (ITS#8230) [new PATCH] totp: bug fixes and improvements

by peter＠adpm.de

Hi, Please have a look at the improved patch series in https://github.com/marschap/openldap/commits/contrib-totp2 It tries to address all the issues highlighted on the first version. https://github.com/marschap/openldap/commit/e4e1045f59368af8d15172ad22fcc... contrib/passwd/totp: flexibilize decoding In function totp_b32_pton() - allow lowercase characters in encoded string too - allow padding to be omitted (totally, not only parts) With this added flexibility we can make use of keys encoded by other Base32-encoding implementations. In function chk_totp() determine the space required to hold the decoded key by calling totp_b32_pton() with a NULL argument for the target. Changes to previous version: - toupper()'s argument guarded with a cast to (unsigned char) - added rationale to commit message https://github.com/marschap/openldap/commit/edfa2b0fb3238ca9f231fa75bd452... contrib/passwd/totp: fix the big-endian case, support 32-bit archs - reverse tval in the WORDS_BIGENDIAN case before converting it to a string - use uint64_t for tval to have it correctly sized on 32-bit archs too - avoid magic number when converting tval to a string Changes to previous version: - complete rewrite https://github.com/marschap/openldap/commit/24007f02cebb0b7f801288b02d0ac... contrib/passwd/totp: fix decoding when padding is used In totp_b32_pton(), correctly count the number of '=' padding chars at the end of the base-32 encoded string: don't count the first padding char char twice. Note: '*str++' evaluates *str first and increases str later! Changes to previous version: - commit message only https://github.com/marschap/openldap/commit/435619ccd8be1b62f86db67643bca... contrib/passwd/totp: support compiling using nettle Changes to previous version: - rewrite, concentrating the #ifdef's as much as possible Best Peter -- Peter Marschall peter(a)adpm.de

8 years

1
0
0 / 0

(ITS#8236) can't add keys to olc config for SSL

by michael.aldridge＠utdallas.edu

Full_Name: Michael Aldridge Version: @(#) $OpenLDAP: slapd (Ubuntu) (Aug 6 1515 23:14:45) $ buildd@lgw01-54:/build/openldap-VbUBZB/openldap-2.4.41+dfsg/debian/build/servers/slapd OS: Ubuntu 14.04.3 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (129.110.157.13) Attempting to add the olc configuration directives for SSL returns a ldap_modify: Other (e.g., implementation specific) error (80). The certs check out and everything make sense from an issuing standpoint, slapd just won't accept the cert configuration. I can provide additional logs or debug information upon request.

8 years

1
0
0 / 0

(ITS#8235) compiler warnings in smbk5pwd.c with nettle

by ryan＠openldap.org

Full_Name: Ryan Tandy Version: master OS: Debian URL: Submission from: (NULL) (24.68.37.4) Submitted by: ryan smbk5pwd.c: In function 'lmhash': smbk5pwd.c:206:21: warning: passing argument 2 of 'nettle_des_set_key' from incompatible pointer type [-Wincompatible-pointer-types] des_set_key( &ctx, &key ); ^AIAIn file included from smbk5pwd.c:69:0: /usr/include/nettle/des.h:76:1: note: expected 'const uint8_t * {aka const unsigned char *}' but argument is of type 'unsigned char (*)[8]' des_set_key(struct des_ctx *ctx, const uint8_t *key); ^ (and several more) The openssl and gcrypt versions both used "&key" as well. It's correct for openssl, which takes a DES_cblock *. It's ambiguous for gcrypt, which takes a void *. It's wrong for nettle, which expects an unsigned char *. This is not a functional problem, since in all cases the pointer points at the beginning of the array. Fixing the warning does not change the output. smbk5pwd.c: In function 'nthash': smbk5pwd.c:249:36: warning: pointer targets in passing argument 3 of 'nettle_md4_update' differ in signedness [-Wpointer-sign] md4_update( &ctx, passwd->bv_len, passwd->bv_val ); ^ In file included from smbk5pwd.c:70:0: /usr/include/nettle/md4.h:69:1: note: expected 'const uint8_t * {aka const unsigned char *}' but argument is of type 'char *' md4_update(struct md4_ctx *ctx, ^ openssl and gcrypt both use void * here, nettle needs a cast (which should be safe). The remaining warnings are not nettle-specific. smbk5pwd.c: In function 'smbk5pwd_cf_func': smbk5pwd.c:915:14: warning: variable 'db' set but not used [-Wunused-but-set-variable] BackendDB db = *c->be; ^ Added in 29fab9c, apparently never used. Looks like cruft to me. Most likely didn't generate a warning with gcc prior to 4.6, due to the assignment just below. smbk5pwd.c: In function 'smbk5pwd_modules_init': smbk5pwd.c:968:2: warning: variable 'dummy_ad' set but not used [-Wunused-but-set-variable] dummy_ad; ^ The unused-but-set-variable warning is new in gcc 4.6 and there is a different no-op trick to suppress it in a portable way.

8 years

1
0
0 / 0

(ITS#8234) ppolicy_get can return a partly-populated struct

by ryan＠openldap.org

Full_Name: Ryan Tandy Version: master OS: URL: Submission from: (NULL) (24.68.37.4) Submitted by: ryan In ppolicy_get, if parsing fails after some attributes have already been loaded, we can return a partly populated structure, while the warning says "using default policy". In this case we should revert the entire structure to defaults before returning, IMO.

8 years

1
0
0 / 0

Re: (ITS#7537) ppolicy hangs slapd on 64bit version debian

by ryan＠nardis.ca

On Tue, Aug 25, 2015 at 10:00:55PM +0000, ryan(a)nardis.ca wrote: >I reproduced this with current RE24. It seems to be caused by setting >pwdMaxAge to a very large value. ... or any other ppolicy attribute. >It seems like the crash does not happen if I bind as the rootdn, only >when using the admin DN. That was incorrect, bind DN doesn't matter. In ppolicy_get, the defaultpol label skips releasing the entry lock, so if it's called again, it deadlocks.

8 years

1
0
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs September 2015