openldap-bugs May 2015

openldap-bugs@openldap.org

26 participants
101 discussions

(ITS#8125) MMR throws away valid changes causing drift
by quanah＠openldap.org 05 May '15

05 May '15

Full_Name: Quanah Gibson-Mount Version: RE24 OS: Linux 2.6 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (75.111.52.177) On Friday May 1st, reloaded mmr00 from mmr01, so they had exactly the same dataset. Since Friday, significant drift has occurred between the two nodes. One example is the following MODRDN request that was made to mmr00. Note: Clocks are tightly in sync between both nodes. On MMR00, we see the modrdn occur: May 1 16:10:18 zm-mmr00 slapd[52931]: conn=13581 op=2 MODRDN dn="uid=xxxxxx,ou=people,dc=yyyy,dc=net" May 1 16:10:18 zm-mmr00 slapd[52931]: conn=1145 op=181451 SEARCH RESULT tag=101 err=0 nentries=1 text= May 1 16:10:18 zm-mmr00 slapd[52931]: slap_queue_csn: queueing 0x7f2b8c8931c0 20150501201018.574740Z#000000#002#000000 May 1 16:10:18 zm-mmr00 slapd[52931]: slap_queue_csn: queueing 0x14ebeb40 20150501201018.574740Z#000000#002#000000 May 1 16:10:18 zm-mmr00 slapd[52931]: slap_graduate_commit_csn: removing 0x1d53e480 20150501201018.574740Z#000000#002#000000 May 1 16:10:18 zm-mmr00 slapd[52931]: conn=13581 op=2 RESULT tag=109 err=0 text= May 1 16:10:18 zm-mmr00 slapd[52931]: slap_graduate_commit_csn: removing 0x10be8520 20150501201018.574740Z#000000#002#000000 Everything looks good on this host. Now on to MMR01... nearly 1.5 HOURS LATER WE SEE: May 1 17:27:36 zm-mmr01 slapd[43243]: syncrepl_message_to_op: rid=100 be_modify uid=someotherentry,ou=people,dc=differentdomain,dc=com (0) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201017.390034Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201017.390034Z#000000#00b#000000 (reqStart=20150501201017.000302Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201017.528111Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapdC43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201017.528111Z#000000#00b#000000 (reqStart=20150501201017.000362Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201017.619314Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201017.619314Z#000000#00b#000000 (reqStart=20150501201017.000406Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201018.502559Z#000000#002#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201018.502559Z#000000#002#000000 (reqStart=20150501201018.000269Z,cn=cecesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201018.519620Z#000000#002#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201018.519620Z#000000#002#000000 (reqStart=20150501201018.000289Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201018.574740Z#000000#002#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old,gignoring 20150501201018.574740Z#000000#002#000000 (reqStart=20150501201018.000336Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201018.611377Z#000000#002#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201018.611377Z#000000#002#000000 (reqStart=20150501201018.000358Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201018.577381Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201018.577381Z#000000#00b#000000 (reqStart=20150501201018.000366Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201018.628228Z#000000#002#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201018.628228Z#000000#002#000000 (reqStart=20150501201018.000378Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201018.648496Z#000000#002#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201018.648496Z#000000#002#000000 (reqStart=20150501201018.000398Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201018.747799Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201018.747799Z#000000#00b#000000 (reqStart=20150501201018.000517Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201018.926821Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201018.926821Z#000000#00b#000000 (reqStart=20150501201018.000639Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201019.051637Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201019.051637Z#000000#00b#000000 (reqStart=20150501201019.000052Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201019.107217Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201019.107217Z#000000#00b#000000 (reqStart=20150501201019.000092Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201019.165448Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201019.165448Z#000000#00b#000000 (reqStart=20150501201019.000146Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002,csn=20150501201019.221163Z#000000#00b#000000 May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 CSN too old, ignoring 20150501201019.221163Z#000000#00b#000000 (reqStart=20150501201019.000190Z,cn=accesslog) May 1 17:27:36 zm-mmr01 slapd[43243]: do_syncrep2: rid=100 cookie=rid=100,sid=002 May 1 17:27:37 zm-mmr01 slapd[43243]: do_syncrep2: rid=102 cookie=rid=102,sid=00b,csn=20150501212737.068523Z#000000#00b#000000 May 1 17:27:37 zm-mmr01 slapd[43243]: syncrepl_message_to_op: rid=102 be_modify uid=anotherdifferententry,ou=people,dc=samedomain,dc=net (0)

1 0

Re: (ITS#8117) Bugs related to key-size in lmdb and backend
by h.b.furuseth＠usit.uio.no 04 May '15

04 May '15

On 03/05/15 09:09, Howard Chu wrote: > Hallvard Breien Furuseth wrote: >> test001 still crashes if you insert >> assert(a->mv_size == sizeof(int) && b->mv_size == sizeof(int)); >> in mdb_cmp_int(). >> Using RE24 commit 98f70f1841f85d93 "ITS#8120 Move final...". > > Not happening here, all tests pass with asserts enabled. You just fixed it. Turns out your older patches to this ITS introduced that one. >> Looking yet again at the doc, mdb_dbi_open():INTEGERKEY >> says "typically" sizeof(int/size_t), I can't see it >> requires these sizes. Maybe you copied that from a >> suggestion from me back when I asked for clarifications. > > Probably. The point was to show the expected sizes without enumerating > every possible C integer type that would work - e.g. unsigned int, > unsigned long, off_t, pid_t, whatever. At some point you have to say > "don't be an idiot." Don't be an idiot. (a) then we'd just say "the architecture's native unsigned integer types" or something, it's no need to be so vague nor to drag in every typedef under the sun. And (b) that's not what the code does anyway. If I understand correctly this time, the doc should simply say that the two types size_t and unsigned int are supported. The "typically" is plain misleading. That is, if mdb_node_search() shows the intent when it picks either int-sized or size_t-sized for IS_BRANCH. OTOH, another bug: default_cmp pick cmp_int for INTEGERDUP|DUPFIXED and some other replaces md_dcmp = cmp_int with cmp_long, which makes no sense unless cmp_int is just a placeholder. Yet at least mdb_dcmp() calls that placeholder directly without checking the data size. And if it's just a placeholder, how about instead setting dcmp to something which just abort()s, to make sure the bug of not replacing it is caught? >> "keys must all be of the same size" in the doc is unclear. >> I gather it should be "... in the DB's lifetime". But it >> can be read as "...at a given time": Write size_t-sized >> integers, empty the DB, then write int-sized integers. >> That does not work, since me_dbxs[].md_dcmp is updated. > > Don't be an idiot. If no time is stated, then it's For All Time. > Anything not called out specifically is, by definition, non-specific. I can't spot the idiocy of expecting a property which springs dynamically into life, to dynamically go away when the data which caused it is gone. In particular since that's how LMDB alignment works. Anyway, that seems to be what happens after latest commit, so maybe it doesn't matter anymore. Maybe the DB flags should include log2(integer sizes) in 2 2-bit fields.

1 0

Re: (ITS#8117) Bugs related to key-size in lmdb and backend
by hyc＠symas.com 03 May '15

03 May '15

Hallvard Breien Furuseth wrote: > test001 still crashes if you insert > assert(a->mv_size == sizeof(int) && b->mv_size == sizeof(int)); > in mdb_cmp_int(). > Using RE24 commit 98f70f1841f85d93 "ITS#8120 Move final...". Not happening here, all tests pass with asserts enabled. > I don't see "same size" in the INTEGERDUP doc, it's looser > than for INTEGERKEY integers. Or have I gone blind again? > Anyway, it would be clearer to cut some doc and say data > behave like INTEGERKEY keys. Ignoring that, though: > > Looking yet again at the doc, mdb_dbi_open():INTEGERKEY > says "typically" sizeof(int/size_t), I can't see it > requires these sizes. Maybe you copied that from a > suggestion from me back when I asked for clarifications. Probably. The point was to show the expected sizes without enumerating every possible C integer type that would work - e.g. unsigned int, unsigned long, off_t, pid_t, whatever. At some point you have to say "don't be an idiot." > "keys must all be of the same size" in the doc is unclear. > I gather it should be "... in the DB's lifetime". But it > can be read as "...at a given time": Write size_t-sized > integers, empty the DB, then write int-sized integers. > That does not work, since me_dbxs[].md_dcmp is updated. Don't be an idiot. If no time is stated, then it's For All Time. Anything not called out specifically is, by definition, non-specific. > "mc->mc_dbx->md_dcmp = mdb_cmp_clong;" looks wrong. > That updates env->me_dbxs[], I believe. But: > > If we mdb_txn_abort(), the txn has not been a no-op: > It will require next txn and even existing txns to use > size_t-sized INTEGERDUP data. Good point. I've committed a revised patch to leave the mc_dbx pointer alone. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8124) Patch "Context for compare functions"
by rouzier＠gmail.com 03 May '15

03 May '15

--f46d0418253ce774cd051521cc5a Content-Type: text/plain; charset=UTF-8 Howard thank you for taking the time to explain your reasoning. I am curious if I were remove the conditional compilation would the patch be more palatable. Because usually if you are using an interpreted language you are already taking a performance hit. Also it only slows your program down if you use the compare functions. If answer is still no I will just maintain the patch in my own branch. James Rouzier. On Sat, May 2, 2015 at 6:04 PM, Howard Chu <hyc(a)symas.com> wrote: > rouzier(a)gmail.com wrote: > >> Full_Name: James Rouzier >> Version: LMDB mdb.master >> OS: N/A >> URL: >> https://github.com/rouzier/openldap/commit/33f1dc8be4a8503e78930f130ff9c8e5… >> Submission from: (NULL) (70.81.32.80) >> >> >> New feature inclusion request: "Context for compare functions" >> >> I am finishing up a new perl module which is a very thin wrapper for LMDB. >> (The current perl LMDB module does not fit my needs as it does not support >> NO_TLS really support). >> >> When looking at mdb_set_compare and mdb_set_dupsort. >> >> There were three choices. >> >> * Not support mdb_set_compare, mdb_set_dupsort in the module. >> * Capture each mdb_*(del|put|get) function to figure which dbi I am using. >> * Add support for contexts in the compare functions. >> >> So I decided on the latter. >> >> I understand that passing a context for each compare can add some >> overhead. >> So I made this feature optional it is only enabled if the macro >> MDB_CMP_CTX is >> enabled. >> > > I don't see supporting compare functions in interpreted languages being a > realistic/worthwhile thing to do. The difference in performance is orders > of magnitude. > > I also don't believe such conditional compilation is a good idea. LMDB is > designed to be simple, to have very few options, and to Just Work the same > on every platform. Conditionally compiled features are horrible because you > can't guess which features will be present in a system-installed library. > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/project/ > --f46d0418253ce774cd051521cc5a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_quote"><div dir=3D"ltr">Howard thank y= ou for taking the time to explain your reasoning.<div><br></div><div>I am c= urious if I were remove the conditional compilation would the patch be more= palatable.</div><div>Because usually if you are using an=C2=A0<span style= =3D"font-size:12.8000001907349px">interpreted</span>=C2=A0language you are = already taking a performance hit.</div><div>Also it only slows your program= down if you use the=C2=A0<span style=3D"font-size:12.8000001907349px">comp= are functions.</span></div><div><br></div><div>If answer is still no I will= just maintain the patch in my own branch.<span class=3D"HOEnZb"><font colo= r=3D"#888888"><br></font></span></div><span class=3D"HOEnZb"><font color=3D= "#888888"><div><br></div><div>James Rouzier.</div><div><br><br></div><div><= br></div><div><br></div><div><br></div></font></span></div><div class=3D"HO= EnZb"><div class=3D"h5"><div class=3D"gmail_extra"><br><div class=3D"gmail_= quote">On Sat, May 2, 2015 at 6:04 PM, Howard Chu <span dir=3D"ltr"><<a = href=3D"mailto:hyc@symas.com" target=3D"_blank">hyc(a)symas.com</a>></span= > wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo= rder-left:1px #ccc solid;padding-left:1ex"><a href=3D"mailto:rouzier@gmail.= com" target=3D"_blank">rouzier(a)gmail.com</a> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> Full_Name: James Rouzier<br> Version: LMDB mdb.master<br> OS: N/A<br> URL: <a href=3D"https://github.com/rouzier/openldap/commit/33f1dc8be4a8503e= 78930f130ff9c8e5aa9bfa7b" target=3D"_blank">https://github.com/rouzier/open= ldap/commit/33f1dc8be4a8503e78930f130ff9c8e5aa9bfa7b</a><br> Submission from: (NULL) (70.81.32.80)<br> <br> <br> New feature inclusion request: "Context for compare functions"<br= > <br> I am finishing up a new perl module which is a very thin wrapper for LMDB.<= br> (The current perl LMDB module does not fit my needs as it does not support<= br> NO_TLS really support).<br> <br> When looking at mdb_set_compare and mdb_set_dupsort.<br> <br> There were three choices.<br> <br> * Not support mdb_set_compare, mdb_set_dupsort in the module.<br> * Capture each mdb_*(del|put|get) function to figure which dbi I am using.<= br> * Add support for contexts in the compare functions.<br> <br> So I decided on the latter.<br> <br> I understand that passing a context for each compare can add some overhead.= <br> So I made this feature optional it is only enabled if the macro MDB_CMP_CTX= is<br> enabled.<br> </blockquote> <br> I don't see supporting compare functions in interpreted languages being= a realistic/worthwhile thing to do. The difference in performance is order= s of magnitude.<br> <br> I also don't believe such conditional compilation is a good idea. LMDB = is designed to be simple, to have very few options, and to Just Work the sa= me on every platform. Conditionally compiled features are horrible because = you can't guess which features will be present in a system-installed li= brary.<span><font color=3D"#888888"><br> <br> -- <br> =C2=A0 -- Howard Chu<br> =C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"= http://www.symas.com" target=3D"_blank">http://www.symas.com</a><br> =C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland= sun.com/hyc/" target=3D"_blank">http://highlandsun.com/hyc/</a><br> =C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p= roject/" target=3D"_blank">http://www.openldap.org/project/</a><br> </font></span></blockquote></div><br></div> </div></div></div><br></div> --f46d0418253ce774cd051521cc5a--

1 0

Re: (ITS#8124) Patch "Context for compare functions"
by hyc＠symas.com 03 May '15

03 May '15

rouzier(a)gmail.com wrote: > Full_Name: James Rouzier > Version: LMDB mdb.master > OS: N/A > URL: https://github.com/rouzier/openldap/commit/33f1dc8be4a8503e78930f130ff9c8e5… > Submission from: (NULL) (70.81.32.80) > > > New feature inclusion request: "Context for compare functions" > > I am finishing up a new perl module which is a very thin wrapper for LMDB. > (The current perl LMDB module does not fit my needs as it does not support > NO_TLS really support). > > When looking at mdb_set_compare and mdb_set_dupsort. > > There were three choices. > > * Not support mdb_set_compare, mdb_set_dupsort in the module. > * Capture each mdb_*(del|put|get) function to figure which dbi I am using. > * Add support for contexts in the compare functions. > > So I decided on the latter. > > I understand that passing a context for each compare can add some overhead. > So I made this feature optional it is only enabled if the macro MDB_CMP_CTX is > enabled. I don't see supporting compare functions in interpreted languages being a realistic/worthwhile thing to do. The difference in performance is orders of magnitude. I also don't believe such conditional compilation is a good idea. LMDB is designed to be simple, to have very few options, and to Just Work the same on every platform. Conditionally compiled features are horrible because you can't guess which features will be present in a system-installed library. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8124) Patch "Context for compare functions"
by rouzier＠gmail.com 03 May '15

03 May '15

Full_Name: James Rouzier Version: LMDB mdb.master OS: N/A URL: https://github.com/rouzier/openldap/commit/33f1dc8be4a8503e78930f130ff9c8e5… Submission from: (NULL) (70.81.32.80) New feature inclusion request: "Context for compare functions" I am finishing up a new perl module which is a very thin wrapper for LMDB. (The current perl LMDB module does not fit my needs as it does not support NO_TLS really support). When looking at mdb_set_compare and mdb_set_dupsort. There were three choices. * Not support mdb_set_compare, mdb_set_dupsort in the module. * Capture each mdb_*(del|put|get) function to figure which dbi I am using. * Add support for contexts in the compare functions. So I decided on the latter. I understand that passing a context for each compare can add some overhead. So I made this feature optional it is only enabled if the macro MDB_CMP_CTX is enabled. This patch does the following. * Adds context to the MDB_cmp_func typedef int (MDB_cmp_func)(const MDB_val *a, const MDB_val *b ,void* ctx); * And two new data members to the MDB_dbx struct * void *md_cmpctx; /**< user-provided context for md_cmp */ * void *md_dcmpctx; /**< user-provided context for md_dcmp */ * Add functions for setting/getting the contexts * int mdb_set_cmpctx(MDB_txn *txn, MDB_dbi dbi, void *ctx); * int mdb_set_dcmpctx(MDB_txn *txn, MDB_dbi dbi, void *ctx); * int mdb_get_cmpctx(MDB_txn *txn, MDB_dbi dbi, void **ctx); * int mdb_get_dcmpctx(MDB_txn *txn, MDB_dbi dbi, void **ctx); I have no problem maintaining this as a separate patch if it does not fit in the vision of LMDB. I believe this can be useful for people who wants to add LMDB to a scripting language. New feature inclusion request: "Context for compare functions" I am finishing up a new perl module which is a very thin wrapper for LMDB. (The current perl LMDB module does not fit my needs as it does not support NO_TLS really well). When looking at mdb_set_compare and mdb_set_dupsort. There were three choices. * Not support mdb_set_compare, mdb_set_dupsort in the module. * Capture each mdb_*(del|put|get) function to figure which dbi I am using. * Add support for contexts in the compare functions. So I decided on the latter. I understand that passing a context for each compare can add some overhead. So I made this feature optional it is only enabled if the macro MDB_CMP_CTX is enabled. This patch does the following. * Adds context to the MDB_cmp_func typedef int (MDB_cmp_func)(const MDB_val *a, const MDB_val *b ,void* ctx); * And two new data members to the MDB_dbx struct * void *md_cmpctx; /**< user-provided context for md_cmp */ * void *md_dcmpctx; /**< user-provided context for md_dcmp */ * Add functions for setting/getting the contexts * int mdb_set_cmpctx(MDB_txn *txn, MDB_dbi dbi, void *ctx); * int mdb_set_dcmpctx(MDB_txn *txn, MDdbi i dbi, void *ctx); * int mdb_get_cmpctx(MDB_txn *txn, MDB_dbi dbi, void **ctx); * int mdb_get_dcmpctx(MDB_txn *txn, MDB_dbi dbi, void **ctx); I have no problem maintaining this as a separate patch if it does not fit in the vision of LMDB. I figured it might be very useful for others. Thank You for creating and releasing LMDB I, James Rouzier, hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.

1 0

Re: (ITS#8117) Bugs related to key-size in lmdb and backend
by h.b.furuseth＠usit.uio.no 02 May '15

02 May '15

test001 still crashes if you insert assert(a->mv_size == sizeof(int) && b->mv_size == sizeof(int)); in mdb_cmp_int(). Using RE24 commit 98f70f1841f85d93 "ITS#8120 Move final...". I don't see "same size" in the INTEGERDUP doc, it's looser than for INTEGERKEY integers. Or have I gone blind again? Anyway, it would be clearer to cut some doc and say data behave like INTEGERKEY keys. Ignoring that, though: Looking yet again at the doc, mdb_dbi_open():INTEGERKEY says "typically" sizeof(int/size_t), I can't see it requires these sizes. Maybe you copied that from a suggestion from me back when I asked for clarifications. "keys must all be of the same size" in the doc is unclear. I gather it should be "... in the DB's lifetime". But it can be read as "...at a given time": Write size_t-sized integers, empty the DB, then write int-sized integers. That does not work, since me_dbxs[].md_dcmp is updated. "mc->mc_dbx->md_dcmp = mdb_cmp_clong;" looks wrong. That updates env->me_dbxs[], I believe. But: If we mdb_txn_abort(), the txn has not been a no-op: It will require next txn and even existing txns to use size_t-sized INTEGERDUP data. The assignment may be non-atomic. Another txn may be reading the pointer. I expect IL32P64 architectures are examples, and also function pointers can be quite large. (OpenLDAP expects void*-sized function pointers though.)

1 0

Re: (ITS#8123) Incorrect loglevel man page content
by hyc＠symas.com 01 May '15

01 May '15

elecharny(a)apache.org wrote: > Full_Name: Emmanuel L.charny > Version: 2.4.40 > OS: > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (80.12.43.27) > > > The slapd-config man page contains a slightly incorrect explaination for the > olcLogLevel config element. One can read : > > olcLogLevel: <integer> [...] > ... > The desired log level can be input as ... or as a list of the names that > are shown between brackets... > > but the sample does not show any bracket being used : > > olcLogLevel: acl trace > > Actually, using brackets does not work (you can't inject the attribute using > [acl trace] or {acl trace}) "between brackets" refers to the manpage text itself, it does not mean to enter anything with literal brackets. It probably should be corrected to "between parentheses" since it is referring to e.g. 1 (0x1 trace) trace function calls -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8122) Incorrect Schema content
by hyc＠symas.com 01 May '15

01 May '15

elecharny(a)apache.org wrote: > Full_Name: Emmanuel L.charny > Version: 2.4.40 > OS: Mac OSX > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (80.12.55.37) > > > There are a few elements in some schema which are incorrect (even if it does not > break anything) : This is a known issue. Will not be fixed. > > Core schema > ----------- > * The organizationalRole OC has the preferredDeliveryMethod AT declared twice > * The residentialPerson OC has the preferredDeliveryMethod AT declared twice These definitions are copied verbatim from RFC2256. We do not alter published schema from their published form. > Cosine schema > ------------- > * The domain OC has the streetAddress AT declared twice > * The RFC822localPart OC has the telephoneNumber AT declared twice Again, copied verbatim from RFC1274. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8123) Incorrect loglevel man page content
by elecharny＠apache.org 01 May '15

01 May '15

Full_Name: Emmanuel L.charny Version: 2.4.40 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (80.12.43.27) The slapd-config man page contains a slightly incorrect explaination for the olcLogLevel config element. One can read : olcLogLevel: <integer> [...] ... The desired log level can be input as ... or as a list of the names that are shown between brackets... but the sample does not show any bracket being used : olcLogLevel: acl trace Actually, using brackets does not work (you can't inject the attribute using [acl trace] or {acl trace})

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs May 2015