(ITS#7923) constraint_close / free problems on olcDbDirectory change
by ebackes@symas.com
Full_Name: Emily Backes
Version: RE24
OS:
URL:
Submission from: (NULL) (50.113.67.84)
Changing olcDbDirectory on a live server with overlays makes a mess; much like
the recent ITS#7906, constraint has a problem with open/close management.
constraint_close calls constraint_free( ap, 1 ) which wipes everything out, but
the state is not restored when things are restarted. In particular, a second
olcDbDirectory mod results in constraint_free being called again with garbage.
6 years, 4 months
(ITS#7922) modify.c:77: bad nested if
by dcb314@hotmail.com
Full_Name: David Binderman
Version: 2.4.39
OS: Fedora Linux
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (79.64.240.58)
[modify.c:77] -> [modify.c:78]: (warning) Opposite conditions in nested 'if'
blocks lead to a dead code block.
if ( ml->sml_values != NULL ) {
if ( ml->sml_values == NULL ) {
continue;
}
6 years, 4 months
(ITS#7921) test058 fails with back-mdb
by michael@stroeder.com
Full_Name: Michael Ströder
Version: RE24 9321ecc040deb025675888559cc43052ee563c6a
OS: opensuse 12.3 x86_64
URL:
Submission from: (NULL) (212.227.35.93)
With recent RE24 test058 always fails with back-mdb.
Content of testrun/ upon request.
6 years, 5 months
Re: (ITS#7919) slapd would not start with back-ldap database
by quanah@zimbra.com
--On Thursday, August 14, 2014 7:43 AM +0000 dieter(a)dkluenter.de wrote:
> Answering b), Yes I confirm, that this can be reproduced with=20
> openldap-OPENLDAP_REL_ENG_2_4-b046124
As noted by Howard, your configuration is invalid.
--Quanah
--
Quanah Gibson-Mount
Server Architect
Zimbra, Inc.
--------------------
Zimbra :: the leader in open source messaging and collaboration
6 years, 5 months
Re: (ITS#7919) slapd would not start with back-ldap database
by dieter@dkluenter.de
Am Wed, 13 Aug 2014 11:28:30 -0700
schrieb Quanah Gibson-Mount <quanah(a)zimbra.com>:
> --On Wednesday, August 13, 2014 8:27 AM +0000 dieter(a)dkluenter.de
> wrote:
>=20
> > Sorry, it is back-ldap with pcache and it seems to be a pcache
> > problem. When disabling pcache, slapd runs fine.
>=20
> a) Confirm you still see this issue with current RE24 if you want it
> fixed in the 2.4 series, as in general we're planning on 2.4.40 to be
> the final release for 2.4
>=20
> b) If you are able to reproduce this with current RE24, please
> provide an example configuration that causes the issue. test020
> passes w/o issue.
Answering b), Yes I confirm, that this can be reproduced with=20
openldap-OPENLDAP_REL_ENG_2_4-b046124
-Dieter
--=20
Dieter Kl=C3=BCnter | Systemberatung
http://sys4.de
GPG Key ID: E9ED159B
53=C2=B037'09,95"N
10=C2=B008'02,42"E
6 years, 5 months
Re: (ITS#7919) slapd would not start with back-ldap database
by hyc@symas.com
quanah(a)zimbra.com wrote:
> --On Wednesday, August 13, 2014 8:27 AM +0000 dieter(a)dkluenter.de wrote:
>
>> Sorry, it is back-ldap with pcache and it seems to be a pcache
>> problem. When disabling pcache, slapd runs fine.
>
> a) Confirm you still see this issue with current RE24 if you want it fixed
> in the 2.4 series, as in general we're planning on 2.4.40 to be the final
> release for 2.4
>
> b) If you are able to reproduce this with current RE24, please provide an
> example configuration that causes the issue. test020 passes w/o issue.
The example config is invalid.
###
include schema/core.schema
include schema/cosine.schema
include schema/inetorgperson.schema
#
modulepath ../servers/slapd/overlays
moduleload pcache.la
database ldap
uri ldap://example.com
suffix dc=example,dc=com
rootdn dc=example,dc=com
rootpw xxx
overlay pcache
directory /tmp/testr/db.1.a
pcache mdb 50000 2 500 3600
pcacheAttrset 0 mail uid
pcacheAttrset 1 cn telephoneNumber
pcachePersist TRUE
pcacheTemplate (mail=) 0 10800 7200
pcacheTemplate (uid=) 1 10800 7200
index objectclass pres
index mail,uid,telephoneNumber pres,eq
database monitor
###
"directory" is not a valid config keyword for the pcache overlay. It is a
valid keyword for back-mdb, but here it was given before the "pcache mdb..."
line so slapd doesn't yet know that back-mdb will be used. The slapo-pcache(5)
manpage clearly states what directives are valid.
Personally I'd be fine with leaving this to SEGV as it does. Catching user
errors doesn't help much in the long run; either way slapd will fail to start
so there's no difference either way.
But in this case, the SEGV is now prevented in git master.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
6 years, 5 months
Re: (ITS#7919) slapd would not start with back-ldap database
by quanah@zimbra.com
--On Wednesday, August 13, 2014 8:27 AM +0000 dieter(a)dkluenter.de wrote:
> Sorry, it is back-ldap with pcache and it seems to be a pcache
> problem. When disabling pcache, slapd runs fine.
a) Confirm you still see this issue with current RE24 if you want it fixed
in the 2.4 series, as in general we're planning on 2.4.40 to be the final
release for 2.4
b) If you are able to reproduce this with current RE24, please provide an
example configuration that causes the issue. test020 passes w/o issue.
Thanks
--Quanah
--
Quanah Gibson-Mount
Server Architect
Zimbra, Inc.
--------------------
Zimbra :: the leader in open source messaging and collaboration
6 years, 5 months