openldap-bugs December 2014

openldap-bugs@openldap.org

24 participants
95 discussions

Re: (ITS#8011) few mistakes in lmdb-backend
by leo＠yuriev.ru 28 Dec '14

28 Dec '14

This is a multi-part message in MIME format. --------------060206050400040309010905 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit The attached files is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned rights and/or interest in this work to any party. I, Leonid Yuriev am authorized by Peter-… [View More]Service LLC, my employer, to release this work under the following terms. Peter-Service LLC hereby places the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. --------------060206050400040309010905 Content-Type: text/x-patch; name="ITS8011.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ITS8011.patch" commit 1bdae5a756d803961db4d2c7f6d13e975f89f1f8 Author: Leo Yuriev <leo(a)yuriev.ru> Date: 2014-12-28 23:14:52 +0300 ITS#8011: few corrections for lmdb-backend; dn2id.c: + assertion for mdb_id2l_insert() result; - unnecessary assignment; search.c: - unused variable 'first'; + range-check for mdb_idl_search() result; * fix sctmp/stack allocation size; diff --git a/servers/slapd/back-mdb/dn2id.c b/servers/slapd/back-mdb/dn2id.c index 41c4758..0890bce 100644 --- a/servers/slapd/back-mdb/dn2id.c +++ b/servers/slapd/back-mdb/dn2id.c @@ -746,7 +746,8 @@ mdb_idscopes( /* remember our chain of parents */ id2.mid = id; id2.mval = data; - mdb_id2l_insert( isc->sctmp, &id2 ); + rc = mdb_id2l_insert( isc->sctmp, &id2 ); + assert(rc == 0); } ptr = data.mv_data; ptr += data.mv_size - sizeof(ID); @@ -760,9 +761,11 @@ mdb_idscopes( if ( x <= isc->scopes[0].mid && isc->scopes[x].mid == id ) { if ( !isc->scopes[x].mval.mv_data ) { /* This node is in scope, add parent chain to scope */ - int i = isc->sctmp[0].mid; - for ( i = 1; i <= isc->sctmp[0].mid; i++ ) - mdb_id2l_insert( isc->scopes, &isc->sctmp[i] ); + int i; + for ( i = 1; i <= isc->sctmp[0].mid; i++ ) { + rc = mdb_id2l_insert( isc->scopes, &isc->sctmp[i] ); + assert(rc == 0); + } /* check id again since inserts may have changed its position */ if ( isc->scopes[x].mid != id ) x = mdb_id2l_search( isc->scopes, id ); diff --git a/servers/slapd/back-mdb/search.c b/servers/slapd/back-mdb/search.c index 9089016..8bcdc10 100644 --- a/servers/slapd/back-mdb/search.c +++ b/servers/slapd/back-mdb/search.c @@ -140,7 +140,6 @@ static int search_aliases( struct berval bv_alias = BER_BVC( "alias" ); AttributeAssertion aa_alias = ATTRIBUTEASSERTION_INIT; Filter af; - int first = 1; aliases = stack; /* IDL of all aliases in the database */ curscop = aliases + MDB_IDL_DB_SIZE; /* Aliases in the current scope */ @@ -807,7 +806,7 @@ loop_begin: scopeok = 1; } else { i = mdb_idl_search( candidates, id ); - if ( candidates[i] == id ) + if (i <= candidates[0] && candidates[i] == id ) scopeok = 1; } if ( scopeok ) @@ -1265,8 +1264,10 @@ static void *search_stack( Operation *op ) } if ( !ret ) { - ret = ch_malloc( mdb->mi_search_stack_depth * MDB_IDL_UM_SIZE - * sizeof( ID ) ); + size_t case_stack = mdb->mi_search_stack_depth * MDB_IDL_UM_SIZE * sizeof( ID ); + size_t case_sctmp = MDB_IDL_UM_SIZE * sizeof( ID2 ); + size_t size = (case_stack > case_sctmp) ? case_stack : case_sctmp; + ret = ch_malloc( size ); if ( op->o_threadctx ) { ldap_pvt_thread_pool_setkey( op->o_threadctx, (void *)search_stack, ret, search_stack_free, NULL, NULL ); --------------060206050400040309010905-- [View Less]

1 0

(ITS#8011) few mistakes in lmdb-backend
by leo＠yuriev.ru 28 Dec '14

28 Dec '14

Full_Name: Leonid Yuriev Version: master OS: RHEL7 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (31.130.36.33) Please review the patch, which will be attached shortly. mdb_idscopes(): + assertion for mdb_id2l_insert() result; - unnecessary assignment; static search_aliases(): - unused variable 'first'; + range-check for mdb_idl_search() result; static search_stack(): * fix sctmp/stack allocation size;

1 0

(ITS#8010) LMDB: New mdb_txn_begin() flag to init as reset
by scott＠GameRanger.com 22 Dec '14

22 Dec '14

Full_Name: Scott Kevill Version: n/a OS: n/a URL: Submission from: (NULL) (101.166.148.57) Using a read-only txn with mdb_txn_reset() and mdb_txn_renew() is a little clumsy at the moment because the first use needs to be a mdb_txn_begin(). This means either an initial mdb_txn_begin() + mdb_txn_reset() to get it into the reset state, or else for every operation to do something like: if (txn) mdb_txn_renew() else mdb_txn_begin() ... do work ... mdb_txn_reset() An additional flag (… [View More]

1 0

Re: (ITS#7780) constraint_attribute <attr> <size|count> 0 cause segfault
by michael＠stroeder.com 20 Dec '14

20 Dec '14

ondra(a)mistotebe.net wrote: > On Fri, Dec 19, 2014 at 02:41:55AM +0000, michael(a)stroeder.com wrote: >> Just because I'm curious: >> >> What's the use-case for setting size and count to zero? >> >> If one wants to forbid an attribute completely one should probably use >> NOT in a DIT content rule for the STRUCTURAL object class. >> (This does not mean that this shouldn't be fixed though.) > > I personally thought that OpenLDAP did not … [View More]

1 0

Re: (ITS#7780) constraint_attribute <attr> <size|count> 0 cause segfault
by ondra＠mistotebe.net 20 Dec '14

20 Dec '14

On Fri, Dec 19, 2014 at 02:41:55AM +0000, michael(a)stroeder.com wrote: > Just because I'm curious: > > What's the use-case for setting size and count to zero? > > If one wants to forbid an attribute completely one should probably use > NOT in a DIT content rule for the STRUCTURAL object class. > (This does not mean that this shouldn't be fixed though.) I personally thought that OpenLDAP did not implement DIT content rules at all.

1 0

Re: (ITS#8009) SUBSTR caseIgnoreIA5SubstringsMatch for *Record in cosine schema
by michael＠stroeder.com 19 Dec '14

19 Dec '14

Michael Ströder wrote: > Quanah Gibson-Mount wrote: >> --On Friday, December 19, 2014 11:29 PM +0100 Michael Ströder >> <michael(a)stroeder.com> wrote: >> >>>> 2.4 is for bugfixes and regressions only. >> >> See above. > > Well, I consider it to be a serious defect that the old *Record attribute type > descriptions defined in obsoleted RFC 1274 are still in cosine.(ldif|schema) > even though they are not in RFC 4524. > > I … [View More]

1 0

Re: (ITS#8009) SUBSTR caseIgnoreIA5SubstringsMatch for *Record in cosine schema
by michael＠stroeder.com 19 Dec '14

19 Dec '14

Quanah Gibson-Mount wrote: > --On Friday, December 19, 2014 11:29 PM +0100 Michael Ströder > <michael(a)stroeder.com> wrote: > >>> 2.4 is for bugfixes and regressions only. > > See above. Well, I consider it to be a serious defect that the old *Record attribute type descriptions defined in obsoleted RFC 1274 are still in cosine.(ldif|schema) even though they are not in RFC 4524. I also consider it to be a bug that aRecord and aAAARecord don't have the same … [View More]

1 0

Re: (ITS#8009) SUBSTR caseIgnoreIA5SubstringsMatch for *Record in cosine schema
by quanah＠zimbra.com 19 Dec '14

19 Dec '14

--On Friday, December 19, 2014 11:29 PM +0100 Michael Str=C3=B6der=20 <michael(a)stroeder.com> wrote: >> 2.4 is for bugfixes and regressions only. See above. -- Quanah Gibson-Mount Platform Architect Zimbra, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Re: (ITS#8009) SUBSTR caseIgnoreIA5SubstringsMatch for *Record in cosine schema
by michael＠stroeder.com 19 Dec '14

19 Dec '14

This is a cryptographically signed message in MIME format. --------------ms040409080506030800020107 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable quanah(a)zimbra.com wrote: > --On Friday, December 19, 2014 8:25 PM +0000 michael(a)stroeder.com wrote= : >=20 >> There isn't a new version of the COSINE schema. >> >> But the attributes defined in RFC 1274, which were not added to RFC 45= 24 >> [1], are used in the usual DNS … [View More]zone schema which defines object class >> 'dNSDomain2'. The DNS zone schema defines more attributes for DNS RRs = and >> all of them have a SUBSTR matching rule defined. >> >> If you reject this patch because you don't want to change a "standard"= >> schema the other possibility would be to completely hunk out these RFC= >> 1274 declarations from cosine.(schema|ldif) to avoid collision with >> separate DNS schema files adding them. >> >> [1] http://tools.ietf.org/html/rfc4524#appendix-A.4 >=20 > This sounds like a 2.5 feature request then. We can keep it in mind fo= r=20 > that. >=20 > 2.4 is for bugfixes and regressions only. My patch would be trivial and without causing any harm. Ciao, Michael. --------------ms040409080506030800020107 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIMgTCC BjQwggQcoAMCAQICAR4wDQYJKoZIhvcNAQEFBQAwfTELMAkGA1UEBhMCSUwxFjAUBgNVBAoT DVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFsIENlcnRpZmljYXRlIFNp Z25pbmcxKTAnBgNVBAMTIFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9yaXR5MB4XDTA3 MTAyNDIxMDE1NVoXDTE3MTAyNDIxMDE1NVowgYwxCzAJBgNVBAYTAklMMRYwFAYDVQQKEw1T dGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZpY2F0ZSBTaWdu aW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJtZWRpYXRlIENs aWVudCBDQTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMcJg8zOLdgasSmkLhOr lr6KMoOMpohBllVHrdRvEg/q6r8jR+EK75xCGhR8ToREoqe7zM9/UnC6TS2y9UKTpT1v7RSM zR0t6ndl0TWBuUr/UXBhPk+Kmy7bI4yW4urC+y7P3/1/X7U8ocb8VpH/Clt+4iq7nirMcNh6 qJR+xjOhV+VHzQMALuGYn5KZmc1NbJQYclsGkDxDz2UbFqE2+6vIZoL+jb9x4Pa5gNf1TwSD kOkikZB1xtB4ZqtXThaABSONdfmv/Z1pua3FYxnCFmdr/+N2JLKutIxMYqQOJebr/f/h5t95 m4JgrM3Y/w7YX9d7YAL9jvN4SydHsU6n65cCAwEAAaOCAa0wggGpMA8GA1UdEwEB/wQFMAMB Af8wDgYDVR0PAQH/BAQDAgEGMB0GA1UdDgQWBBRTcu2SnODaywFcfH6WNU7y1LhRgjAfBgNV HSMEGDAWgBROC+8apEBbpRdphzDKNGhD0EGu8jBmBggrBgEFBQcBAQRaMFgwJwYIKwYBBQUH MAGGG2h0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNvbS9jYTAtBggrBgEFBQcwAoYhaHR0cDovL3d3 dy5zdGFydHNzbC5jb20vc2ZzY2EuY3J0MFsGA1UdHwRUMFIwJ6AloCOGIWh0dHA6Ly93d3cu c3RhcnRzc2wuY29tL3Nmc2NhLmNybDAnoCWgI4YhaHR0cDovL2NybC5zdGFydHNzbC5jb20v c2ZzY2EuY3JsMIGABgNVHSAEeTB3MHUGCysGAQQBgbU3AQIBMGYwLgYIKwYBBQUHAgEWImh0 dHA6Ly93d3cuc3RhcnRzc2wuY29tL3BvbGljeS5wZGYwNAYIKwYBBQUHAgEWKGh0dHA6Ly93 d3cuc3RhcnRzc2wuY29tL2ludGVybWVkaWF0ZS5wZGYwDQYJKoZIhvcNAQEFBQADggIBAAqD CH14qywGXLhjjF6uHLkjd02hcdh9hrw+VUsv+q1eeQWB21jWj3kJ96AUlPCoEGZ/ynJNScWy 6QMVQjbbMXltUfO4n4bGGdKo3awPWp61tjAFgraLJgDk+DsSvUD6EowjMTNx25GQgyYJ5RPI zKKR9tQW8gGK+2+RHxkUCTbYFnL6kl8Ch507rUdPPipJ9CgJFws3kDS3gOS5WFMxcjO5DwKf KSETEPrHh7p5shuuNktvsv6hxHTLhiMKX893gxdT3XLS9OKmCv87vkINQcNEcIIoFWbP9HOR z9v3vQwR4e3ksLc2JZOAFK+ssS5XMEoznzpihEP0PLc4dCBYjbvSD7kxgDwZ+Aj8Q9PkbvE9 sIPP7ON0fz095HdThKjiVJe6vofq+n6b1NBc8XdrQvBmunwxD5nvtTW4vtN6VY7mUCmxsCie uoBJ9OlqmsVWQvifIYf40dJPZkk9YgGTzWLpXDSfLSplbY2LL9C9U0ptvjcDjefLTvqSFc7t w1sEhF0n/qpA2r0GpvkLRDmcSwVyPvmjFBGqUp/pNy8ZuPGQmHwFi2/14+xeSUDG2bwnsYJQ G2EdJCB6luQ57GEnTA/yKZSTKI8dDQa8Sd3zfXb19mOgSF0bBdXbuKhEpuP9wirslFe6fQ1t 5j5R0xi72MZ8ikMu1RQZKCyDbMwazlHiMIIGRTCCBS2gAwIBAgIDC01QMA0GCSqGSIb3DQEB BQUAMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UEChMNU3RhcnRDb20gTHRkLjErMCkGA1UECxMi U2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2lnbmluZzE4MDYGA1UEAxMvU3RhcnRDb20g Q2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0ZSBDbGllbnQgQ0EwHhcNMTQwOTIzMjA0NzU1 WhcNMTUwOTI0MjIwNTE4WjBfMRkwFwYDVQQNExA2TTJZN2k5ekR0ZTZqVXcwMR0wGwYDVQQD DBRtaWNoYWVsQHN0cm9lZGVyLmNvbTEjMCEGCSqGSIb3DQEJARYUbWljaGFlbEBzdHJvZWRl ci5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDKcgfT19Tn3u/h+Di7CoUk M9TFAdX2rGt8z9ze95K0/JiXQmiuooesP6F8I1n5OjLrk031/287bpaecugMX4UTYORCLrWJ OArmNlOvl0kbVZCSTr3xQ1Y7zuVRYFFhiJQzvALd6TYTSvNH32ojETh0b3DCzX0Xcoom803y 0xPKg/DlWTDirHZJbnhYQEzHugJcEhk88MPyi+V53q8NXB5VJphcVRuTFsolHzsyyKHfgFr5 wzlIAdA1DXWNpImMV6ptCdeN/ScRKe+jRchyRz3DbjTDeNyC7pvlIhAEja+/lNoi/u8qo2TS j5wZz02cLDn/EP84AH0CP+oNxro2F4cJAgMBAAGjggLaMIIC1jAJBgNVHRMEAjAAMAsGA1Ud DwQEAwIEsDAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwHQYDVR0OBBYEFOPPUGEQ tk7fMQl+ZlDgj5zo0JciMB8GA1UdIwQYMBaAFFNy7ZKc4NrLAVx8fpY1TvLUuFGCMB8GA1Ud EQQYMBaBFG1pY2hhZWxAc3Ryb2VkZXIuY29tMIIBTAYDVR0gBIIBQzCCAT8wggE7BgsrBgEE AYG1NwECAzCCASowLgYIKwYBBQUHAgEWImh0dHA6Ly93d3cuc3RhcnRzc2wuY29tL3BvbGlj eS5wZGYwgfcGCCsGAQUFBwICMIHqMCcWIFN0YXJ0Q29tIENlcnRpZmljYXRpb24gQXV0aG9y aXR5MAMCAQEagb5UaGlzIGNlcnRpZmljYXRlIHdhcyBpc3N1ZWQgYWNjb3JkaW5nIHRvIHRo ZSBDbGFzcyAxIFZhbGlkYXRpb24gcmVxdWlyZW1lbnRzIG9mIHRoZSBTdGFydENvbSBDQSBw b2xpY3ksIHJlbGlhbmNlIG9ubHkgZm9yIHRoZSBpbnRlbmRlZCBwdXJwb3NlIGluIGNvbXBs aWFuY2Ugb2YgdGhlIHJlbHlpbmcgcGFydHkgb2JsaWdhdGlvbnMuMDYGA1UdHwQvMC0wK6Ap oCeGJWh0dHA6Ly9jcmwuc3RhcnRzc2wuY29tL2NydHUxLWNybC5jcmwwgY4GCCsGAQUFBwEB BIGBMH8wOQYIKwYBBQUHMAGGLWh0dHA6Ly9vY3NwLnN0YXJ0c3NsLmNvbS9zdWIvY2xhc3Mx L2NsaWVudC9jYTBCBggrBgEFBQcwAoY2aHR0cDovL2FpYS5zdGFydHNzbC5jb20vY2VydHMv c3ViLmNsYXNzMS5jbGllbnQuY2EuY3J0MCMGA1UdEgQcMBqGGGh0dHA6Ly93d3cuc3RhcnRz c2wuY29tLzANBgkqhkiG9w0BAQUFAAOCAQEAB8HJ30IRnmli5Frde4TnF4mgikOiXbYDWYga 5GrFoEUi6aaYOhiv+1WAWh3/d69Ak75p3xPnCmihjjbYeQc3hrVQju6MIpxT8+tBLGa/bwAC yXgWj8idjWdIWMzLxjCPcQb4R2PVmkKTNNE0ZmMFrpSPtRjtRbvWRhxJ0IF7y9z1mLfo6cca RdE5YiKLfAEosMRmrGSfDQKP1NPLmXKWVjPIeS7hpcsM+GJitPOFaLCBibB5ou9b/KphWwdG lby53Oo6vrG9RVy5GZ8xMQ0ztFKVFlXDb7n4j7OfuOo6utQs7UU/sujlw+KWwylIw7Cgmc8t CA1m9c48U7pVoMI5ujGCA90wggPZAgEBMIGUMIGMMQswCQYDVQQGEwJJTDEWMBQGA1UEChMN U3RhcnRDb20gTHRkLjErMCkGA1UECxMiU2VjdXJlIERpZ2l0YWwgQ2VydGlmaWNhdGUgU2ln bmluZzE4MDYGA1UEAxMvU3RhcnRDb20gQ2xhc3MgMSBQcmltYXJ5IEludGVybWVkaWF0ZSBD bGllbnQgQ0ECAwtNUDAJBgUrDgMCGgUAoIICHTAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcB MBwGCSqGSIb3DQEJBTEPFw0xNDEyMTkyMjI5NTlaMCMGCSqGSIb3DQEJBDEWBBR+22VvvmCp +A94Q+dBdVogbCCyDDBsBgkqhkiG9w0BCQ8xXzBdMAsGCWCGSAFlAwQBKjALBglghkgBZQME AQIwCgYIKoZIhvcNAwcwDgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3DQMCAgFAMAcGBSsOAwIH MA0GCCqGSIb3DQMCAgEoMIGlBgkrBgEEAYI3EAQxgZcwgZQwgYwxCzAJBgNVBAYTAklMMRYw FAYDVQQKEw1TdGFydENvbSBMdGQuMSswKQYDVQQLEyJTZWN1cmUgRGlnaXRhbCBDZXJ0aWZp Y2F0ZSBTaWduaW5nMTgwNgYDVQQDEy9TdGFydENvbSBDbGFzcyAxIFByaW1hcnkgSW50ZXJt ZWRpYXRlIENsaWVudCBDQQIDC01QMIGnBgsqhkiG9w0BCRACCzGBl6CBlDCBjDELMAkGA1UE BhMCSUwxFjAUBgNVBAoTDVN0YXJ0Q29tIEx0ZC4xKzApBgNVBAsTIlNlY3VyZSBEaWdpdGFs IENlcnRpZmljYXRlIFNpZ25pbmcxODA2BgNVBAMTL1N0YXJ0Q29tIENsYXNzIDEgUHJpbWFy eSBJbnRlcm1lZGlhdGUgQ2xpZW50IENBAgMLTVAwDQYJKoZIhvcNAQEBBQAEggEAtSohllra XuuH1iDkuh5hnextf2Q78lXhr6Z6LW3jBy1O7lh0eT84ib/PGWMQSFtQzt6hWlJH9CChsS19 QQZNRgntzc557fBs023zIbvH3JR+Yr32jKTHvOvbTZOjWf4rU3B7hn4kcgKKvVd7dkx74eT9 gjNVYGSfQNagHdXCEuXkijvA0SwcBrmT9sU44CMUHS45a7kfza0Qihjxli8Cf3lJTty5ROy+ PdqW9XdFqKhP9Lf/dX1IdCIZ+32Eku7thoSuPs7vO2Di6KjQk5RVDx+EPqcnuBpHo9lFvKfi rAoxx5LoY0ZOGsxBOnDs3h4idzmCqdsBcTPjFp6SZH4glAAAAAAAAA== --------------ms040409080506030800020107-- [View Less]

1 0

Re: (ITS#8009) SUBSTR caseIgnoreIA5SubstringsMatch for *Record in cosine schema
by quanah＠zimbra.com 19 Dec '14

19 Dec '14

--On Friday, December 19, 2014 8:25 PM +0000 michael(a)stroeder.com wrote: > There isn't a new version of the COSINE schema. > > But the attributes defined in RFC 1274, which were not added to RFC 4524 > [1], are used in the usual DNS zone schema which defines object class > 'dNSDomain2'. The DNS zone schema defines more attributes for DNS RRs and > all of them have a SUBSTR matching rule defined. > > If you reject this patch because you don't want to change a "standard"… [View More]

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs December 2014