openldap-bugs February 2009

openldap-bugs@openldap.org

47 participants
298 discussions

(ITS#5937) Apparent mistake in ipv6 address handling in tls.c
by nick.hudson＠isode.com 10 Feb '09

10 Feb '09

Full_Name: nick hudson Version: 2.3.38 OS: linux URL: Submission from: (NULL) (62.3.217.250) I think there is a bug in libraries/libldap/tls.c - specifically in this section: #ifdef LDAP_PF_INET6 if (name[0] == '[' && strchr(name, ']')) { char *n2 = ldap_strdup(name+1); *strchr(n2, ']') = 2; if (inet_pton(AF_INET6, n2, &addr)) ntype = IS_IP6; LDAP_FREE(n2); } else #endif the code is attempting to detect whether part of an LDAP URL represents an IPv6 address; it passes the string to inet_pton(), after removing square brackets. But I think this line: *strchr(n2, ']') = 2; is wrong: shouldn't it be using 0 instead of 2? When testing on my local system, using the code above always results in inet_pton returning 0 (not an IPv6 address) - if I modify the strchr line to use zero instead, then inet_pton returns 1 for valid IPv6 addresses. I may be missing something - "2" seems a peculiar value to use so perhaps it does have some special significance - but I think the code as it stands is incorrect.

1 0

(ITS#5936) test049 uses nonexistant variable SLEEP1
by jclarke＠linagora.com 10 Feb '09

10 Feb '09

Full_Name: Jonathan Clarke Version: RE24 OS: irrelevant URL: http://milopita.phillipoux.net/jonathan-clarke-20090210-test049.patch Submission from: (NULL) (213.41.243.192) test049 complains with: Waiting seconds for syncrepl to receive changes... sleep: missing operator The patch below corrects this. Using 10 seconds as default value, as is done above in the test script for cn=config replication.

1 0

Re: (ITS#5929) 'make test' uses installed libldap_r/liblber
by hyc＠symas.com 10 Feb '09

10 Feb '09

h.b.furuseth(a)usit.uio.no wrote: > Thanks for checking this out. > >> If you want this to work you'll have to provide both the build >> directory and your installed directory in your -rpath. > > Doesn't sound good either. Then I presume the installed binaries may > later use libraries from a test build. Probably. You can of course edit the relink commands in the wrapper to eliminate the build runpath, but it's a lot of manual intervention no matter how you slice it. > >> The symlinks would then help a little, because you only need to set >> one build rpath instead of 3. Go ahead and restore the build rules in >> your source tree to set the symlinks if you want them. At the moment >> it looks like they're not generally useful, and I'm tired of >> committing/reverting, so I'm not touching those files any more today. > > I don't have time for this now either, but I'll hopefully get to it > soon. I wonder if a fix will be to revert the recent libtool upgrade:-( > > Of course it may be that this situation has existed for ages but I only > noticed because of the missing ldap_pvt_search symbol. > The build rules were changed in OL 2.1, it's been like this for ages... -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5929) 'make test' uses installed libldap_r/liblber
by h.b.furuseth＠usit.uio.no 10 Feb '09

10 Feb '09

Thanks for checking this out. > If you want this to work you'll have to provide both the build > directory and your installed directory in your -rpath. Doesn't sound good either. Then I presume the installed binaries may later use libraries from a test build. > The symlinks would then help a little, because you only need to set > one build rpath instead of 3. Go ahead and restore the build rules in > your source tree to set the symlinks if you want them. At the moment > it looks like they're not generally useful, and I'm tired of > committing/reverting, so I'm not touching those files any more today. I don't have time for this now either, but I'll hopefully get to it soon. I wonder if a fix will be to revert the recent libtool upgrade:-( Of course it may be that this situation has existed for ages but I only noticed because of the missing ldap_pvt_search symbol. -- Hallvard

1 0

Re: (ITS#5893) test scripts should stop immediately if slapd crashed
by ando＠sys-net.it 10 Feb '09

10 Feb '09

Howard Chu wrote: > Pierangelo Masarati wrote: >> hyc(a)symas.com wrote: >> >>> I saw that, but it seems that multiple -i options work. >>> -i !xx -i yy >> >> Yes, it works. The test becomes waaaaaay too verbose, though. It'd be >> nicer to have the possibility to limit the error message to the first >> occurrence, when it is intended. > > Yes, I also patched slapd-bind.c in my tree, forgot to mention that: > @@ -344,7 +348,7 @@ > /* if ignore.. */ > if ( first ) { > /* only log if first occurrence */ > - if ( force < 2 || first == 1 ) { > + if ( first == 1 ) { > tester_ldap_error( ld, "ldap_sasl_bind_s", NULL ); > } > rc = LDAP_SUCCESS; I've added another modifier, "*", that makes testers ignore errors and only log the first occurrence. I'm about to commit it. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5893) test scripts should stop immediately if slapd crashed
by hyc＠symas.com 10 Feb '09

10 Feb '09

Pierangelo Masarati wrote: > hyc(a)symas.com wrote: > >> I saw that, but it seems that multiple -i options work. >> -i !xx -i yy > > Yes, it works. The test becomes waaaaaay too verbose, though. It'd be > nicer to have the possibility to limit the error message to the first > occurrence, when it is intended. Yes, I also patched slapd-bind.c in my tree, forgot to mention that: @@ -344,7 +348,7 @@ /* if ignore.. */ if ( first ) { /* only log if first occurrence */ - if ( force < 2 || first == 1 ) { + if ( first == 1 ) { tester_ldap_error( ld, "ldap_sasl_bind_s", NULL ); } rc = LDAP_SUCCESS; -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5893) test scripts should stop immediately if slapd crashed
by ando＠sys-net.it 10 Feb '09

10 Feb '09

hyc(a)symas.com wrote: > I saw that, but it seems that multiple -i options work. > -i !xx -i yy Yes, it works. The test becomes waaaaaay too verbose, though. It'd be nicer to have the possibility to limit the error message to the first occurrence, when it is intended. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by ando＠sys-net.it 10 Feb '09

10 Feb '09

ando(a)sys-net.it wrote: > This won't probably be as easy as I expected: back-meta does not check, > parse or return entry controls. This needs to be fixed as well. My fault: back-meta does. However, something strange is happening: - in some cases, while looping for attribute values, back-meta incorrectly treates entry controls (right after the SearchResultEntry message) as yet another attribute name/values set - in other cases things just go fine I'm trying to modify the code in order to compute the size of the SearchResultEntry portion of the message, but again, in some cases, the size is computed incorrectly: the computed length is 4 octets shorter than what's actually in the packet. One issue seems to be related to the fact that when ber_skip_tag() checks if the length it's computed fits in the ber by calling ber_pvt_ber_remaining(), it doesn't count that earlier calls to ber_read() moved the ber_ptr forward. The original ber_ptr should be saved. I don't believe messages are encoded incorrectly, so I must be doing something wrong in decoding them... p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5613) slapd determines hostname by PTR even if host url defined, breaking ServerID
by hyc＠symas.com 10 Feb '09

10 Feb '09

joe(a)julianfamily.org wrote: > Full_Name: Joe Julian > Version: 2.4.10 > OS: Linux (Fedora 7 distribution) > URL: > Submission from: (NULL) (68.178.24.202) > > > Description of problem: > slapd is called with "-h ldap://ldap1.domain.dom" where ldap1 is a CNAME for > the > actual server name "moe.domain.dom" and "-h ldap://ldap2.domain.dom" for > "curly.domain.dom". > > The cn=config entries for olcServerID are "1 ldap://ldap1.domain.dom" and "2 > ldap://ldap2.domain.dom" > > In config_generic (bconfig.c) case CFG_SERVERID lud->lud_host is compared with > global_host. As the PTR record for moe is moe.domain.dom and not > ldap1.domain.dom, moe does not get assigned a serverID. The same is true for > curly. > Expected results: > the serverID should be selected (in part) based on the "-h" url configuration > matching an olcServerID entry The listener URLs specified with -h are now being compared. The fix is in HEAD, please test. Thanks. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5853) LDAP search crashes when chasing multiple referrals
by hyc＠symas.com 10 Feb '09

10 Feb '09

hyc(a)symas.com wrote: > And yet another approach is simply to bump up each lconn's refcnt, the same > way request.c:ldap_new_connection() does, to prevent them from getting freed > prematurely. This latter approach would be simplest, except it requires > calling ldap_free_connection() to actually decrement the refcnt, and that > requires more mutex manipulation for the libldap_r version. (I haven't looked > too deeply into the lock dependencies yet, it may actually be simpler.) I opted for this approach, now checked into HEAD. Please test. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

← Newer
1
...
16
17
18
19
20
21
22
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs February 2009