openldap-bugs September 2008

openldap-bugs@openldap.org

39 participants
206 discussions

Re: ITS#5713
by ando＠sys-net.it 30 Sep '08

30 Sep '08

Gavin Henry wrote: > ----- ando(a)sys-net.it wrote: > >> Probably, the right fix consists in changing that attr's syntax to >> DirectoryString, and allow all syntaxes, from "--w-------" to passing >> >> the value to strtol(value, NULL, 0) etc. > > Shall we mention the new syntax support in that section of the guide? I'll the man page too. Well, probably yes. Thanks, p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: ITS#5713
by ghenry＠OpenLDAP.org 30 Sep '08

30 Sep '08

----- ando(a)sys-net.it wrote: > Probably, the right fix consists in changing that attr's syntax to > DirectoryString, and allow all syntaxes, from "--w-------" to passing > > the value to strtol(value, NULL, 0) etc. Shall we mention the new syntax support in that section of the guide? I'll the man page too. -- Kind Regards, Gavin Henry. OpenLDAP Engineering Team. E ghenry(a)OpenLDAP.org Community developed LDAP software. http://www.openldap.org/project/

1 0

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by h.b.furuseth＠usit.uio.no 30 Sep '08

30 Sep '08

h.b.furuseth(a)usit.uio.no writes: > Replace ldap_utf8_strchr with ldap_utf8_strpbrk and it should work. ..and come to think of, it, the *s non-null test in the for loop should be unnecessary. -- Hallvard

1 0

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by hyc＠symas.com 30 Sep '08

30 Sep '08

h.b.furuseth(a)usit.uio.no wrote: > quanah(a)OpenLDAP.org writes: >> utf-8.c:char * (ldap_utf8_strchr)( const char *str, const char *chr ) >> >> I.e., string, character, as normal libc functions. >> >> However, at line 125 in charray.c, it is called as: >> if ( ldap_utf8_strchr( brkstr, s ) != NULL ) { >> This order appears to be incorrect. > No. That code counts the number of delimiters characters in the > string being split. Since brkstr can contain several characters, > the loop checks each "utf-8 character" in str against brkstr. The code was certainly broken, regardless. If the input string uses any UTF8 characters beyond 0x7f then the simple increment of "s++" would yield invalid characters for most of the iterations of the loop. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by h.b.furuseth＠usit.uio.no 30 Sep '08

30 Sep '08

Duh, perhaps I should have paid attention to the committed patch instead of your description of the problem... The patch breaks in a different way than I said. Replace ldap_utf8_strchr with ldap_utf8_strpbrk and it should work. I probably can't test it today. -- Hallvard

1 0

ITS#5695
by tamburo＠studenti.unina.it 30 Sep '08

30 Sep '08

This is the rights statement for my patch. This is the link http://www.studenti.unina.it/~tamburo/tesi/openldap/Luca-Tamburo-AC-08-09-1… to my patch with the following rights statement. This patch file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Luca Tamburo at ICAR, Branch of Naples, Italy. Luca Tamburo has not assigned rights and/or interest in this work to any party. I, Luca Tamburo am authorized by Giovanni Schmid, project manager at ICAR, my employer, to release this work under the following terms. Copyright 2008 Luca Tamburo tamburo(a)studenti.unina.it Redistribution and use in source and binary forms, with or without modification, are permitted only as authorized by the OpenLDAP Public License. Regards, Luca ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.

1 0

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by quanah＠zimbra.com 30 Sep '08

30 Sep '08

--On September 30, 2008 6:20:58 PM +0000 h.b.furuseth(a)usit.uio.no wrote: > quanah(a)zimbra.com writes: >> Yes. The calling order was incorrect. It is supposed to be >> ldap_utf8_strchr(s, brkstr). > > No. Try this with the new code: > env LDAPHOST='host1 host2' valgrind clients/tools/ldapwhoami -x > It returns writes past malloced areas in ldap_str2charray(). > > options.c calls ldap_charray("host1 host2", ", ") to parse that. > It counted the number of commas and spaces in the host string. > With the new code, it instead sums up: > > number of commas in "host1 host2" > + number of commas in "ost1 host2" > + number of commas in "st1 host2" > > etc and you never count spaces. So, the solution is to revert the order of the call, but leave the loop the way it is now? --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Re: ITS#5707 [Fwd: Re: 4.7.25 deadlock]
by quanah＠zimbra.com 30 Sep '08

30 Sep '08

--On September 30, 2008 6:13:05 PM +0000 quanah(a)zimbra.com wrote: > I think their patch is broken. I rebuilt BDB 4.7 with it, and now > test008 fails on me: Never mind, test008 fails without the patch to BDB 4.7 as well, so it's not related. test008 simply no longer works for me with current RE24. --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Re: (ITS#5720) ldap_str2charray calls ldap_utf8_strchr incorrectly
by h.b.furuseth＠usit.uio.no 30 Sep '08

30 Sep '08

quanah(a)zimbra.com writes: > Yes. The calling order was incorrect. It is supposed to be > ldap_utf8_strchr(s, brkstr). No. Try this with the new code: env LDAPHOST='host1 host2' valgrind clients/tools/ldapwhoami -x It returns writes past malloced areas in ldap_str2charray(). options.c calls ldap_charray("host1 host2", ", ") to parse that. It counted the number of commas and spaces in the host string. With the new code, it instead sums up: number of commas in "host1 host2" + number of commas in "ost1 host2" + number of commas in "st1 host2" etc and you never count spaces. > Also the outside loop was incorrect. True. -- Hallvard

1 0

Re: ITS#5707 [Fwd: Re: 4.7.25 deadlock]
by quanah＠zimbra.com 30 Sep '08

30 Sep '08

I think their patch is broken. I rebuilt BDB 4.7 with it, and now test008 fails on me: bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") <= bdb_dn2id: get failed: DB_LOCK_NOTGRANTED: Lock not granted (-30993) bdb_dn2entry("cn=james a jones 4,ou=people,dc=example,dc=com") => bdb_dn2id("cn=james a jones 4,ou=people,dc=example,dc=com") --Quanah > --On September 26, 2008 6:27:45 AM +0000 hyc(a)symas.com wrote: > >> So I guess we have to warn people about this one ourselves for a while. >> >> -------- Original Message -------- >> Subject: Re: 4.7.25 deadlock >> Date: Thu, 25 Sep 2008 23:15:31 -0700 >> From: Michael Ubell <@oracle.com> >> To: Howard Chu <hyc(a)symas.com> >> >> Howard, >> >> Generally we only post critical patches (data corruption, etc) to the >> web site. Since this one only effects those using user defined locks >> and does no damage, I don't think it will be posted. >> >> Mike >> >> >> -- >> -- Howard Chu >> CTO, Symas Corp. http://www.symas.com >> Director, Highland Sun http://highlandsun.com/hyc/ >> Chief Architect, OpenLDAP http://www.openldap.org/project/ >> >> > > > > -- > > Quanah Gibson-Mount > Principal Software Engineer > Zimbra, Inc > -------------------- > Zimbra :: the leader in open source messaging and collaboration > > -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs September 2008