openldap-bugs

openldap-bugs@openldap.org

1 participants
21003 discussions

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by rhafer＠suse.de 08 Nov '07

08 Nov '07

On Donnerstag, 8. November 2007, you wrote: > <quote who="Ralf Haferkamp"> > > > On Donnerstag, 8. November 2007, rhafer(a)suse.de wrote: > >> I think I found a way. > >> 1. The SLAPD_ABANDON/op->o_abandon part of the cleanup handler will now > >> only get executed if the final result for the search has not been > >> received > >> (caching_reason == PC_IGNORE). > >> 2. Additionally, to add the entries to the cache, I do no longer use the > >> original Connection Object but create a new one > >> (connection_fake_init()), > >> because the op->o_abandon will be set for the original connection as > >> soon > >> as the client closes it. > >> > >> I'll do some more testing locally an submit this to HEAD later for more > >> external testing. > > > > Fix submitted to HEAD. Please test (preferably on the machine that caused > > this > > test to fail most often ;) ). > > I'll try this tonight. > > Just to clarify, this is a fix in the code, rather than the test, which I > thought Howard had changed? Yes, it is a fix in the pcache code. The fix in the testcase was only done temporarely in the RE24 branch (HEAD was not changed). I intend to remove it as soon as I get positive feedback. -- Ralf

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by ghenry＠OpenLDAP.org 08 Nov '07

08 Nov '07

<quote who="Ralf Haferkamp"> > On Donnerstag, 8. November 2007, rhafer(a)suse.de wrote: >> I think I found a way. >> 1. The SLAPD_ABANDON/op->o_abandon part of the cleanup handler will now >> only get executed if the final result for the search has not been >> received >> (caching_reason == PC_IGNORE). >> 2. Additionally, to add the entries to the cache, I do no longer use the >> original Connection Object but create a new one >> (connection_fake_init()), >> because the op->o_abandon will be set for the original connection as >> soon >> as the client closes it. >> >> I'll do some more testing locally an submit this to HEAD later for more >> external testing. > Fix submitted to HEAD. Please test (preferably on the machine that caused > this > test to fail most often ;) ). I'll try this tonight. Just to clarify, this is a fix in the code, rather than the test, which I thought Howard had changed? > > -- > Ralf >

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by rhafer＠suse.de 08 Nov '07

08 Nov '07

On Donnerstag, 8. November 2007, rhafer(a)suse.de wrote: > I think I found a way. > 1. The SLAPD_ABANDON/op->o_abandon part of the cleanup handler will now > only get executed if the final result for the search has not been received > (caching_reason == PC_IGNORE). > 2. Additionally, to add the entries to the cache, I do no longer use the > original Connection Object but create a new one (connection_fake_init()), > because the op->o_abandon will be set for the original connection as soon > as the client closes it. > > I'll do some more testing locally an submit this to HEAD later for more > external testing. Fix submitted to HEAD. Please test (preferably on the machine that caused this test to fail most often ;) ). -- Ralf

1 0

RE: (ITS#5215) Use of ln is hardcoded in some files
by h.b.furuseth＠usit.uio.no 08 Nov '07

08 Nov '07

emmanuel.duru(a)atosorigin.com writes: > Then with MSYS, I get an error when running make on servers/slapd > Makefile: in case there is no extra LDFLAG, (...) Try this patch: --- servers/slapd/Makefile.in~ 2007-02-14 16:59:43.000000000 +0100 +++ servers/slapd/Makefile.in 2007-11-08 15:40:32.475898000 +0100 @@ -157,3 +157,3 @@ slapd.def: libbackends.a liboverlays.a version.o - @for i in $(LDFLAGS) ; do \ + @for i in XX $(LDFLAGS) ; do \ path=`expr "$$i" : "-L$.*$"`; \ @@ -169,3 +169,4 @@ base=`expr "$$i" : "-l$.*$"`; \ - for p in $$paths ; do \ + for p in " " $$paths ; do \ + test "x$$p" = "x " && continue ; \ for ext in la dll dll.a a ; do \ -- Regards, Hallvard

1 0

Re: ITS#5212 command that caused the crash
by hyc＠symas.com 08 Nov '07

08 Nov '07

tonni(a)hetnet.nl wrote: > Howard Chu skrev, on 07-11-2007 04:14: >> That's all we needed. Fixed now in HEAD. > > Do you happen to have a patch handy? I don't feel like waiting for > 2.4.7, this is the only serious bug I've found to date with 2.4.6. http://www.openldap.org/lists/openldap-commit/200711/msg00010.html -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

RE: (ITS#5215) Use of ln is hardcoded in some files
by emmanuel.duru＠atosorigin.com 08 Nov '07

08 Nov '07

OK, forget about my remark on Cygwin/MinGW. However, you should update the "Porting OpenLDAP" FAQ to mention MSYS. Then with MSYS, I get an error when running make on servers/slapd Makefile: in case there is no extra LDFLAG, the lines @for i in $(LDFLAGS) ; do \ path=`expr "$$i" : "-L$.*$"`; \ if test $$? != 0; then continue; fi; \ paths="$$paths $$path"; \ done; \ cause a sh error: "syntax error near unexpected token ';'" -----Message d'origine----- De : Howard Chu [mailto:hyc@symas.com] Envoyé : mercredi 7 novembre 2007 04:08 À : emmanuel.duru(a)atosorigin.com Cc : openldap-its(a)openldap.org Objet : Re: (ITS#5215) Use of ln is hardcoded in some files emmanuel.duru(a)atosorigin.com wrote: > Full_Name: Emmanuel Duru > Version: 2.3.38 > OS: Windows > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (195.68.44.148) > > > configure allows the use of "cp" instead of "ln", but the build/shtool tool uses > a hardcoded "ln" (line 1266). > Some makefiles (libraries/liblunicode, libraries/libldap_r and > servers/slapd/back-hdb) use a hardcoded "-s" option. This is a problem on > Windows because in cygwin environment "cp -s" behaves the same way as "ln -s". > The use of "ln" is not welcome here because it creates a Windows shortcut, which > is not understood by mingw compiler. We only support the MSYS build environment on Windows. If you'd like to submit a patch to address this issue that doesn't break the other platforms, we can look at incorporating it. -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5187) test020-proxycache failing in RE_2_4
by rhafer＠suse.de 08 Nov '07

08 Nov '07

On Dienstag, 6. November 2007, rhafer(a)suse.de wrote: > I think I have an idea what causes this bug. It is possible that the client > closes the connection before the server had a chance to run the cleanup > handler, the server sets op->o_abandon then (in connection_closing()). And > after that the cleanup handler is started, which in case of op->o_abandon > does not store the results in the cache. > > To make this race more reproduceable it is sufficient to insert a > usleep(100) before the call to slap_cleanup_play() in send_ldap_response() > in result.c. > > Any suggestions for possible ways to fix this? I think I found a way. 1. The SLAPD_ABANDON/op->o_abandon part of the cleanup handler will now only get executed if the final result for the search has not been received (caching_reason == PC_IGNORE). 2. Additionally, to add the entries to the cache, I do no longer use the original Connection Object but create a new one (connection_fake_init()), because the op->o_abandon will be set for the original connection as soon as the client closes it. I'll do some more testing locally an submit this to HEAD later for more external testing. -- Ralf

1 0

Re: ITS#5212 command that caused the crash
by tonni＠hetnet.nl 07 Nov '07

07 Nov '07

Howard Chu skrev, on 07-11-2007 04:14: >> > That's all very interesting, but you haven't provided the standard >> > items needed in a crash report - a stack trace from the crash, >> >> Yes I have, but later than your reply on the ITS site. >> >> > and the actual client command that caused the crash. Also, the slapd >> > configuration, plus any relevant schema if you've used any custom >> > schema in relation to this failing command. >> >> Other details: >> >> Command: >> >> ldapsearch2.4 -x -D "cn=admin,dc=billy,dc=demon,dc=nl" -w secret >> 'facsimileTelephoneNumber=+4753491111' facsimile TelephoneNumber > > That's all we needed. Fixed now in HEAD. Do you happen to have a patch handy? I don't feel like waiting for 2.4.7, this is the only serious bug I've found to date with 2.4.6. ..Tonni -- Tony Earnshaw Email: tonni at hetnet dot nl

1 0

Re: (ITS#5224) liblber Makefile misses some libraries
by richton＠nbcs.rutgers.edu 07 Nov '07

07 Nov '07

Note for reference, shutdown() is not called directly but rather via autoconf tcp_close() macro.

1 0

Re: (ITS#5216) Dynamic Lists doc contribution to the admin guide
by ghenry＠suretecsystems.com 07 Nov '07

07 Nov '07

Is the disclaimer ok? Can I commit the patch?

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs