openldap-bugs

openldap-bugs@openldap.org

1 participants
21000 discussions

Re: (ITS#6620) ppolicy: pwdChangedTime/userPassword delete issue.
by h.b.furuseth＠usit.uio.no 06 Dec '10

06 Dec '10

hyc(a)symas.com writes: > See the definition of pwdChangedTime, section 5.3.2: Duh, I misread what you said. In any case, it's a separate issue. That's about slapd expiring the passwor, this patch is about the user deleting it. -- Hallvard

1 0

(ITS#6739) broken do_syncrep2()
by h.b.furuseth＠usit.uio.no 06 Dec '10

06 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard slapd/syncrepl.c:do_syncrep2() initializes many variables once which should have been initialized inside the loop. I'll add the initializations I can figure out, and move most variables into the loop for readability. TODO: Variables 'm' and 'refreshDeletes' may still be wrong. In particular 'm'. It "feels" like it should be local to the loop, but there's no logic that I can see to prevent previous value from being used. Perhaps they depend on the peer not breaking the sync protocol? I haven't read that myself, I'm just peering at the code. I've added three somewhat arbitrary bits of code for error handling: - A Debug() statement on line 847 which can likely be improved. - Set err and rc to LDAP_OTHER on ldap_parse_result/ldap_get_option failure. The correct fix would be proper error checks (ITS#6738), but I don't know what to do on error.

1 0

Re: (ITS#6737) slapmodify strangeness
by masarati＠aero.polimi.it 06 Dec '10

06 Dec '10

> Full_Name: Hallvard B Furuseth > Version: HEAD > OS: > URL: > Submission from: (NULL) (129.240.6.233) > Submitted by: hallvard > > > 'sid' in slapmodify.c is read uninitialized before it is written, at line > 693: > > if ( rc == EXIT_SUCCESS && update_ctxcsn && !dryrun && sid != > SLAP_SYNC_SID_MAX > + 1 ) { > > A loop _below_ that statement can set sid to the expected value: > > for ( sid = 0; sid <= SLAP_SYNC_SID_MAX; sid++ ) > > Also slapmodify sets up but does not use variables opbuf and op. slapdmodify(8) is the (nearly untested) result of non negligible cut'n'paste. p.

1 0

(ITS#6738) missing checks for ber errors
by h.b.furuseth＠usit.uio.no 06 Dec '10

06 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard There are a fair number of ber calls which do not check for errors: Just ber_scanf and use the expected output variable, which may or may not have a useful NULL value on error. Syncrepl is particularly bad. This in slapd/ and libldap/: egrep '^<tab>*ber_(scanf|get_)' *.c */*.c returns mostly syncrepl matches. I can't even fix these easily because there's not enough error handling code to copy. grepping for ber_(printf|put_) find other modules as well.

1 0

(ITS#6737) slapmodify strangeness
by h.b.furuseth＠usit.uio.no 05 Dec '10

05 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard 'sid' in slapmodify.c is read uninitialized before it is written, at line 693: if ( rc == EXIT_SUCCESS && update_ctxcsn && !dryrun && sid != SLAP_SYNC_SID_MAX + 1 ) { A loop _below_ that statement can set sid to the expected value: for ( sid = 0; sid <= SLAP_SYNC_SID_MAX; sid++ ) Also slapmodify sets up but does not use variables opbuf and op.

1 0

(ITS#6736) Listener info destroyed too early on shutdown
by h.b.furuseth＠usit.uio.no 05 Dec '10

05 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard On shutdown, slapd_daemon_task() calls close_listeners() which destroys slap_listeners[] while other threads may be accessing it. This is not mutex-protected. Valgrind reports freed data accesses in back-monitor and slapd_listener() when they try to read the URLs in the listeners. Giving HEAD a minimal fix: Stop listening but delay destruction. If anyone feels like it, the new 'listening' flag probably can be used more intelligently, e.g. by rearranging the use of it and some shutdown flags.

1 0

(ITS#6735) Uninitialized filter in slapd-tester
by h.b.furuseth＠usit.uio.no 04 Dec '10

04 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (129.240.6.233) Submitted by: hallvard rflts[jj] can be used uninitialized at slapd-tester.c:875. Fixing.

1 0

Re: (ITS#6727) ./scripts/test047-ldap: line 599: 26709 Segmentation fault
by michael＠stroeder.com 04 Dec '10

04 Dec '10

masarati(a)aero.polimi.it wrote: > h.b.furuseth(a)usit.uio.no wrote: >> Hopefully fixed with the latest ITS#6632/6720 commits. > > You mean ITS#6727, I guess. I fixed ITS#6720 (rwm.c 1.132 -> 1.133), > it looked unrelated. For me, ITS#6727 is now fixed with your patch. > Can you confirm, Michael? 30 test iterations without problems. Seems to be fixed now. Ciao, Michael.

1 0

(ITS#6734) Implment delta-sync based MMR
by quanah＠OpenLDAP.org 03 Dec '10

03 Dec '10

Full_Name: Quanah Gibson-Mount Version: 2.4.23 OS: NA URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (75.111.45.108) To help resolve ITS#6097, it would be helpful to have delta-sync MMR available. I'm mainly filing this bug for tracking.

1 0

Re: (ITS#6620) ppolicy: pwdChangedTime/userPassword delete issue.
by hyc＠symas.com 03 Dec '10

03 Dec '10

Hallvard B Furuseth wrote: > Howard Chu writes: >> h.b.furuseth(a)usit.uio.no wrote: >>> Thanks. Applied a similar patch to cvs HEAD, after fixing a memory leak. >>> >>> Reproducing the bug: >>> >>> userPassword can exist without pwdChangedTime if you bypass >>> ppolicy: Use slapadd to add an entry with userPassword, or add >>> it to a subtree with no policy and then configure a policy. >>> >>> Then set up ppolicy and use ldapmodify to delete userPassword. >> >> In that case the correct fix is to skip the pwdChangedTime attribute >> completely. > > Well, that's what this fix does in this particular code chunk: > Don't try to delete pwdChangedTime if it isn't there. > >> The ppolicy spec says that entries without pwdChangedTime are not >> subject to password expiration at all. > > Sounds like a different issue, but I don't see where it says that. > What I did find is > > 8.2.7. Policy State Updates > > If the value of either pwdMaxAge or pwdMinAge is non-zero, the server > updates the pwdChangedTime attribute on the entry to the current > time. > See the definition of pwdChangedTime, section 5.3.2: 5.3.2. pwdChangedTime This attribute specifies the last time the entry's password was changed. This is used by the password expiration policy. If this attribute does not exist, the password will never expire. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs