On 4/10/19 10:13 AM, Quanah Gibson-Mount wrote:
It should be done in a similar way as the OpenLDAP project:
a) A LICENSE file in the root of the repository
b) A comment at the start of each file of code that states the following:
Thanks. I've added it to the repo and source files.
https://github.com/DFMCH/pw-duo
Most of what I needed to do I gleaned from the OpenLDAP sources. Not
sure about some of it. Some things I wonder about:
* Is ber_memalloc() the preferred way to allocate memory?
* call read_duo_keys() only once instead of every auth?
* some modules use ldap_pvt_thread_mutex_lock/unlock() and some don't.
What determines usage?
* Increasing wait time for MFA (deferring operation: binding)?
If anyone can offer feedback it would be appreciated.