On Sep 29, 2021, at 8:09 PM, Howard Chu hyc@symas.com wrote:
Quanah Gibson-Mount wrote:
--On Thursday, September 30, 2021 12:53 AM +0100 Howard Chu hyc@symas.com wrote:
Nick Folino wrote:
Yes. Logging now continues to work after changes to config.
But - adding levels works on the fly, but removing them doesn't. For instance this works fine: olcLogLevel: stats
If I change it to "stats ACL" then the ACL data starts getting added to the log. No restart required. If I change it back to "stats" I keep getting ACL data until the directory is restarted.
That's the normal way it has always worked. If you want to remove flags, you must first explicitly set it to zero, and then set your desired level in a subsequent Modify request.
That is not the behavior I see in 2.4 or 2.5:
The code has been like that since 2007.
dda5e199043 (Howard Chu 2007-05-05 01:22:29 +0000 4038) /* Explicitly setting a zero clears all the levels */ dda5e199043 (Howard Chu 2007-05-05 01:22:29 +0000 4039) if ( level ) dda5e199043 (Howard Chu 2007-05-05 01:22:29 +0000 4040) config_syslog |= level; dda5e199043 (Howard Chu 2007-05-05 01:22:29 +0000 4041) else dda5e199043 (Howard Chu 2007-05-05 01:22:29 +0000 4042) config_syslog = 0;
-- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
This is not the way it works for loglevel, is the point. The current behavior is a regression vs 2.5 and 2.4.