Quanah Gibson-Mount pushed to branch OPENLDAP_REL_ENG_2_6 at openldap / OpenLDAP

Commits: 85e2c3fb by Ondřej Kuzník at 2023-04-17T18:42:12+00:00 ITS#9990 Preserve callbacks added already

- - - - - d59ee405 by Quanah Gibson-Mount at 2023-04-17T18:42:55+00:00 ITS#9990

- - - - - 70c7b2e9 by Howard Chu at 2023-04-17T18:44:10+00:00 ITS#9993 fix online_indexer termination/cleanup

- - - - - ff464105 by Quanah Gibson-Mount at 2023-04-17T18:44:34+00:00 ITS#9993

- - - - - eac40944 by Sam James at 2023-04-17T18:48:15+00:00 ITS#10011 build: fix compatibility with stricter C99 compilers

Fix the following warnings: - -Wimplicit-int (fatal with Clang 16) - -Wimplicit-function-declaration (fatal with Clang 16) - -Wincompatible-function-pointer-types (fatal with Clang 16) - -Wint-conversion (fatal with Clang 15) - Old style prototypes (K&R, removed from C23)

These warnings-now-error led to misconfigurations and failure to build OpenLDAP, as the tests used during configure caused the wrong results to be emitted.

For more information, see LWN.net [0] or LLVM's Discourse [1], the Gentoo wiki [2], or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/ [1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-i... [2] https://wiki.gentoo.org/wiki/Modern_C_porting [3] hosted at lists.linux.dev.

Bug: https://bugs.gentoo.org/871288 Signed-off-by: Sam James <sam@gentoo.org>

- - - - - 965bfbb2 by Sam James at 2023-04-17T18:48:23+00:00 ITS#10011 contrib: fix old-style K&R declarations

Removed in C23.

For more information, see LWN.net [0] or LLVM's Discourse [1], the Gentoo wiki [2], or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/ [1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-i... [2] https://wiki.gentoo.org/wiki/Modern_C_porting [3] hosted at lists.linux.dev.

Signed-off-by: Sam James <sam@gentoo.org>

- - - - - 58b6c59c by Sam James at 2023-04-17T18:48:29+00:00 ITS#10011 servers: fix -Wstrict-prototypes

For more information, see LWN.net [0] or LLVM's Discourse [1], the Gentoo wiki [2], or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/ [1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-i... [2] https://wiki.gentoo.org/wiki/Modern_C_porting [3] hosted at lists.linux.dev.

Signed-off-by: Sam James <sam@gentoo.org>

- - - - - a77da644 by Quanah Gibson-Mount at 2023-04-17T18:50:20+00:00 ITS#10011

- - - - - df8ca49a by Quanah Gibson-Mount at 2023-04-24T18:14:35+00:00 ITS#10011 - Regenerate configure

- - - - - a9f0a885 by Дилян Палаузов at 2023-04-24T18:46:49+00:00 ITS#9989 Keep .pc files on «make clean»

- - - - - 2f73f401 by Quanah Gibson-Mount at 2023-04-24T18:47:09+00:00 ITS#9989

- - - - - 4a35c30e by Howard Chu at 2023-04-26T16:39:26+00:00 ITS#9995 ldapdelete: plug potential search leak

- - - - - 295b1e97 by Quanah Gibson-Mount at 2023-04-26T16:42:35+00:00 ITS#9995

- - - - - 21b99578 by Howard Chu at 2023-04-26T16:43:18+00:00 ITS#9996 librewrite plug potential leak in ldapmap map_ldap_apply()

- - - - - e0cbb825 by Quanah Gibson-Mount at 2023-04-26T16:43:25+00:00 ITS#9996

- - - - - b8e302f9 by Howard Chu at 2023-04-26T16:44:01+00:00 ITS#9997 syncrepl: plug potential leak in changelog search

Note this is only used with changelog, which is nonstandard and obsolete.

- - - - - dd7f6bfd by Quanah Gibson-Mount at 2023-04-26T16:44:11+00:00 ITS#9997

- - - - - c02f322b by Howard Chu at 2023-04-26T17:30:45+00:00 ITS#9998 slapd-mtread: plug potential leak

- - - - - 2b178d55 by Quanah Gibson-Mount at 2023-04-26T17:30:55+00:00 ITS#9998

- - - - - 48ce1b21 by Howard Chu at 2023-04-26T17:31:24+00:00 ITS#9999 slapd-search: plug potential leak

- - - - - 7d4c1dfb by Quanah Gibson-Mount at 2023-04-26T17:31:47+00:00 ITS#9999

- - - - - 44b20287 by Howard Chu at 2023-04-26T17:31:59+00:00 ITS#10000 slapd-watcher: plug potential leak

- - - - - 2b3d3338 by Quanah Gibson-Mount at 2023-04-26T17:32:06+00:00 ITS#10000

- - - - - 6f2e0685 by Howard Chu at 2023-04-26T17:32:32+00:00 ITS#10003: ldap_open_internal_connection: fix mutex usage

Note: this is a non-standard function with no use cases

- - - - - dcfe0d4c by Quanah Gibson-Mount at 2023-04-26T17:32:38+00:00 ITS#10003

- - - - - 0e0bd886 by Howard Chu at 2023-04-26T17:32:59+00:00 ITS#10004: librewrite: plug potential ld leak in ldapmap

- - - - - 9136e91a by Quanah Gibson-Mount at 2023-04-26T17:33:07+00:00 ITS#10004

- - - - - 3e2404ee by Ondřej Kuzník at 2023-04-26T20:08:25+00:00 ITS#9953 Check for push replication

- - - - - 38d1e36e by Quanah Gibson-Mount at 2023-04-27T15:03:02+00:00 ITS#9953

- - - - - af3f6f14 by Howard Chu at 2023-04-27T15:04:45+00:00 ITS#10015 libldap: fix KEEPALIVE opts from ITS#9490

- - - - - 82c41b29 by Quanah Gibson-Mount at 2023-04-27T15:05:37+00:00 ITS#10015

- - - - - 0410c80e by Howard Chu at 2023-04-27T15:09:45+00:00 ITS#10016: slapo-syncprov: fix Abandon with active qtask

- - - - - 5d33a984 by Quanah Gibson-Mount at 2023-04-27T15:10:21+00:00 ITS#10016

- - - - - f12d6c04 by HAMANO Tsukasa at 2023-04-27T15:11:14+00:00 ITS#10028 - crash with pwdMinDelay

- - - - - cec9bdff by Quanah Gibson-Mount at 2023-04-27T15:12:01+00:00 ITS#10028

- - - - - 99cc55d6 by Ondřej Kuzník at 2023-04-27T15:12:39+00:00 ITS#10031 Adjust *err if we free it

- - - - - ea590bb2 by Quanah Gibson-Mount at 2023-04-27T15:13:55+00:00 ITS#10031

- - - - -

26 changed files:

- CHANGES - Makefile.in - aclocal.m4 - build/lib.mk - build/openldap.m4 - clients/tools/ldapdelete.c - configure - configure.ac - contrib/ldaptcl/tclAppInit.c - contrib/ldaptcl/tkAppInit.c - contrib/slapd-modules/variant/variant.c - libraries/libldap/init.c - libraries/libldap/open.c - libraries/librewrite/ldapmap.c - servers/slapd/at.c - servers/slapd/back-mdb/config.c - servers/slapd/overlays/constraint.c - servers/slapd/overlays/ppolicy.c - servers/slapd/overlays/syncprov.c - servers/slapd/overlays/unique.c - servers/slapd/passwd.c - servers/slapd/syncrepl.c - servers/slapd/syslog.c - tests/progs/slapd-mtread.c - tests/progs/slapd-search.c - tests/progs/slapd-watcher.c

View it on GitLab: https://git.openldap.org/openldap/openldap/-/compare/9100a73bdf7b44d4d7b2a2f...