Quanah Gibson-Mount pushed to branch OPENLDAP_REL_ENG_2_5 at openldap / OpenLDAP

Commits: 2e79e2d0 by Ondřej Kuzník at 2023-04-17T18:43:26+00:00 ITS#9990 Preserve callbacks added already

- - - - - 3582adc3 by Quanah Gibson-Mount at 2023-04-17T18:43:44+00:00 ITS#9990

- - - - - 4a9aaf7c by Sam James at 2023-04-17T18:48:40+00:00 ITS#10011 build: fix compatibility with stricter C99 compilers

Fix the following warnings: - -Wimplicit-int (fatal with Clang 16) - -Wimplicit-function-declaration (fatal with Clang 16) - -Wincompatible-function-pointer-types (fatal with Clang 16) - -Wint-conversion (fatal with Clang 15) - Old style prototypes (K&R, removed from C23)

These warnings-now-error led to misconfigurations and failure to build OpenLDAP, as the tests used during configure caused the wrong results to be emitted.

For more information, see LWN.net [0] or LLVM's Discourse [1], the Gentoo wiki [2], or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/ [1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-i... [2] https://wiki.gentoo.org/wiki/Modern_C_porting [3] hosted at lists.linux.dev.

Bug: https://bugs.gentoo.org/871288 Signed-off-by: Sam James <sam@gentoo.org>

- - - - - ca22c4d9 by Sam James at 2023-04-17T18:48:45+00:00 ITS#10011 contrib: fix old-style K&R declarations

Removed in C23.

For more information, see LWN.net [0] or LLVM's Discourse [1], the Gentoo wiki [2], or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/ [1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-i... [2] https://wiki.gentoo.org/wiki/Modern_C_porting [3] hosted at lists.linux.dev.

Signed-off-by: Sam James <sam@gentoo.org>

- - - - - 139effd7 by Sam James at 2023-04-17T18:48:49+00:00 ITS#10011 servers: fix -Wstrict-prototypes

For more information, see LWN.net [0] or LLVM's Discourse [1], the Gentoo wiki [2], or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/ [1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-i... [2] https://wiki.gentoo.org/wiki/Modern_C_porting [3] hosted at lists.linux.dev.

Signed-off-by: Sam James <sam@gentoo.org>

- - - - - 076063c2 by Quanah Gibson-Mount at 2023-04-24T18:45:40+00:00 ITS#10011 - Regenerate configure

- - - - - f0599010 by Quanah Gibson-Mount at 2023-04-24T18:45:53+00:00 ITS#10011

- - - - - ad9db644 by Дилян Палаузов at 2023-04-24T18:47:17+00:00 ITS#9989 Keep .pc files on «make clean»

- - - - - bc7c267f by Quanah Gibson-Mount at 2023-04-24T18:47:27+00:00 ITS#9989

- - - - - 81693599 by Howard Chu at 2023-04-26T16:42:43+00:00 ITS#9995 ldapdelete: plug potential search leak

- - - - - f85b2d08 by Howard Chu at 2023-04-26T16:43:40+00:00 ITS#9996 librewrite plug potential leak in ldapmap map_ldap_apply()

- - - - - 10c5964b by Quanah Gibson-Mount at 2023-04-26T16:43:49+00:00 ITS#9996

- - - - - 4fadc968 by Howard Chu at 2023-04-26T16:44:21+00:00 ITS#9997 syncrepl: plug potential leak in changelog search

Note this is only used with changelog, which is nonstandard and obsolete.

- - - - - 86e029fd by Quanah Gibson-Mount at 2023-04-26T16:44:30+00:00 ITS#9997

- - - - - b7241ced by Howard Chu at 2023-04-26T17:31:01+00:00 ITS#9998 slapd-mtread: plug potential leak

- - - - - 67e33964 by Quanah Gibson-Mount at 2023-04-26T17:31:08+00:00 ITS#9998

- - - - - 85c109af by Howard Chu at 2023-04-26T17:31:34+00:00 ITS#9999 slapd-search: plug potential leak

- - - - - 641ab45b by Quanah Gibson-Mount at 2023-04-26T17:31:39+00:00 ITS#9999

- - - - - 968deaf9 by Howard Chu at 2023-04-26T17:32:14+00:00 ITS#10000 slapd-watcher: plug potential leak

- - - - - 6465bece by Quanah Gibson-Mount at 2023-04-26T17:32:20+00:00 ITS#10000

- - - - - 4aacc755 by Howard Chu at 2023-04-26T17:32:45+00:00 ITS#10003: ldap_open_internal_connection: fix mutex usage

Note: this is a non-standard function with no use cases

- - - - - 0b8ed1bc by Quanah Gibson-Mount at 2023-04-26T17:32:49+00:00 ITS#10003

- - - - - b180a1e2 by Howard Chu at 2023-04-26T17:33:14+00:00 ITS#10004: librewrite: plug potential ld leak in ldapmap

- - - - - 379f21e8 by Quanah Gibson-Mount at 2023-04-26T17:33:19+00:00 ITS#10004

- - - - - a25124dc by Ondřej Kuzník at 2023-04-26T20:10:16+00:00 ITS#9953 Check for push replication

- - - - - c904ec6c by Quanah Gibson-Mount at 2023-04-27T15:03:17+00:00 ITS#9953

- - - - - 64eb6c34 by Howard Chu at 2023-04-27T15:05:46+00:00 ITS#10015 libldap: fix KEEPALIVE opts from ITS#9490

- - - - - 055e7056 by Quanah Gibson-Mount at 2023-04-27T15:06:02+00:00 ITS#10015

- - - - - a4ec923f by Howard Chu at 2023-04-27T15:10:27+00:00 ITS#10016: slapo-syncprov: fix Abandon with active qtask

- - - - - d9919c16 by Quanah Gibson-Mount at 2023-04-27T15:10:43+00:00 ITS#10016

- - - - - e765972f by HAMANO Tsukasa at 2023-04-27T15:12:11+00:00 ITS#10028 - crash with pwdMinDelay

- - - - - 04f2b9a8 by Quanah Gibson-Mount at 2023-04-27T15:12:25+00:00 ITS#10028

- - - - - c3cc9289 by Ondřej Kuzník at 2023-04-27T15:14:02+00:00 ITS#10031 Adjust *err if we free it

- - - - - 9fda4843 by Quanah Gibson-Mount at 2023-04-27T15:14:18+00:00 ITS#10031

- - - - -

25 changed files:

- CHANGES - Makefile.in - aclocal.m4 - build/lib.mk - build/openldap.m4 - clients/tools/ldapdelete.c - configure - configure.ac - contrib/ldaptcl/tclAppInit.c - contrib/ldaptcl/tkAppInit.c - contrib/slapd-modules/variant/variant.c - libraries/libldap/init.c - libraries/libldap/open.c - libraries/librewrite/ldapmap.c - servers/slapd/at.c - servers/slapd/overlays/constraint.c - servers/slapd/overlays/ppolicy.c - servers/slapd/overlays/syncprov.c - servers/slapd/overlays/unique.c - servers/slapd/passwd.c - servers/slapd/syncrepl.c - servers/slapd/syslog.c - tests/progs/slapd-mtread.c - tests/progs/slapd-search.c - tests/progs/slapd-watcher.c

View it on GitLab: https://git.openldap.org/openldap/openldap/-/compare/dab1a48896eb6de75524c9e...