Hello,
So I'm looking at the code for the /lastbind/ module, and I see the following:
"MAY ( olcLastBindPrecision $ olcLastBindForwardUpdates) )",
https://github.com/openldap/openldap/blob/master/contrib/slapd-modules/lastb...
However, when selecting various tagged releases (OPENLDAP_REL_ENG_2_4_[37-47]) I do not see the code. It was committed in October 2013:
https://github.com/openldap/openldap/commit/44e9bda0e42f40e0baf0a2c0ef733eb7...
This would have been around the time of 2.4.37, but I don't see ITS#7721 mentioned in the release notes anywhere either, only ITS#772{0,2,3,5}:
https://www.openldap.org/software/release/changes.html
Is there a reason why this commit is in "master", but never made it to any official release?
Regards, David
--On Thursday, January 17, 2019 12:34 PM -0500 David Magda dmagda@ee.ryerson.ca wrote:
It was committed in October 2013:
https://github.com/openldap/openldap/commit/44e9bda0e42f40e0baf0a2c0ef73 3eb757abd366
This would have been around the time of 2.4.37
It was not committed to the code base in 2013. The patch was *generated* in 2013. It wasn't committed until:
git show -s --format=%cd --date=short 44e9bda0e42f40e0baf0a2c0ef733eb757abd366 2017-10-11
I can discuss with the rest of the project about adding it into RE24, however it's not clear to me how it's supposed to work in an MMR environment.
Warm regards, Quanah
--
Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: http://www.symas.com
On Jan 17, 2019, at 16:45, Quanah Gibson-Mount quanah@symas.com wrote:
--On Thursday, January 17, 2019 12:34 PM -0500 David Magda dmagda@ee.ryerson.ca wrote:
It was committed in October 2013:
https://github.com/openldap/openldap/commit/44e9bda0e42f40e0baf0a2c0ef73 3eb757abd366
This would have been around the time of 2.4.37
It was not committed to the code base in 2013. The patch was *generated* in 2013. It wasn't committed until:
git show -s --format=%cd --date=short 44e9bda0e42f40e0baf0a2c0ef733eb757abd366 2017-10-11
I can discuss with the rest of the project about adding it into RE24, however it's not clear to me how it's supposed to work in an MMR environment.
Blame says “5 years ago”, though I could be misinterpreting it:
https://github.com/openldap/openldap/blame/master/contrib/slapd-modules/last...
If it’ll take until 2.5 because it’s complicated, I understand. It was just slightly confusing to see the code but not have the functionality. :)
--On Thursday, January 17, 2019 5:04 PM -0500 David Magda dmagda@ee.ryerson.ca wrote:
Blame says "5 years ago", though I could be misinterpreting it:
"Blame" is taking the date from when git-format-patch was generated. It does not show the actual date of the commit, which is what the output of git show reveals. It's actually something I find rather annoying about git. It'd be very helpful a lot of the time to know when given code was actually added to the repository vs when it was generated.
--Quanah
--
Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: http://www.symas.com
openldap-technical@openldap.org
-
David Magda -
Quanah Gibson-Mount