GitLab

at 2020-04-10T18:19:33+00:00

ITS#6567 - Remove non-cyrus-sasl GSSAPI bits

ITS#8650 loop on incomplete TLS handshake

Always retry ldap_int_tls_connect() if it didn't complete,
regardless of blocking or non-blocking socket. Code from
ITS#7428 was wrong to only retry for async.

ITS#6567 - More cleanup

ITS#9212 Restore snprintf to caller-provided buffer

76df74dbeab47195e42946a474c3a5f8557c168d removed some snprintfs to
buffers that are actually returned to the client. Restore these.

ITS#8731 cleanup unused logbuf

ITS#9043 Improve replication loggging

ITS#9203 contrib/passwd/argon2: add manual page

Add manual page slapd-pw-argon2.5 and make sure it gets installed.

Signed-off-by: Peter Marschall <peter@adpm.de>

ITS#9203 slapd-argon2 -> pw-argon2

Based on initial patch by Peter Marschall.

ITS#9206 contrib/passwd/argon2: consolidate libsodium implementation

* use 'crypto_pwhash_str_alg(..., crypto_pwhash_ALG_ARGON2ID13)' to set
  the algorithm to Argon2.
  According to libsodium's documentation, the original 'crypto_pwhash_str()'
  only guarantees a "memory-hard, CPU-intensive hash function", but not
  necessarily Argon2.  Although in released versions of libsodium Argon2 is
  the only implemented backend, this may chane in the future.
* multiply the 'memory' parameter by 1024 to align it with the libargon2
  implementation. The objective is to have consistent configuration in
  OpenLDAP's pw-argon2 module no matter what backend implementation is used.

Signed-off-by: Peter Marschall <peter@adpm.de>

ITS#9206 Initialize libsodium before calling its functions

ITS#9206 Convert libsodium default memlimit to KiB

ITS#9206 Use argon2id default values explicitly

ITS#9203 Remove default values from slapd-pw-argon2.5

The defaults vary by crypto library and possibly even version, so it's
not worth trying to keep them accurate.

ITS#7878 Replace uint32_t with unsigned in back-mdb

init.c: align mi_dbenv_flags and flags with mdb_dbi_open, which declares
flags as unsigned int.

search.c: align mi_rtxn_size with ARG_UINT; adjust ww_ctx.nentries to
silence a warning about signed/unsigned comparison.

config.c: parse checkpoint config more carefully. Reject negative or
unreasonably large values for kbytes and minutes. Ensure both values are
parsed successfully before making any changes.

Fixes a compilation failure under MinGW, where stdint.h types are not
implicitly pulled in by other headers.

ITS#9213 Make --enable-modules imply --enable-dynamic

The default for --enable-dynamic is now "auto", meaning "yes" if
--enable-modules and "no" otherwise.

ITS#9213 -- Regenerate configure

ITS#9214 slapd-mdb: plug cursor leak in dnSuperiorMatch filter

ITS#6937 - Remove unused proctitle bits

ITS#6937 -- regenerate configure/portable.hin

ITS#8245 Silence warning

ITS#8731 Remove unused arguments

ITS#9112 Silence warnings

ITS#6035 Fix test076 to specify SASL mech

ITS#9181 fix ldap_pvt_thread_mutex_t used before its definition

Merge remote-tracking branch 'origin/master' into OPENLDAP_REL_ENG_2_5

Quanah Gibson-Mount pushed to branch OPENLDAP_REL_ENG_2_5 at openldap / OpenLDAP

Commits:

30 changed files: