From milinevskyy@gmail.com Fri Apr 17 20:19:50 2015
From: milinevskyy@gmail.com
To: openldap-bugs@openldap.org
Subject: Re: (ITS#8106) Retry pwrite operations in case of EINTR
Date: Fri, 17 Apr 2015 20:19:48 +0000
Message-ID: <E1YjCjs-0001Ty-Kp@gauss.openldap.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3869370342926772338=="

--===============3869370342926772338==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

--047d7bd910b0d34afe0513f14c84
Content-Type: text/plain; charset=3DUTF-8

Hello,
we've encountered this problem mainly on Android device. The kernel sends a
fake signal and the baking storage(flash) is not so fast.
I've noticed a typo in my patch for the macro DO_PWRITE in
mdb_env_init_meta. The test should be done for EINTR, not EINVAL.
Do you want me to resend the patch?

Thanks,
Dmytro

On Fri, Apr 17, 2015 at 7:34 PM, Howard Chu <hyc(a)symas.com> wrote:

> milinevskyy(a)gmail.com wrote:
>
>> Full_Name: Dmytro Milinevskyy
>> Version:
>> OS: Linux
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (92.132.131.166)
>>
>>
>> On linux systems it's common to have system calls interrupted and
>> restarted.
>> LMDB should retry pwrites to avoid "false" failures.
>>
>
> In practice, writes to a file are "fast" and will always write at least
> one byte. But we've patched this as suggested, thanks.
>
> --
>   -- Howard Chu
>   CTO, Symas Corp.           http://www.symas.com
>   Director, Highland Sun     http://highlandsun.com/hyc/
>   Chief Architect, OpenLDAP  http://www.openldap.org/project/
>

--047d7bd910b0d34afe0513f14c84
Content-Type: text/html; charset=3DUTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D3D"ltr"><div><div><div>Hello,<br>we&#39;ve encountered this proble=
=3D
m mainly on Android device. The kernel sends a fake signal and the baking s=3D
torage(flash) is not so fast.<br>I&#39;ve noticed a typo in my patch for th=3D
e macro DO_PWRITE in mdb_env_init_meta. The test should be done for EINTR, =3D
not EINVAL.<br></div>Do you want me to resend the patch?<br><br></div>Thank=3D
s,<br></div>Dmytro<br></div><div class=3D3D"gmail_extra"><br><div class=3D3D"=
gm=3D
ail_quote">On Fri, Apr 17, 2015 at 7:34 PM, Howard Chu <span dir=3D3D"ltr">&l=
=3D
t;<a href=3D3D"mailto:hyc(a)symas.com" target=3D3D"_blank">hyc(a)symas.com</a=
>&gt;<=3D
/span> wrote:<br><blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 =
.8=3D
ex;border-left:1px #ccc solid;padding-left:1ex"><a href=3D3D"mailto:milinevsk=
=3D
yy(a)gmail.com" target=3D3D"_blank">milinevskyy(a)gmail.com</a> wrote:<br>
<blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-left:=
1p=3D
x #ccc solid;padding-left:1ex">
Full_Name: Dmytro Milinevskyy<br>
Version:<br>
OS: Linux<br>
URL: <a href=3D3D"ftp://ftp.openldap.org/incoming/" target=3D3D"_blank">ftp:/=
/f=3D
tp.openldap.org/incoming/</a><br>
Submission from: (NULL) (92.132.131.166)<br>
<br>
<br>
On linux systems it&#39;s common to have system calls interrupted and resta=3D
rted.<br>
LMDB should retry pwrites to avoid &quot;false&quot; failures.<br>
</blockquote>
<br>
In practice, writes to a file are &quot;fast&quot; and will always write at=3D
 least one byte. But we&#39;ve patched this as suggested, thanks.<span clas=3D
s=3D3D"HOEnZb"><font color=3D3D"#888888"><br>
<br>
-- <br>
=3DC2=3DA0 -- Howard Chu<br>
=3DC2=3DA0 CTO, Symas Corp.=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=
=3DA0 =3DC2=3DA0<a href=3D3D"=3D
http://www.symas.com" target=3D3D"_blank">http://www.symas.com</a><br>
=3DC2=3DA0 Director, Highland Sun=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0<a href=3D3D=
"http://highland=3D
sun.com/hyc/" target=3D3D"_blank">http://highlandsun.com/hyc/</a><br>
=3DC2=3DA0 Chief Architect, OpenLDAP=3DC2=3DA0 <a href=3D3D"http://www.openld=
ap.org/p=3D
roject/" target=3D3D"_blank">http://www.openldap.org/project/</a><br>
</font></span></blockquote></div><br></div>

--047d7bd910b0d34afe0513f14c84--




--===============3869370342926772338==--