From leo@yuriev.ru Tue Oct 20 21:14:46 2015
From: leo@yuriev.ru
To: openldap-bugs@openldap.org
Subject: Re: (ITS#8270) win32: fix conversion error
Date: Tue, 20 Oct 2015 21:14:44 +0000
Message-ID: <E1ZoeF2-00088u-6k@gauss.openldap.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0126113955408231281=="

--===============0126113955408231281==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

--001a11c23788b1353405228fbfbd
Content-Type: text/plain; charset=3DUTF-8

2015-10-20 23:09 GMT+03:00 <hyc(a)symas.com>:

> nacho.resa(a)gmail.com wrote:
> > --047d7bb03a5ac118d20522842ead
> > Content-Type: text/plain; charset=3DUTF-8
> >
> > So I took another closer look at this issue and I went for this possible
> > solution:
> >
> https://github.com/nice-software/lmdb/commit/03987789735141dc68ae8b2d0e5ad5=
2d82cc80d0
>
> That looks OK.
>
> > Basically it errors out because MSVC needs stdcall on that method.
>
> You realize of course, that this change actually has no effect on the code
> here? stdcall uses Pascal argument order instead of C order but it's moot
> since the function only has 1 argument.
>
>
No, there is another important difference:
cdecl =3D the caller is responsible to clean stack from args (e.g. addl esp,
N);
stdcall =3D the callee is responsible to clean stack from args (e.g. retn N);

--001a11c23788b1353405228fbfbd
Content-Type: text/html; charset=3DUTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D3D"ltr"><div class=3D3D"gmail_extra"><div class=3D3D"gmail_quote">=
2015=3D
-10-20 23:09 GMT+03:00  <span dir=3D3D"ltr">&lt;<a href=3D3D"mailto:hyc(a)sym=
as.c=3D
om" target=3D3D"_blank">hyc(a)symas.com</a>&gt;</span>:<br><blockquote class=
=3D3D=3D
"gmail_quote" style=3D3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;borde=
=3D
r-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><a =3D
href=3D3D"mailto:nacho.resa(a)gmail.com">nacho.resa(a)gmail.com</a> wrote:<br>
&gt; --047d7bb03a5ac118d20522842ead<br>
&gt; Content-Type: text/plain; charset=3D3DUTF-8<br>
&gt;<br>
&gt; So I took another closer look at this issue and I went for this possib=3D
le<br>
&gt; solution:<br>
&gt; <a href=3D3D"https://github.com/nice-software/lmdb/commit/03987789735141=
=3D
dc68ae8b2d0e5ad52d82cc80d0" rel=3D3D"noreferrer" target=3D3D"_blank">https://=
gi=3D
thub.com/nice-software/lmdb/commit/03987789735141dc68ae8b2d0e5ad52d82cc80d0=3D
</a><br>
<br>
That looks OK.<br>
<br>
&gt; Basically it errors out because MSVC needs stdcall on that method.<br>
<br>
You realize of course, that this change actually has no effect on the code<=3D
br>
here? stdcall uses Pascal argument order instead of C order but it&#39;s mo=3D
ot<br>
since the function only has 1 argument.<br>
<br></blockquote><div><br><div>No, there is another important difference:</=3D
div><div>cdecl =3D3D the caller is responsible to clean stack from args (e.g.=
=3D
 addl esp, N);</div>stdcall =3D3D the callee is responsible to clean stack fr=
=3D
om args (e.g. retn N);=3DC2=3DA0</div></div></div></div>

--001a11c23788b1353405228fbfbd--




--===============0126113955408231281==--