From bbaetz@google.com Wed Jan 24 22:23:35 2018 From: bbaetz@google.com To: openldap-bugs@openldap.org Subject: Re: (ITS#8791) OpenSSL 1.1.1 compat issue Date: Wed, 24 Jan 2018 22:23:33 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8456380985849587973==" --===============8456380985849587973== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable --089e082f9ab494ea2405638d1cae Content-Type: text/plain; charset=3D"UTF-8" Is there anything else I need to do in order to get this committed? Bradley On Fri, 15 Dec 2017 at 12:08 Bradley Baetz wrote: > Done in ftp://ftp.openldap.org/incoming/bradley-baetz-20171215.patch > > > On Fri, 15 Dec 2017 at 04:36 Howard Chu wrote: > >> bbaetz(a)google.com wrote: >> > Full_Name: Bradley Baetz >> > Version: 2.4.45 >> > OS: linux >> > URL: ftp://ftp.openldap.org/incoming/bradley-baetz-20171214.patch >> > Submission from: (NULL) (2401:fa00:9:11:7ac0:58b5:299c:bebb) >> >> Thanks for the patch. The initialization of the static tlso_bio_method is >> racy. One-time initializations should be done in tlso_init, and the >> allocated >> memory should be freed in tlso_destroy. >> >> > >> > ITS#8533 added support for the OpenSSL's hiding of the bio_method_st >> struct. >> > >> > However, it did this by re-defining the now-private structure, using >> the OpenSSL >> > 1.0 version. That will fail when OpenSSL changes their structure, which >> they >> > have already done for v1.1.1 - see >> > >> https://git.openssl.org/gitweb/?p=3Dopenssl.git;a=3Dblob;f=3Dinclude/inter= nal/bio.h;hb=3De1dd8fa00a1e06d27c8b024dac7657a8d8a9b451#l16 >> > >> > It also fails with BoringSSL, which has v1.0's OPENSSL_VERSION_NUMBER >> define, >> > but has not yet hidden the struct definition. >> > >> > The attached file is derived from OpenLDAP Software. All of the >> modifications to >> > OpenLDAP Software represented in the following patch(es) were developed >> by >> > Google, LLC. Google, LLC has not assigned rights and/or interest in >> this work to >> > any party. I, Bradley Baetz am authorized by Google, LLC, my employer, >> to >> > release this work under the following terms. >> > >> > The attached modifications to OpenLDAP Software are subject to the >> following >> > notice: >> > Copyright 2017 Google, LLC. >> > Redistribution and use in source and binary forms, with or without >> modification, >> > are permitted only as authorized by the OpenLDAP Public License. >> > >> > >> >> >> -- >> -- Howard Chu >> CTO, Symas Corp. http://www.symas.com >> Director, Highland Sun http://highlandsun.com/hyc/ >> Chief Architect, OpenLDAP http://www.openldap.org/project/ >> > --089e082f9ab494ea2405638d1cae Content-Type: text/html; charset=3D"UTF-8" Content-Transfer-Encoding: quoted-printable
Is there anything else I need to do in order to get this c= =3D ommitted?

Bradley

On Fri, 15 Dec 2017 at 12:08 Bradley Baetz <bbaetz(a)google.com> wrote:

On Fri, 15 Dec 2017 at 04:36 Howard Chu= &=3D lt;hyc(a)symas.com>=3D wrote:
bbaetz(a)google.com wrote:
> Full_Name: Bradley Baetz
> Version: 2.4.45
> OS: linux
> URL: ftp://ftp.openldap.org/incom= in=3D g/bradley-baetz-20171214.patch
> Submission from: (NULL) (2401:fa00:9:11:7ac0:58b5:299c:bebb)

Thanks for the patch. The initialization of the static tlso_bio_method is racy. One-time initializations should be done in tlso_init, and the allocat=3D ed
memory should be freed in tlso_destroy.

>
> ITS#8533 added support for the OpenSSL's hiding of the bio_method_=3D st struct.
>
> However, it did this by re-defining the now-private structure, using t=3D he OpenSSL
> 1.0 version. That will fail when OpenSSL changes their structure, whic=3D h they
> have already done for v1.1.1 - see
> https://git.openssl.org/gitweb/?p= =3D3D=3D openssl.git;a=3D3Dblob;f=3D3Dinclude/internal/bio.h;hb=3D3De1dd8fa00a1e06d27c= 8b02=3D 4dac7657a8d8a9b451#l16
>
> It also fails with BoringSSL, which has v1.0's OPENSSL_VERSION_NUM=3D BER define,
> but has not yet hidden the struct definition.
>
> The attached file is derived from OpenLDAP Software. All of the modifi=3D cations to
> OpenLDAP Software represented in the following patch(es) were develope=3D d by
> Google, LLC. Google, LLC has not assigned rights and/or interest in th=3D is work to
> any party. I, Bradley Baetz am authorized by Google, LLC, my employer,=3D to
> release this work under the following terms.
>
> The attached modifications to OpenLDAP Software are subject to the fol=3D lowing
> notice:
> Copyright 2017 Google, LLC.
> Redistribution and use in source and binary forms, with or without mod=3D ification,
> are permitted only as authorized by the OpenLDAP Public License.
>
>


--
=3DC2=3DA0 =3DC2=3DA0-- Howard Chu
=3DC2=3DA0 =3DC2=3DA0CTO, Symas Corp.=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2= =3DA0 =3DC2=3DA0 =3DC2=3DA0http:/= /www=3D .symas.com
=3DC2=3DA0 =3DC2=3DA0Director, Highland Sun=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0http://highlands= un=3D .com/hyc/
=3DC2=3DA0 =3DC2=3DA0Chief Architect, OpenLDAP=3DC2=3DA0 http://www.openldap.o= rg=3D /project/
--089e082f9ab494ea2405638d1cae-- --===============8456380985849587973==--