From nacho.resa@gmail.com Mon Oct 26 07:24:22 2015
From: nacho.resa@gmail.com
To: openldap-bugs@openldap.org
Subject: Re: (ITS#8270) win32: fix conversion error
Date: Mon, 26 Oct 2015 07:24:20 +0000
Message-ID: <E1Zqc8i-00070k-Tm@gauss.openldap.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0023954130603880860=="

--===============0023954130603880860==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

--f46d042184850fb03c0522fcd987
Content-Type: text/plain; charset=3DUTF-8

Howard, any chance to get this in or should I change something else?
Also, any chance you could have a look at "ITS#8274"?

Thanks in advance!

On Tue, Oct 20, 2015 at 10:37 PM, Ignacio Casal Quinteiro <
nacho.resa(a)gmail.com> wrote:

>
>
> On Tue, Oct 20, 2015 at 10:09 PM, Howard Chu <hyc(a)symas.com> wrote:
>
>> nacho.resa(a)gmail.com wrote:
>>
>>> --047d7bb03a5ac118d20522842ead
>>> Content-Type: text/plain; charset=3DUTF-8
>>>
>>> So I took another closer look at this issue and I went for this possible
>>> solution:
>>>
>>> https://github.com/nice-software/lmdb/commit/03987789735141dc68ae8b2d0e5a=
d52d82cc80d0
>>>
>>
>> That looks OK.
>>
>> Basically it errors out because MSVC needs stdcall on that method.
>>>
>>
>> You realize of course, that this change actually has no effect on the
>> code here? stdcall uses Pascal argument order instead of C order but it's
>> moot since the function only has 1 argument.
>>
>
> yeah... but if this fixes the error I am fine with it, after all it end
> ups being just a define
>
>
>>
>>
>>> Cheers.
>>>
>>> On Mon, Oct 19, 2015 at 2:55 PM, Ignacio Casal Quinteiro <
>>> nacho.resa(a)gmail.com> wrote:
>>>
>>> Sorry! I did indeed meant to change just the windows part, for some
>>>> reason
>>>> I thought it was already ifdeffed that part.
>>>>
>>>>
>>>> https://github.com/nice-software/lmdb/commit/42577fe173923c1166f8382a535=
23a31479f9d43
>>>>
>>>> This is the right patch.
>>>>
>>>> On Mon, Oct 19, 2015 at 1:43 PM, Hallvard Breien Furuseth <
>>>> h.b.furuseth(a)usit.uio.no> wrote:
>>>>
>>>> On 19. okt. 2015 08:57, nacho.resa(a)gmail.com wrote:
>>>>>
>>>>> I do not understand, I tested also with mingw64 (...)
>>>>>>
>>>>>>
>>>>> There's no LPTHREAD_START_ROUTINE type on non-Windows machines.
>>>>> You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)'
>>>>> in the _WIN32 variant of '#define THREAD_CREATE...'.
>>>>>
>>>>> However, it's still wrong to call a function via another prototype.
>>>>> Maybe that'd fall on 32-bit Windows or something, I don't know
>>>>> how LPTHREAD_START_ROUTINE is defined.  The safe way would be to
>>>>> give mdb_env_copythr() a prototype which does not need a cast.
>>>>> There is some code for that already. Maybe it can be improved.
>>>>>
>>>>> --
>>>>> Hallvard
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Ignacio Casal Quinteiro
>>>>
>>>>
>>>
>>>
>>>
>>
>> --
>>   -- Howard Chu
>>   CTO, Symas Corp.           http://www.symas.com
>>   Director, Highland Sun     http://highlandsun.com/hyc/
>>   Chief Architect, OpenLDAP  http://www.openldap.org/project/
>>
>
>
>
> --
> Ignacio Casal Quinteiro
>



--=20
Ignacio Casal Quinteiro

--f46d042184850fb03c0522fcd987
Content-Type: text/html; charset=3DUTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D3D"ltr"><div><div>Howard, any chance to get this in or should I ch=
=3D
ange something else?<br></div>Also, any chance you could have a look at &qu=3D
ot;ITS#8274&quot;?<br><br></div>Thanks in advance!<br></div><div class=3D3D"g=
=3D
mail_extra"><br><div class=3D3D"gmail_quote">On Tue, Oct 20, 2015 at 10:37 PM=
=3D
, Ignacio Casal Quinteiro <span dir=3D3D"ltr">&lt;<a href=3D3D"mailto:nacho.r=
es=3D
a(a)gmail.com" target=3D3D"_blank">nacho.resa(a)gmail.com</a>&gt;</span> wrot=
e:<b=3D
r><blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-lef=
t:=3D
1px #ccc solid;padding-left:1ex"><div dir=3D3D"ltr"><br><div class=3D3D"gmail=
_e=3D
xtra"><br><div class=3D3D"gmail_quote"><span class=3D3D"">On Tue, Oct 20, 201=
5 =3D
at 10:09 PM, Howard Chu <span dir=3D3D"ltr">&lt;<a href=3D3D"mailto:hyc(a)sym=
as.c=3D
om" target=3D3D"_blank">hyc(a)symas.com</a>&gt;</span> wrote:<br><blockquote =
cl=3D
ass=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-left:1px #ccc solid=
;p=3D
adding-left:1ex"><a href=3D3D"mailto:nacho.resa(a)gmail.com" target=3D3D"_bla=
nk">=3D
nacho.resa(a)gmail.com</a> wrote:<br>
<blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-left:=
1p=3D
x #ccc solid;padding-left:1ex">
--047d7bb03a5ac118d20522842ead<br>
Content-Type: text/plain; charset=3D3DUTF-8<span><br>
<br>
So I took another closer look at this issue and I went for this possible<br=3D
>
solution:<br>
<a href=3D3D"https://github.com/nice-software/lmdb/commit/03987789735141dc68a=
=3D
e8b2d0e5ad52d82cc80d0" rel=3D3D"noreferrer" target=3D3D"_blank">https://githu=
b.=3D
com/nice-software/lmdb/commit/03987789735141dc68ae8b2d0e5ad52d82cc80d0</a><=3D
br>
</span></blockquote>
<br>
That looks OK.<span><br>
<br>
<blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-left:=
1p=3D
x #ccc solid;padding-left:1ex">
Basically it errors out because MSVC needs stdcall on that method.<br>
</blockquote>
<br></span>
You realize of course, that this change actually has no effect on the code =3D
here? stdcall uses Pascal argument order instead of C order but it&#39;s mo=3D
ot since the function only has 1 argument.<span><br></span></blockquote><di=3D
v><br></div></span><div>yeah... but if this fixes the error I am fine with =3D
it, after all it end ups being just a define<br></div><div><div class=3D3D"h5=
=3D
"><div>=3DC2=3DA0</div><blockquote class=3D3D"gmail_quote" style=3D3D"margin:=
0 0 0 =3D
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
<br>
<blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-left:=
1p=3D
x #ccc solid;padding-left:1ex">
<br>
Cheers.<br>
<br>
On Mon, Oct 19, 2015 at 2:55 PM, Ignacio Casal Quinteiro &lt;<br>
<a href=3D3D"mailto:nacho.resa(a)gmail.com" target=3D3D"_blank">nacho.resa(a)=
gmail.=3D
com</a>&gt; wrote:<br>
<br>
<blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-left:=
1p=3D
x #ccc solid;padding-left:1ex">
Sorry! I did indeed meant to change just the windows part, for some reason<=3D
br>
I thought it was already ifdeffed that part.<br>
<br>
<a href=3D3D"https://github.com/nice-software/lmdb/commit/42577fe173923c1166f=
=3D
8382a53523a31479f9d43" rel=3D3D"noreferrer" target=3D3D"_blank">https://githu=
b.=3D
com/nice-software/lmdb/commit/42577fe173923c1166f8382a53523a31479f9d43</a><=3D
br>
<br>
This is the right patch.<br>
<br>
On Mon, Oct 19, 2015 at 1:43 PM, Hallvard Breien Furuseth &lt;<br>
<a href=3D3D"mailto:h.b.furuseth(a)usit.uio.no" target=3D3D"_blank">h.b.furus=
eth@=3D
usit.uio.no</a>&gt; wrote:<br>
<br>
<blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-left:=
1p=3D
x #ccc solid;padding-left:1ex">
On 19. okt. 2015 08:57, <a href=3D3D"mailto:nacho.resa(a)gmail.com" target=3D=
3D"_=3D
blank">nacho.resa(a)gmail.com</a> wrote:<br>
<br>
<blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-left:=
1p=3D
x #ccc solid;padding-left:1ex">
I do not understand, I tested also with mingw64 (...)<br>
<br>
</blockquote>
<br>
There&#39;s no LPTHREAD_START_ROUTINE type on non-Windows machines.<br>
You could replace &#39;start&#39; with &#39;(LPTHREAD_START_ROUTINE)(start)=3D
&#39;<br>
in the _WIN32 variant of &#39;#define THREAD_CREATE...&#39;.<br>
<br>
However, it&#39;s still wrong to call a function via another prototype.<br>
Maybe that&#39;d fall on 32-bit Windows or something, I don&#39;t know<br>
how LPTHREAD_START_ROUTINE is defined.=3DC2=3DA0 The safe way would be to<br>
give mdb_env_copythr() a prototype which does not need a cast.<br>
There is some code for that already. Maybe it can be improved.<br>
<br>
--<br>
Hallvard<br>
<br>
</blockquote>
<br>
<br>
<br>
--<br>
Ignacio Casal Quinteiro<br>
<br>
</blockquote>
<br>
<br>
<br>
</blockquote>
<br>
<br>
-- <br></span><div><div>
=3DC2=3DA0 -- Howard Chu<br>
=3DC2=3DA0 CTO, Symas Corp.=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=
=3DA0 =3DC2=3DA0<a href=3D3D"=3D
http://www.symas.com" rel=3D3D"noreferrer" target=3D3D"_blank">http://www.sym=
as=3D
.com</a><br>
=3DC2=3DA0 Director, Highland Sun=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0<a href=3D3D=
"http://highland=3D
sun.com/hyc/" rel=3D3D"noreferrer" target=3D3D"_blank">http://highlandsun.com=
/h=3D
yc/</a><br>
=3DC2=3DA0 Chief Architect, OpenLDAP=3DC2=3DA0 <a href=3D3D"http://www.openld=
ap.org/p=3D
roject/" rel=3D3D"noreferrer" target=3D3D"_blank">http://www.openldap.org/pro=
je=3D
ct/</a><br>
</div></div></blockquote></div></div></div><span class=3D3D"HOEnZb"><font col=
=3D
or=3D3D"#888888"><br><br clear=3D3D"all"><br>-- <br><div>Ignacio Casal Quinte=
ir=3D
o</div>
</font></span></div></div>
</blockquote></div><br><br clear=3D3D"all"><br>-- <br><div class=3D3D"gmail_s=
ig=3D
nature">Ignacio Casal Quinteiro</div>
</div>

--f46d042184850fb03c0522fcd987--




--===============0023954130603880860==--