From nacho.resa@gmail.com Mon Oct 19 06:12:27 2015
From: nacho.resa@gmail.com
To: openldap-bugs@openldap.org
Subject: Re: (ITS#8270) win32: fix conversion error
Date: Mon, 19 Oct 2015 06:12:25 +0000
Message-ID: <E1Zo3gH-00080Y-Bv@gauss.openldap.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8408481380903257444=="

--===============8408481380903257444==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

--047d7bfd0df8f33b1905226f06af
Content-Type: text/plain; charset=3DUTF-8

I am ok not fixing the MSVC warnings because it is picky even though some
of them might make sense even for mingw, but in this case it is an error
and this really small change enable msvc to build without errors. Can't you
reconsider the change? Specially since it will build fine with mingw as
well.

On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <hyc(a)symas.com> wrote:

> nacho.resa(a)gmail.com wrote:
>
>> Full_Name: Ignacio Casal Quinteiro
>> Version:
>> OS: Windows 7
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa)
>>
>>
>>
>> https://github.com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a898=
a4f155e3dce
>>
>>
>> I see no error when compiling with gcc -Wall. Closing this ITS.
>
> --
>   -- Howard Chu
>   CTO, Symas Corp.           http://www.symas.com
>   Director, Highland Sun     http://highlandsun.com/hyc/
>   Chief Architect, OpenLDAP  http://www.openldap.org/project/
>



--=20
Ignacio Casal Quinteiro

--047d7bfd0df8f33b1905226f06af
Content-Type: text/html; charset=3DUTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D3D"ltr">I am ok not fixing the MSVC warnings because it is picky e=
=3D
ven though some of them might make sense even for mingw, but in this case i=3D
t is an error and this really small change enable msvc to build without err=3D
ors. Can&#39;t you reconsider the change? Specially since it will build fin=3D
e with mingw as well.<br></div><div class=3D3D"gmail_extra"><br><div class=3D=
3D=3D
"gmail_quote">On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <span dir=3D3D"ltr"=
=3D
>&lt;<a href=3D3D"mailto:hyc(a)symas.com" target=3D3D"_blank">hyc(a)symas.com=
</a>&g=3D
t;</span> wrote:<br><blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0=
 0=3D
 .8ex;border-left:1px #ccc solid;padding-left:1ex"><a href=3D3D"mailto:nacho.=
=3D
resa(a)gmail.com" target=3D3D"_blank">nacho.resa(a)gmail.com</a> wrote:<br>
<blockquote class=3D3D"gmail_quote" style=3D3D"margin:0 0 0 .8ex;border-left:=
1p=3D
x #ccc solid;padding-left:1ex">
Full_Name: Ignacio Casal Quinteiro<br>
Version:<br>
OS: Windows 7<br>
URL: <a href=3D3D"ftp://ftp.openldap.org/incoming/" rel=3D3D"noreferrer" targ=
et=3D
=3D3D"_blank">ftp://ftp.openldap.org/incoming/</a><br>
Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa)<br>
<br>
<br>
<a href=3D3D"https://github.com/nice-software/lmdb/commit/076281a2c03356667fc=
=3D
a7cce1a898a4f155e3dce" rel=3D3D"noreferrer" target=3D3D"_blank">https://githu=
b.=3D
com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a898a4f155e3dce</a><=3D
br>
<br>
<br>
</blockquote>
I see no error when compiling with gcc -Wall. Closing this ITS.<span class=3D
=3D3D"HOEnZb"><font color=3D3D"#888888"><br>
<br>
-- <br>
=3DC2=3DA0 -- Howard Chu<br>
=3DC2=3DA0 CTO, Symas Corp.=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0 =3DC2=
=3DA0 =3DC2=3DA0<a href=3D3D"=3D
http://www.symas.com" rel=3D3D"noreferrer" target=3D3D"_blank">http://www.sym=
as=3D
.com</a><br>
=3DC2=3DA0 Director, Highland Sun=3DC2=3DA0 =3DC2=3DA0 =3DC2=3DA0<a href=3D3D=
"http://highland=3D
sun.com/hyc/" rel=3D3D"noreferrer" target=3D3D"_blank">http://highlandsun.com=
/h=3D
yc/</a><br>
=3DC2=3DA0 Chief Architect, OpenLDAP=3DC2=3DA0 <a href=3D3D"http://www.openld=
ap.org/p=3D
roject/" rel=3D3D"noreferrer" target=3D3D"_blank">http://www.openldap.org/pro=
je=3D
ct/</a><br>
</font></span></blockquote></div><br><br clear=3D3D"all"><br>-- <br><div clas=
=3D
s=3D3D"gmail_signature">Ignacio Casal Quinteiro</div>
</div>

--047d7bfd0df8f33b1905226f06af--




--===============8408481380903257444==--